-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon MQ throughput-optimized message brokers #11459
Amazon MQ throughput-optimized message brokers #11459
Conversation
Hi @bflad, |
Hi, I've rebased this development over the last release. I've relaunched all acceptance tests and all are passed on the MQ features. $ make testacc TEST=./aws TESTARGS='-run=TestAccAWSMq'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSMq -timeout 120m
=== RUN TestAccAWSMqBroker_basic
=== PAUSE TestAccAWSMqBroker_basic
=== RUN TestAccAWSMqBroker_throughputOptimized
=== PAUSE TestAccAWSMqBroker_throughputOptimized
=== RUN TestAccAWSMqBroker_allFieldsDefaultVpc
=== PAUSE TestAccAWSMqBroker_allFieldsDefaultVpc
=== RUN TestAccAWSMqBroker_allFieldsCustomVpc
=== PAUSE TestAccAWSMqBroker_allFieldsCustomVpc
=== RUN TestAccAWSMqBroker_EncryptionOptions_KmsKeyId
=== PAUSE TestAccAWSMqBroker_EncryptionOptions_KmsKeyId
=== RUN TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Disabled
=== PAUSE TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Disabled
=== RUN TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Enabled
=== PAUSE TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Enabled
=== RUN TestAccAWSMqBroker_updateUsers
=== PAUSE TestAccAWSMqBroker_updateUsers
=== RUN TestAccAWSMqBroker_updateTags
=== PAUSE TestAccAWSMqBroker_updateTags
=== RUN TestAccAWSMqBroker_updateSecurityGroup
=== PAUSE TestAccAWSMqBroker_updateSecurityGroup
=== RUN TestAccAWSMqBroker_disappears
=== PAUSE TestAccAWSMqBroker_disappears
=== RUN TestAccAWSMqConfiguration_basic
=== PAUSE TestAccAWSMqConfiguration_basic
=== RUN TestAccAWSMqConfiguration_withData
=== PAUSE TestAccAWSMqConfiguration_withData
=== RUN TestAccAWSMqConfiguration_updateTags
=== PAUSE TestAccAWSMqConfiguration_updateTags
=== CONT TestAccAWSMqBroker_basic
=== CONT TestAccAWSMqBroker_updateTags
=== CONT TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Enabled
=== CONT TestAccAWSMqBroker_updateUsers
=== CONT TestAccAWSMqConfiguration_withData
=== CONT TestAccAWSMqConfiguration_updateTags
=== CONT TestAccAWSMqBroker_EncryptionOptions_KmsKeyId
=== CONT TestAccAWSMqBroker_allFieldsDefaultVpc
=== CONT TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Disabled
=== CONT TestAccAWSMqBroker_disappears
=== CONT TestAccAWSMqBroker_allFieldsCustomVpc
=== CONT TestAccAWSMqConfiguration_basic
=== CONT TestAccAWSMqBroker_throughputOptimized
=== CONT TestAccAWSMqBroker_updateSecurityGroup
--- PASS: TestAccAWSMqConfiguration_withData (36.82s)
--- PASS: TestAccAWSMqConfiguration_basic (61.86s)
--- PASS: TestAccAWSMqConfiguration_updateTags (89.84s)
--- PASS: TestAccAWSMqBroker_throughputOptimized (852.44s)
--- PASS: TestAccAWSMqBroker_basic (1140.31s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Enabled (1141.84s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_KmsKeyId (1161.45s)
--- PASS: TestAccAWSMqBroker_disappears (1170.60s)
--- PASS: TestAccAWSMqBroker_updateTags (1234.79s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Disabled (1261.30s)
--- PASS: TestAccAWSMqBroker_updateSecurityGroup (1484.36s)
--- PASS: TestAccAWSMqBroker_updateUsers (1584.28s)
--- PASS: TestAccAWSMqBroker_allFieldsDefaultVpc (2005.72s)
--- PASS: TestAccAWSMqBroker_allFieldsCustomVpc (2012.93s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 2013.016s
|
I've realized a rebase from 3.7.0 |
Any ETA for this to be merged? |
@gdepuille are there any updates? Would love to be able to make use of this! |
@ziek-za I'm sorry that this PR is not included in the basic version. I use this in production since it's submitted. If you want to use it, it's possible to make a custom version of the provider with the commits you need. It's just you need some piece of time when new features are added in the core version. |
@gdepuille Thank you for this PR! We performed significant MQ reorganization in #16108. It looks like your PR may have some helpful tests beyond that. Please rebase when you have a chance. |
@YakDriver I've just been rebase this one. I've relaunch acceptance tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes! There are just a few minor fixes and we should be good to go!
Co-authored-by: Dirk Avery <[email protected]>
Co-authored-by: Dirk Avery <[email protected]>
Co-authored-by: Dirk Avery <[email protected]>
Co-authored-by: Dirk Avery <[email protected]>
@YakDriver I trust you for the documentation because it's not my native language ;-) I've validated all your suggestion. I'm very happy this PR is near to be validated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
Acceptance tests:
--- PASS: TestAccAWSMqBroker_rabbitmq (549.56s)
--- PASS: TestAccAWSMqBroker_throughputOptimized (791.92s)
--- PASS: TestAccAWSMqBroker_disappears (1138.54s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Disabled (1182.12s)
--- PASS: TestAccAWSMqBroker_basic (1191.68s)
--- PASS: TestAccAWSMqBroker_updateTags (1199.67s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Enabled (1225.50s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_KmsKeyId (1286.37s)
--- PASS: TestAccAWSMqBroker_updateSecurityGroup (1346.46s)
--- PASS: TestAccAWSMqBroker_updateUsers (1590.61s)
--- PASS: TestAccAWSMqBroker_allFieldsDefaultVpc (1696.42s)
--- PASS: TestAccAWSMqBroker_allFieldsCustomVpc (1748.95s)
This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #11325
Release note for CHANGELOG:
Output from acceptance testing: