Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glacier_vault: fix policy diff + read after create + refactor tests #12645

Merged
merged 14 commits into from
Jan 29, 2021
Merged

r/glacier_vault: fix policy diff + read after create + refactor tests #12645

merged 14 commits into from
Jan 29, 2021

Commits on Sep 30, 2020

  1. add plan time validation to sns_topic 

    remove from state if doesnt exist
add nil check to access policy

refactor and add tests
    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    e906241 View commit details
    Browse the repository at this point in the history

  2. refactor validation

    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    408e3e9 View commit details
    Browse the repository at this point in the history

  3. fix notif test

    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    62bf4ea View commit details
    Browse the repository at this point in the history

  4. fix policy

    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    b9a1843 View commit details
    Browse the repository at this point in the history

  5. add error handling

    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    22eb594 View commit details
    Browse the repository at this point in the history

  6. add error handling

    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    e46e488 View commit details
    Browse the repository at this point in the history

  7. refactor disappears

    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    c85717f View commit details
    Browse the repository at this point in the history

  8. read after create

    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    d7ede76 View commit details
    Browse the repository at this point in the history

  9. use %w for errors

    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    2d6997e View commit details
    Browse the repository at this point in the history

  10. add plan time validation for events

    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    05d2693 View commit details
    Browse the repository at this point in the history

  11. improve policy test

    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    11ba015 View commit details
    Browse the repository at this point in the history

  12. test lint

    @DrFaust92
    DrFaust92 committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    32efc42 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2021

  1. Update aws/resource_aws_glacier_vault_test.go

    @bflad
    bflad authored Jan 29, 2021
    Configuration menu
    Copy the full SHA
    069bcae View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @bflad
    bflad authored Jan 29, 2021
    Configuration menu
    Copy the full SHA
    b123361 View commit details
    Browse the repository at this point in the history