Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing zone_id reference #12885

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fixing zone_id reference #12885

merged 1 commit into from
Apr 23, 2020

Conversation

mousedownmike
Copy link
Contributor

zone_id was being referenced as just id from the aws_route53_zone data sources in the example.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
`aws_acm_certificate_validation` documentation update to fix erroneous `zone_id` references in the `aws_route53_zone` data source.

Output from acceptance testing:

`zone_id` was being referenced as just `id` from the `aws_route53_zone` data sources in the example.
@mousedownmike mousedownmike requested a review from a team April 18, 2020 19:43
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/acm Issues and PRs that pertain to the acm service. documentation Introduces or discusses updates to documentation. labels Apr 18, 2020
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 23, 2020
@bflad bflad added this to the v2.59.0 milestone Apr 23, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mousedownmike 👋 Thank you for submitting this. Its worth noting that the aws_route53_zone data source code sets both the id and zone_id to the same values:

https://github.com/terraform-providers/terraform-provider-aws/blob/cadc383302e7db2df707c15f3c62983614aae602/aws/data_source_aws_route53_zone.go#L158-L159

But we'll pull this in just to remove any potential confusion. Thanks.

@bflad bflad merged commit dc7d88e into hashicorp:master Apr 23, 2020
@ghost
Copy link

ghost commented Apr 24, 2020

This has been released in version 2.59.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/acm Issues and PRs that pertain to the acm service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants