Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WorkSpaces acceptance tests to use pre-existing IAM role #13327

Merged
merged 3 commits into from
May 27, 2020
Merged

Update WorkSpaces acceptance tests to use pre-existing IAM role #13327

merged 3 commits into from
May 27, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented May 14, 2020 •
edited
Loading

Add acceptance test pre-check for workspaces_DefaultRole and make WorkSpaces tests parallel.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11519

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsWorkspacesDirectory_\|TestAccAwsWorkspacesWorkspace_'

--- PASS: TestAccAwsWorkspacesDirectory_subnetIds (614.54s)
--- PASS: TestAccAwsWorkspacesDirectory_basic (617.48s)
--- PASS: TestAccAwsWorkspacesDirectory_tags (640.75s)
--- PASS: TestAccAwsWorkspacesDirectory_disappears (650.60s)
--- PASS: TestAccAwsWorkspacesWorkspace_validateUserVolumeSize (1.45s)
--- PASS: TestAccAwsWorkspacesWorkspace_validateRootVolumeSize (1.40s)
--- PASS: TestAccAwsWorkspacesWorkspace_workspaceProperties (1876.83s)
--- PASS: TestAccAwsWorkspacesWorkspace_basic (2040.75s)
--- PASS: TestAccAwsWorkspacesWorkspace_tags (2122.44s)

@ghost ghost added service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. terraform-plugin-sdk-migration labels May 14, 2020
@gdavison gdavison force-pushed the t-parallelize-workspaces-acctests branch from b0a1917 to 091be1c Compare May 14, 2020 21:50
@hashicorp hashicorp deleted a comment May 14, 2020
bflad
bflad reviewed May 14, 2020
View reviewed changes
aws/internal/service/workspaces/waiter/status.go Outdated
"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
)

func DirectoryRefreshStateFunc(conn *workspaces.WorkSpaces, directoryID string) resource.StateRefreshFunc {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I updated the waiter package proposal to include more information about naming conventions: #12840 e.g. DirectoryState in this case. 👍 If you have feels on changing those naming conventions please do drop a note!

@gdavison gdavison force-pushed the t-parallelize-workspaces-acctests branch from 091be1c to 65722dd Compare May 26, 2020 21:41
@gdavison gdavison force-pushed the t-parallelize-workspaces-acctests branch from 65722dd to 224a3a7 Compare May 26, 2020 21:49
@gdavison gdavison marked this pull request as ready for review May 26, 2020 22:36
@gdavison gdavison requested a review from a team May 26, 2020 22:36
@bflad bflad self-assigned this May 26, 2020
bflad
bflad approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccAwsWorkspacesWorkspace_validateUserVolumeSize (1.28s)
--- PASS: TestAccAwsWorkspacesWorkspace_validateRootVolumeSize (1.31s)
--- PASS: TestAccAwsWorkspacesDirectory_subnetIds (537.24s)
--- PASS: TestAccAwsWorkspacesDirectory_basic (553.08s)
--- PASS: TestAccAwsWorkspacesDirectory_tags (559.64s)
--- PASS: TestAccAwsWorkspacesDirectory_disappears (572.51s)
--- PASS: TestAccAwsWorkspacesWorkspace_basic (1852.21s)
--- PASS: TestAccAwsWorkspacesWorkspace_workspaceProperties (2008.93s)
--- PASS: TestAccAwsWorkspacesWorkspace_tags (2059.75s)

@gdavison gdavison merged commit d3bf2a5 into master May 27, 2020
@gdavison gdavison deleted the t-parallelize-workspaces-acctests branch May 27, 2020 16:56
@gdavison gdavison added this to the v2.64.0 milestone May 27, 2020
@ghost
Copy link

ghost commented May 29, 2020

This has been released in version 2.64.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jun 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.64.0
Development

Successfully merging this pull request may close these issues.

Parallelize WorkSpaces Directory tests
2 participants
@gdavison @bflad