-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment type to aws_fsx_lustre_file_system #13639
Merged
breathingdust
merged 1 commit into
hashicorp:master
from
pdtpartners:f-aws_fsx_lustre_file_system-deployment_type
Jul 28, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,6 +94,7 @@ func TestAccAWSFsxLustreFileSystem_basic(t *testing.T) { | |
resource.TestCheckResourceAttr(resourceName, "tags.%", "0"), | ||
resource.TestMatchResourceAttr(resourceName, "vpc_id", regexp.MustCompile(`^vpc-.+`)), | ||
resource.TestMatchResourceAttr(resourceName, "weekly_maintenance_start_time", regexp.MustCompile(`^\d:\d\d:\d\d$`)), | ||
resource.TestCheckResourceAttr(resourceName, "deployment_type", fsx.LustreDeploymentTypeScratch1), | ||
), | ||
}, | ||
{ | ||
|
@@ -102,6 +103,10 @@ func TestAccAWSFsxLustreFileSystem_basic(t *testing.T) { | |
ImportStateVerify: true, | ||
ImportStateVerifyIgnore: []string{"security_group_ids"}, | ||
}, | ||
{ | ||
Config: testAccAwsFsxLustreFileSystemDeploymentType(fsx.LustreDeploymentTypeScratch1), | ||
PlanOnly: true, | ||
}, | ||
}, | ||
}) | ||
} | ||
|
@@ -382,6 +387,60 @@ func TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime(t *testing.T) { | |
}) | ||
} | ||
|
||
func TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1(t *testing.T) { | ||
var filesystem fsx.FileSystem | ||
resourceName := "aws_fsx_lustre_file_system.test" | ||
|
||
resource.ParallelTest(t, resource.TestCase{ | ||
PreCheck: func() { testAccPreCheck(t) }, | ||
Providers: testAccProviders, | ||
CheckDestroy: testAccCheckFsxLustreFileSystemDestroy, | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: testAccAwsFsxLustreFileSystemPersistentDeploymentType(50), | ||
Check: resource.ComposeTestCheckFunc( | ||
testAccCheckFsxLustreFileSystemExists(resourceName, &filesystem), | ||
// per_unit_storage_throughput is only available with deployment_type=PERSISTENT_1, so we test both here. | ||
resource.TestCheckResourceAttr(resourceName, "per_unit_storage_throughput", "50"), | ||
resource.TestCheckResourceAttr(resourceName, "deployment_type", fsx.LustreDeploymentTypePersistent1), | ||
), | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add:
to the added tests? |
||
{ | ||
ResourceName: resourceName, | ||
ImportState: true, | ||
ImportStateVerify: true, | ||
ImportStateVerifyIgnore: []string{"security_group_ids"}, | ||
}, | ||
}, | ||
}) | ||
} | ||
|
||
func TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2(t *testing.T) { | ||
var filesystem fsx.FileSystem | ||
resourceName := "aws_fsx_lustre_file_system.test" | ||
|
||
resource.ParallelTest(t, resource.TestCase{ | ||
PreCheck: func() { testAccPreCheck(t) }, | ||
Providers: testAccProviders, | ||
CheckDestroy: testAccCheckFsxLustreFileSystemDestroy, | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: testAccAwsFsxLustreFileSystemDeploymentType(fsx.LustreDeploymentTypeScratch2), | ||
Check: resource.ComposeTestCheckFunc( | ||
testAccCheckFsxLustreFileSystemExists(resourceName, &filesystem), | ||
resource.TestCheckResourceAttr(resourceName, "deployment_type", fsx.LustreDeploymentTypeScratch2), | ||
), | ||
}, | ||
{ | ||
ResourceName: resourceName, | ||
ImportState: true, | ||
ImportStateVerify: true, | ||
ImportStateVerifyIgnore: []string{"security_group_ids"}, | ||
}, | ||
}, | ||
}) | ||
} | ||
|
||
func testAccCheckFsxLustreFileSystemExists(resourceName string, fs *fsx.FileSystem) resource.TestCheckFunc { | ||
return func(s *terraform.State) error { | ||
rs, ok := s.RootModule().Resources[resourceName] | ||
|
@@ -671,3 +730,24 @@ resource "aws_fsx_lustre_file_system" "test" { | |
} | ||
`, weeklyMaintenanceStartTime) | ||
} | ||
|
||
func testAccAwsFsxLustreFileSystemDeploymentType(deploymentType string) string { | ||
return testAccAwsFsxLustreFileSystemConfigBase() + fmt.Sprintf(` | ||
resource "aws_fsx_lustre_file_system" "test" { | ||
storage_capacity = 1200 | ||
subnet_ids = ["${aws_subnet.test1.id}"] | ||
deployment_type = %[1]q | ||
} | ||
`, deploymentType) | ||
} | ||
|
||
func testAccAwsFsxLustreFileSystemPersistentDeploymentType(perUnitStorageThroughput int) string { | ||
return testAccAwsFsxLustreFileSystemConfigBase() + fmt.Sprintf(` | ||
resource "aws_fsx_lustre_file_system" "test" { | ||
storage_capacity = 1200 | ||
subnet_ids = ["${aws_subnet.test1.id}"] | ||
deployment_type = "PERSISTENT_1" | ||
per_unit_storage_throughput = %[1]d | ||
} | ||
`, perUnitStorageThroughput) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took out the separate per unit storage throughput test, and combined it into this one, since per unit storage throughput is only valid for persistent1 type lustre.