r/aws_route: Refactor acceptance tests in preparation for future fixes/enhancements #14014

ewbankkit · 2020-07-01T15:45:03Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Builds on: None (unmerged)
Dependents: #16930, #16961, #17291, #17295

Relates #12994 (remove hardcoded AMI).

Refactoring aws_route resource acceptance tests in preparation for future fixes/enhancements.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_routeTableDisappears
=== PAUSE TestAccAWSRoute_routeTableDisappears
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== CONT  TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_basic (52.02s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (62.65s)
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (76.93s)
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (61.92s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (305.27s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (42.01s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (226.70s)
=== CONT  TestAccAWSRoute_IPv4_To_Instance
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface (48.10s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
--- PASS: TestAccAWSRoute_IPv4_To_Instance (98.66s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv6_To_Instance (119.84s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (74.82s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (43.13s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface (49.04s)
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (59.00s)
=== CONT  TestAccAWSRoute_routeTableDisappears
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (51.73s)
=== CONT  TestAccAWSRoute_disappears
--- PASS: TestAccAWSRoute_routeTableDisappears (49.25s)
--- PASS: TestAccAWSRoute_disappears (48.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	739.934s

aws/resource_aws_route_table_test.go

ewbankkit · 2020-07-04T21:38:43Z

Added a test case as mentioned here and commented it out as the test fails.

ewbankkit · 2020-08-09T22:23:06Z

Rebased to fix merge conflicts.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_routeTableDisappears
=== PAUSE TestAccAWSRoute_routeTableDisappears
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== CONT  TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_IPv4_To_Instance
--- PASS: TestAccAWSRoute_basic (41.11s)
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (49.06s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_Instance (127.98s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (61.68s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (31.20s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (35.83s)
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (40.20s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (42.92s)
=== CONT  TestAccAWSRoute_routeTableDisappears
--- PASS: TestAccAWSRoute_IPv6_To_Instance (116.05s)
=== CONT  TestAccAWSRoute_disappears
--- PASS: TestAccAWSRoute_routeTableDisappears (38.34s)
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_disappears (37.63s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (49.09s)
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (57.59s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (30.14s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (193.91s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (333.38s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (34.67s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (142.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	736.952s

ewbankkit · 2020-08-22T22:30:46Z

Rebased and re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_routeTableDisappears
=== PAUSE TestAccAWSRoute_routeTableDisappears
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== CONT  TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_IPv4_To_Instance
--- PASS: TestAccAWSRoute_basic (39.79s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (59.87s)
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv4_To_Instance (101.81s)
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (47.32s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (212.74s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (29.14s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (332.31s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (34.77s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (115.81s)
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (42.36s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv6_To_Instance (118.35s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (54.41s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (30.89s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (33.84s)
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (44.68s)
=== CONT  TestAccAWSRoute_routeTableDisappears
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (39.12s)
=== CONT  TestAccAWSRoute_disappears
=== CONT  TestAccAWSRoute_routeTableDisappears
    resource_aws_route_test.go:89: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute_routeTableDisappears (37.25s)
=== CONT  TestAccAWSRoute_disappears
    resource_aws_route_test.go:65: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute_disappears (36.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	712.961s

ewbankkit · 2020-09-04T18:04:42Z

Rebased and fixed merge conflict.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_routeTableDisappears
=== PAUSE TestAccAWSRoute_routeTableDisappears
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv6_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv6_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv4_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv4_To_LocalGateway
=== RUN   TestAccAWSRoute_IPv6_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv6_To_LocalGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== CONT  TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_basic (38.91s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (31.82s)
=== CONT  TestAccAWSRoute_IPv4_To_Instance
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (105.67s)
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (49.14s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_Instance (90.94s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (30.95s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (48.85s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (33.13s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (44.90s)
=== CONT  TestAccAWSRoute_routeTableDisappears
    resource_aws_route_test.go:90: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute_IPv6_To_Instance (103.04s)
=== CONT  TestAccAWSRoute_disappears
--- PASS: TestAccAWSRoute_routeTableDisappears (37.28s)
=== CONT  TestAccAWSRoute_IPv4_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts Outpost found
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.62s)
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
=== CONT  TestAccAWSRoute_disappears
    resource_aws_route_test.go:66: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSRoute_disappears (36.30s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (39.22s)
=== CONT  TestAccAWSRoute_IPv6_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts Outpost found
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (1.65s)
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (47.20s)
=== CONT  TestAccAWSRoute_IPv6_To_TransitGateway
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (60.48s)
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (331.00s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (330.01s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (29.57s)
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (202.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	931.450s

ewbankkit · 2020-09-04T19:58:47Z

@FireballDWF Is it possible to verify the updated local gateway route tests (I added a test for an IPv6 route)?

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_IPv4_To_LocalGateway\|TestAccAWSRoute_IPv6_To_LocalGateway'

Thanks.

DrFaust92 · 2020-11-14T17:44:53Z

@ewbankkit can you look at merge conflicts?

ewbankkit · 2020-11-15T23:26:12Z

Rebased and resolved merge conflicts.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_ -timeout 120m
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_routeTableDisappears
=== PAUSE TestAccAWSRoute_routeTableDisappears
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv6_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv6_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv4_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv4_To_LocalGateway
=== RUN   TestAccAWSRoute_IPv6_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv6_To_LocalGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== RUN   TestAccAWSRoute_IPv4_To_VpcEndpoint
=== PAUSE TestAccAWSRoute_IPv4_To_VpcEndpoint
=== CONT  TestAccAWSRoute_basic
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_basic (36.08s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcEndpoint
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (143.27s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (52.54s)
=== CONT  TestAccAWSRoute_IPv6_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (1.31s)
=== CONT  TestAccAWSRoute_IPv4_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.10s)
=== CONT  TestAccAWSRoute_IPv6_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (264.48s)
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (347.40s)
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (43.32s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (368.71s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (25.18s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (58.90s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (208.19s)
=== CONT  TestAccAWSRoute_IPv4_To_Instance
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (57.65s)
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (37.92s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (43.17s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (25.24s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (37.49s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
--- PASS: TestAccAWSRoute_IPv4_To_Instance (327.06s)
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (35.48s)
=== CONT  TestAccAWSRoute_routeTableDisappears
--- PASS: TestAccAWSRoute_routeTableDisappears (32.92s)
=== CONT  TestAccAWSRoute_disappears
--- PASS: TestAccAWSRoute_disappears (32.04s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (329.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1283.954s

ewbankkit · 2020-12-08T14:40:59Z

aws/resource_aws_route_test.go

+					resource.TestCheckResourceAttr(resourceName, "origin", ec2.RouteOriginCreateRoute),
+					resource.TestCheckResourceAttr(resourceName, "state", ec2.RouteStateActive),
+					resource.TestCheckResourceAttr(resourceName, "transit_gateway_id", ""),
+					// TODO resource.TestCheckResourceAttr(resourceName, "vpc_endpoint_id", ""),


These TODOs will be removed in #16930.

ewbankkit · 2020-12-08T15:21:42Z

Rebased and resolved merge conflicts.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRoute_\|TestAccAWSRouteDataSource_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRoute_\|TestAccAWSRouteDataSource_ -timeout 120m
=== RUN   TestAccAWSRouteDataSource_basic
=== PAUSE TestAccAWSRouteDataSource_basic
=== RUN   TestAccAWSRouteDataSource_TransitGatewayID
=== PAUSE TestAccAWSRouteDataSource_TransitGatewayID
=== RUN   TestAccAWSRouteDataSource_LocalGatewayID
=== PAUSE TestAccAWSRouteDataSource_LocalGatewayID
=== RUN   TestAccAWSRoute_basic
=== PAUSE TestAccAWSRoute_basic
=== RUN   TestAccAWSRoute_disappears
=== PAUSE TestAccAWSRoute_disappears
=== RUN   TestAccAWSRoute_disappears_RouteTable
=== PAUSE TestAccAWSRoute_disappears_RouteTable
=== RUN   TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_InternetGateway
=== PAUSE TestAccAWSRoute_IPv6_To_InternetGateway
=== RUN   TestAccAWSRoute_IPv6_To_Instance
=== PAUSE TestAccAWSRoute_IPv6_To_Instance
=== RUN   TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv6_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv6_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv6_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_VpnGateway
=== PAUSE TestAccAWSRoute_IPv4_To_VpnGateway
=== RUN   TestAccAWSRoute_IPv4_To_Instance
=== PAUSE TestAccAWSRoute_IPv4_To_Instance
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== RUN   TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== PAUSE TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
=== RUN   TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== PAUSE TestAccAWSRoute_IPv4_To_VpcPeeringConnection
=== RUN   TestAccAWSRoute_IPv4_To_NatGateway
=== PAUSE TestAccAWSRoute_IPv4_To_NatGateway
=== RUN   TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== PAUSE TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
=== RUN   TestAccAWSRoute_IPv4_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv4_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv6_To_TransitGateway
=== PAUSE TestAccAWSRoute_IPv6_To_TransitGateway
=== RUN   TestAccAWSRoute_IPv4_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv4_To_LocalGateway
=== RUN   TestAccAWSRoute_IPv6_To_LocalGateway
=== PAUSE TestAccAWSRoute_IPv6_To_LocalGateway
=== RUN   TestAccAWSRoute_ConditionalCidrBlock
=== PAUSE TestAccAWSRoute_ConditionalCidrBlock
=== RUN   TestAccAWSRoute_IPv4_To_VpcEndpoint
=== PAUSE TestAccAWSRoute_IPv4_To_VpcEndpoint
=== CONT  TestAccAWSRouteDataSource_basic
=== CONT  TestAccAWSRoute_IPv4_To_Instance
=== CONT  TestAccAWSRoute_IPv4_To_VpcEndpoint
--- PASS: TestAccAWSRouteDataSource_basic (88.06s)
--- PASS: TestAccAWSRoute_IPv4_To_Instance (318.99s)
=== CONT  TestAccAWSRoute_ConditionalCidrBlock
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (52.75s)
=== CONT  TestAccAWSRoute_IPv6_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (1.25s)
=== CONT  TestAccAWSRoute_IPv4_To_LocalGateway
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.10s)
=== CONT  TestAccAWSRoute_IPv6_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (379.05s)
=== CONT  TestAccAWSRoute_IPv4_To_TransitGateway
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (378.61s)
=== CONT  TestAccAWSRoute_DoesNotCrashWithVpcEndpoint
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (44.65s)
=== CONT  TestAccAWSRoute_IPv4_To_NatGateway
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (337.02s)
=== CONT  TestAccAWSRoute_IPv4_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (25.10s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Attached
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (187.33s)
=== CONT  TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached
=== CONT  TestAccAWSRoute_IPv6_To_InternetGateway
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (58.30s)
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (35.38s)
=== CONT  TestAccAWSRoute_IPv4_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (44.77s)
=== CONT  TestAccAWSRoute_IPv6_To_VpnGateway
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (39.45s)
=== CONT  TestAccAWSRoute_IPv6_To_VpcPeeringConnection
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (351.27s)
=== CONT  TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (26.61s)
=== CONT  TestAccAWSRoute_IPv6_To_Instance
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (59.40s)
=== CONT  TestAccAWSRoute_disappears
--- PASS: TestAccAWSRoute_disappears (32.53s)
=== CONT  TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (38.29s)
=== CONT  TestAccAWSRoute_disappears_RouteTable
--- PASS: TestAccAWSRoute_disappears_RouteTable (33.20s)
=== CONT  TestAccAWSRouteDataSource_LocalGatewayID
    data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.17s)
=== CONT  TestAccAWSRoute_basic
--- PASS: TestAccAWSRoute_basic (34.96s)
=== CONT  TestAccAWSRouteDataSource_TransitGatewayID
--- PASS: TestAccAWSRoute_IPv6_To_Instance (297.99s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (388.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1768.977s

…s/enhancements.

YakDriver

Looks great! There are some nits in here but since they may be addressed by subsequent PRs, I'll wait to the end for them.

Acceptance tests in GovCloud:

--- SKIP: TestAccAWSRoute_IPv4_To_VpcEndpoint (1.63s)
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (1.97s)
--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (2.03s)
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (41.68s)
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (44.68s)
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (48.18s)
--- PASS: TestAccAWSRoute_disappears (48.63s)
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (50.92s)
--- PASS: TestAccAWSRoute_disappears_RouteTable (51.46s)
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (54.34s)
--- PASS: TestAccAWSRoute_basic (56.41s)
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (56.67s)
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (56.78s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (68.24s)
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (73.70s)
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (75.32s)
--- PASS: TestAccAWSRoute_IPv4_To_Instance (100.11s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (144.38s)
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (215.23s)
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (324.64s)
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (325.39s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (392.72s)

Commercial:

--- SKIP: TestAccAWSRoute_IPv6_To_LocalGateway (1.44s)
--- SKIP: TestAccAWSRoute_IPv4_To_LocalGateway (7.06s)
--- PASS: TestAccAWSRoute_IPv6_To_VpcPeeringConnection (38.01s)
--- PASS: TestAccAWSRoute_IPv4_To_VpcPeeringConnection (40.67s)
--- PASS: TestAccAWSRoute_disappears_RouteTable (45.26s)
--- PASS: TestAccAWSRoute_disappears (45.96s)
--- PASS: TestAccAWSRoute_IPv6_To_InternetGateway (48.53s)
--- PASS: TestAccAWSRoute_DoesNotCrashWithVpcEndpoint (52.28s)
--- PASS: TestAccAWSRoute_IPv6_To_EgressOnlyInternetGateway (54.70s)
--- PASS: TestAccAWSRoute_basic (55.27s)
--- PASS: TestAccAWSRoute_IPv4_To_VpnGateway (55.97s)
--- PASS: TestAccAWSRoute_IPv6_To_VpnGateway (57.22s)
--- PASS: TestAccAWSRoute_ConditionalCidrBlock (65.81s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Unattached (67.75s)
--- PASS: TestAccAWSRoute_IPv6_To_NetworkInterface_Unattached (70.55s)
--- PASS: TestAccAWSRoute_IPv6_To_Instance (118.85s)
--- PASS: TestAccAWSRoute_IPv4_To_NetworkInterface_Attached (174.57s)
--- PASS: TestAccAWSRoute_IPv4_To_NatGateway (218.63s)
--- PASS: TestAccAWSRoute_IPv4_To_VpcEndpoint (284.16s)
--- PASS: TestAccAWSRoute_IPv4_To_Instance (362.13s)
--- PASS: TestAccAWSRoute_IPv6_To_TransitGateway (378.75s)
--- PASS: TestAccAWSRoute_IPv4_To_TransitGateway (379.40s)

ghost · 2021-03-26T01:00:15Z

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2021-04-24T17:10:59Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit requested a review from a team July 1, 2020 15:45

ghost added size/XXL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 1, 2020

ewbankkit commented Jul 1, 2020

View reviewed changes

aws/resource_aws_route_table_test.go Outdated Show resolved Hide resolved

This was referenced Jul 5, 2020

[WIP] r/aws_route: Correctly handle update of route target #14050

Closed

New resource: aws_ec2_managed_prefix_list #14068

Merged

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:26

ewbankkit force-pushed the t-additional-aws_route-tests branch from 966eae9 to 36faae1 Compare August 9, 2020 22:06

ewbankkit mentioned this pull request Aug 9, 2020

r/aws_route: Correctly handle update of route target #14531

Closed

ewbankkit force-pushed the t-additional-aws_route-tests branch from 36faae1 to d38fcfd Compare August 22, 2020 22:30

ewbankkit mentioned this pull request Aug 23, 2020

r/aws_route: Correctly handle update of route target #14796

Closed

This comment has been minimized.

Sign in to view

ewbankkit force-pushed the t-additional-aws_route-tests branch from d38fcfd to 14f2e58 Compare September 4, 2020 18:03

ewbankkit mentioned this pull request Sep 6, 2020

[WIP] r/aws_route: Correctly handle update of route target #15049

Closed

ewbankkit force-pushed the t-additional-aws_route-tests branch from 2163d22 to e96b079 Compare September 22, 2020 21:05

ewbankkit force-pushed the t-additional-aws_route-tests branch from e96b079 to d312b66 Compare October 5, 2020 17:22

ewbankkit force-pushed the t-additional-aws_route-tests branch from d312b66 to d4c008a Compare October 18, 2020 22:20

ewbankkit mentioned this pull request Oct 19, 2020

[WIP] r/aws_route: Correctly handle update of route target #15723

Closed

ewbankkit force-pushed the t-additional-aws_route-tests branch from d4c008a to f5d7076 Compare November 15, 2020 23:25

ewbankkit requested a review from a team as a code owner November 15, 2020 23:25

ewbankkit mentioned this pull request Nov 16, 2020

r/aws_route: Correctly handle update of route target #16219

Closed

ewbankkit force-pushed the t-additional-aws_route-tests branch from f5d7076 to 77cdf84 Compare December 8, 2020 14:11

ewbankkit commented Dec 8, 2020

View reviewed changes

ewbankkit mentioned this pull request Dec 8, 2020

r/aws_route_table: Refactor acceptance tests in preparation for future fixes/enhancements #14013

Merged

ewbankkit mentioned this pull request Dec 14, 2020

AWS Wavelength support #14518

Closed

7 tasks

ewbankkit force-pushed the t-additional-aws_route-tests branch from ca2dba6 to 0dfe3ac Compare December 29, 2020 23:26

ewbankkit mentioned this pull request Dec 30, 2020

r/aws_route: Correctly handle update of route target #16930

Merged

ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jan 4, 2021

This was referenced Jan 4, 2021

r/aws_route: AWS Wavelength support #16961

Merged

d/aws_route: AWS Wavelength support #16963

Merged

ewbankkit force-pushed the t-additional-aws_route-tests branch from 0dfe3ac to 84087ab Compare January 5, 2021 22:48

Base automatically changed from master to main January 23, 2021 00:58

ewbankkit force-pushed the t-additional-aws_route-tests branch from 84087ab to 2c127fb Compare February 15, 2021 22:34

ewbankkit force-pushed the t-additional-aws_route-tests branch from 2c127fb to 618f34a Compare March 20, 2021 22:43

YakDriver self-assigned this Mar 25, 2021

ewbankkit added 2 commits March 25, 2021 11:34

r/aws_route: Refactor acceptance tests in preparation for future fixe…

4c34456

…s/enhancements.

Fixes after rebase.

4406339

YakDriver force-pushed the t-additional-aws_route-tests branch from 618f34a to 4406339 Compare March 25, 2021 15:34

YakDriver approved these changes Mar 25, 2021

View reviewed changes

YakDriver added this to the v3.34.0 milestone Mar 25, 2021

YakDriver merged commit 48fefb7 into hashicorp:main Mar 25, 2021

ewbankkit deleted the t-additional-aws_route-tests branch March 25, 2021 17:24

ghost locked as resolved and limited conversation to collaborators Apr 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_route: Refactor acceptance tests in preparation for future fixes/enhancements #14014

r/aws_route: Refactor acceptance tests in preparation for future fixes/enhancements #14014

ewbankkit commented Jul 1, 2020 •

edited by YakDriver

Loading

ewbankkit commented Jul 4, 2020

ewbankkit commented Aug 9, 2020

ewbankkit commented Aug 22, 2020

This comment has been minimized.

ewbankkit commented Sep 4, 2020 •

edited

Loading

ewbankkit commented Sep 4, 2020

DrFaust92 commented Nov 14, 2020

ewbankkit commented Nov 15, 2020

ewbankkit Dec 8, 2020 •

edited

Loading

ewbankkit commented Dec 8, 2020 •

edited

Loading

YakDriver left a comment

ghost commented Mar 26, 2021

ghost commented Apr 24, 2021

r/aws_route: Refactor acceptance tests in preparation for future fixes/enhancements #14014

r/aws_route: Refactor acceptance tests in preparation for future fixes/enhancements #14014

Conversation

ewbankkit commented Jul 1, 2020 • edited by YakDriver Loading

Community Note

ewbankkit commented Jul 4, 2020

ewbankkit commented Aug 9, 2020

ewbankkit commented Aug 22, 2020

This comment has been minimized.

ewbankkit commented Sep 4, 2020 • edited Loading

ewbankkit commented Sep 4, 2020

DrFaust92 commented Nov 14, 2020

ewbankkit commented Nov 15, 2020

ewbankkit Dec 8, 2020 • edited Loading

Choose a reason for hiding this comment

ewbankkit commented Dec 8, 2020 • edited Loading

YakDriver left a comment

Choose a reason for hiding this comment

ghost commented Mar 26, 2021

ghost commented Apr 24, 2021

ewbankkit commented Jul 1, 2020 •

edited by YakDriver

Loading

ewbankkit commented Sep 4, 2020 •

edited

Loading

ewbankkit Dec 8, 2020 •

edited

Loading

ewbankkit commented Dec 8, 2020 •

edited

Loading