d/aws_route: Refactor acceptance tests in preparation for future fixes/enhancements #14018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/L
ewbankkit
force-pushed
the
t-additional-aws_route-data-source-tests
branch
from
2c28dca
to
47ca6e7
Compare
|
Rebased to fix merge conflicts. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_ -timeout 120m
=== RUN TestAccAWSRouteDataSource_basic
=== PAUSE TestAccAWSRouteDataSource_basic
=== RUN TestAccAWSRouteDataSource_TransitGatewayID
=== PAUSE TestAccAWSRouteDataSource_TransitGatewayID
=== RUN TestAccAWSRouteDataSource_IPv6DestinationCidr
=== PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr
=== CONT TestAccAWSRouteDataSource_basic
=== CONT TestAccAWSRouteDataSource_IPv6DestinationCidr
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (31.03s)
=== CONT TestAccAWSRouteDataSource_TransitGatewayID
--- PASS: TestAccAWSRouteDataSource_basic (137.72s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (336.63s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 367.721s |
ewbankkit
force-pushed
the
t-additional-aws_route-data-source-tests
branch
from
47ca6e7
to
ed22f5c
Compare
|
Rebased and re-ran acceptance tests: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_ -timeout 120m
=== RUN TestAccAWSRouteDataSource_basic
=== PAUSE TestAccAWSRouteDataSource_basic
=== RUN TestAccAWSRouteDataSource_TransitGatewayID
=== PAUSE TestAccAWSRouteDataSource_TransitGatewayID
=== RUN TestAccAWSRouteDataSource_IPv6DestinationCidr
=== PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr
=== CONT TestAccAWSRouteDataSource_TransitGatewayID
=== CONT TestAccAWSRouteDataSource_IPv6DestinationCidr
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (27.48s)
=== CONT TestAccAWSRouteDataSource_basic
--- PASS: TestAccAWSRouteDataSource_basic (68.23s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (352.38s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 352.426s |
This comment has been minimized.
This comment has been minimized.
ewbankkit
force-pushed
the
t-additional-aws_route-data-source-tests
branch
from
ed22f5c
to
b7589c3
Compare
|
Rebased and fixed merge conflicts. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_ -timeout 120m
=== RUN TestAccAWSRouteDataSource_basic
=== PAUSE TestAccAWSRouteDataSource_basic
=== RUN TestAccAWSRouteDataSource_TransitGatewayID
=== PAUSE TestAccAWSRouteDataSource_TransitGatewayID
=== RUN TestAccAWSRouteDataSource_IPv6DestinationCidr
=== PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr
=== RUN TestAccAWSRouteDataSource_LocalGatewayID
=== PAUSE TestAccAWSRouteDataSource_LocalGatewayID
=== CONT TestAccAWSRouteDataSource_basic
=== CONT TestAccAWSRouteDataSource_LocalGatewayID
data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts Outpost found
=== CONT TestAccAWSRouteDataSource_IPv6DestinationCidr
=== CONT TestAccAWSRouteDataSource_LocalGatewayID
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (2.23s)
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (27.32s)
=== CONT TestAccAWSRouteDataSource_TransitGatewayID
--- PASS: TestAccAWSRouteDataSource_basic (119.98s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (276.96s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 306.551s |
ewbankkit
force-pushed
the
t-additional-aws_route-data-source-tests
branch
from
b7589c3
to
490bab8
Compare
|
Rebased and fixed merge conflicts. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_ -timeout 120m
=== RUN TestAccAWSRouteDataSource_basic
=== PAUSE TestAccAWSRouteDataSource_basic
=== RUN TestAccAWSRouteDataSource_TransitGatewayID
=== PAUSE TestAccAWSRouteDataSource_TransitGatewayID
=== RUN TestAccAWSRouteDataSource_IPv6DestinationCidr
=== PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr
=== RUN TestAccAWSRouteDataSource_LocalGatewayID
=== PAUSE TestAccAWSRouteDataSource_LocalGatewayID
=== CONT TestAccAWSRouteDataSource_basic
=== CONT TestAccAWSRouteDataSource_LocalGatewayID
data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.76s)
=== CONT TestAccAWSRouteDataSource_IPv6DestinationCidr
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (27.25s)
=== CONT TestAccAWSRouteDataSource_TransitGatewayID
--- PASS: TestAccAWSRouteDataSource_basic (101.36s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (372.35s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 401.404s |
ewbankkit
force-pushed
the
t-additional-aws_route-data-source-tests
branch
from
46b6540
to
3df991a
Compare
ewbankkit
force-pushed
the
t-additional-aws_route-data-source-tests
branch
from
3df991a
to
98733a3
Compare
|
Rebased and fixed merge conflicts. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSRouteDataSource_ -timeout 120m
=== RUN TestAccAWSRouteDataSource_basic
=== PAUSE TestAccAWSRouteDataSource_basic
=== RUN TestAccAWSRouteDataSource_TransitGatewayID
=== PAUSE TestAccAWSRouteDataSource_TransitGatewayID
=== RUN TestAccAWSRouteDataSource_IPv6DestinationCidr
=== PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr
=== RUN TestAccAWSRouteDataSource_LocalGatewayID
=== PAUSE TestAccAWSRouteDataSource_LocalGatewayID
=== CONT TestAccAWSRouteDataSource_basic
=== CONT TestAccAWSRouteDataSource_LocalGatewayID
data_source_aws_outposts_outposts_test.go:66: skipping since no Outposts found
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.87s)
=== CONT TestAccAWSRouteDataSource_IPv6DestinationCidr
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (27.59s)
=== CONT TestAccAWSRouteDataSource_TransitGatewayID
--- PASS: TestAccAWSRouteDataSource_basic (69.69s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (373.00s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 402.510s |
ewbankkit
added
the
technical-debt
ewbankkit
force-pushed
the
t-additional-aws_route-data-source-tests
branch
from
98733a3
to
c648c9d
Compare
ewbankkit
force-pushed
the
t-additional-aws_route-data-source-tests
branch
from
c648c9d
to
fbedf96
Compare
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteDataSource_basic -timeout 120m === RUN TestAccAWSRouteDataSource_basic === PAUSE TestAccAWSRouteDataSource_basic === CONT TestAccAWSRouteDataSource_basic --- PASS: TestAccAWSRouteDataSource_basic (141.12s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 141.166s d/aws_route_table: Rework 'TestAccAWSRouteDataSource_TransitGatewayID'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_TransitGatewayID' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteDataSource_TransitGatewayID -timeout 120m === RUN TestAccAWSRouteDataSource_TransitGatewayID === PAUSE TestAccAWSRouteDataSource_TransitGatewayID === CONT TestAccAWSRouteDataSource_TransitGatewayID --- PASS: TestAccAWSRouteDataSource_TransitGatewayID (296.93s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 296.976s d/aws_route_table: Add 'TestAccAWSRouteDataSource_IPv6DestinationCidr'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRouteDataSource_IPv6DestinationCidr' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRouteDataSource_IPv6DestinationCidr -timeout 120m === RUN TestAccAWSRouteDataSource_IPv6DestinationCidr === PAUSE TestAccAWSRouteDataSource_IPv6DestinationCidr === CONT TestAccAWSRouteDataSource_IPv6DestinationCidr --- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (43.81s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 43.869s Fix Acceptance Test Linting / terrafmt error.
YakDriver
force-pushed
the
t-additional-aws_route-data-source-tests
branch
from
fbedf96
to
d590aea
Compare
YakDriver
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
Looks great 🎉
GovCloud:
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.84s)
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (27.36s)
--- PASS: TestAccAWSRouteDataSource_basic (131.31s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (352.35s)
us-west-2:
--- SKIP: TestAccAWSRouteDataSource_LocalGatewayID (1.35s)
--- PASS: TestAccAWSRouteDataSource_IPv6DestinationCidr (24.13s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (296.29s)
--- PASS: TestAccAWSRouteDataSource_basic (312.04s)
|
This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Refactoring
aws_routedata source acceptance tests in preparation for future fixes/enhancements.Output from acceptance testing: