Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sqs_queue_policy - add disappears test #14047

Merged
merged 2 commits into from
Jul 8, 2020
Merged

r/sqs_queue_policy - add disappears test #14047

merged 2 commits into from
Jul 8, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13826
Release note for CHANGELOG:

None

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSQSQueuePolicy_'
--- PASS: TestAccAWSSQSQueuePolicy_basic (64.61s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears_queue (31.62s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears (41.55s)

@DrFaust92 DrFaust92 requested a review from a team July 4, 2020 22:03
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/sqs Issues and PRs that pertain to the sqs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 4, 2020
@bflad bflad added this to the v2.70.0 milestone Jul 8, 2020
@bflad bflad self-assigned this Jul 8, 2020
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jul 8, 2020
bflad
bflad approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing:

--- PASS: TestAccAWSSQSQueuePolicy_disappears_queue (7.43s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears (8.49s)
--- PASS: TestAccAWSSQSQueuePolicy_basic (12.91s)

@bflad bflad merged commit 10875d1 into hashicorp:master Jul 8, 2020
@DrFaust92 DrFaust92 deleted the r/sqs_policy_disappears branch July 8, 2020 21:17
@ghost
Copy link

ghost commented Jul 10, 2020

This has been released in version 2.70.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
service/sqs Issues and PRs that pertain to the sqs service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.70.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @bflad