tests/service/ec2: Add aws_ec2_client_vpn_network_association sweeper #14116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #14115 Output from sweeper: ```console $ go test ./aws -v -timeout=10h -sweep-allow-failures -sweep=us-west-2 -sweep-run=aws_ec2_client_vpn_endpoint 2020/07/09 09:18:19 [WARN] Sweeper has dependency (aws_workspaces_workspace), but that sweeper was not found 2020/07/09 09:18:19 [DEBUG] Running Sweepers for region (us-west-2): 2020/07/09 09:18:19 [DEBUG] Running Sweeper (aws_fsx_windows_file_system) in region (us-west-2) 2020/07/09 09:18:19 [INFO] Building AWS auth structure 2020/07/09 09:18:19 [INFO] Setting AWS metadata API timeout to 100ms 2020/07/09 09:18:19 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id 2020/07/09 09:18:19 [INFO] AWS Auth provider used: "SharedCredentialsProvider" 2020/07/09 09:18:19 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2020/07/09 09:18:19 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2020/07/09 09:18:21 [WARN] Sweeper (aws_workspaces_directory) has dependency (aws_workspaces_workspace), but that sweeper was not found 2020/07/09 09:18:21 [DEBUG] Running Sweeper (aws_workspaces_directory) in region (us-west-2) 2020/07/09 09:18:21 [DEBUG] Running Sweeper (aws_ec2_client_vpn_network_association) in region (us-west-2) 2020/07/09 09:18:23 [INFO] Deleting EC2 Client VPN Target Network: cvpn-assoc-061760dfeca46f8de 2020/07/09 09:18:24 [DEBUG] Waiting for Client VPN endpoint to disassociate with target network: cvpn-assoc-061760dfeca46f8de 2020/07/09 09:18:24 [DEBUG] Waiting for state to become: [disassociated] 2020/07/09 09:23:22 [INFO] Deleting EC2 Client VPN Target Network: cvpn-assoc-0c84136d3bb041419 2020/07/09 09:23:22 [DEBUG] Waiting for Client VPN endpoint to disassociate with target network: cvpn-assoc-0c84136d3bb041419 2020/07/09 09:23:22 [DEBUG] Waiting for state to become: [disassociated] 2020/07/09 09:27:48 [DEBUG] Sweeper (aws_ec2_client_vpn_endpoint) has dependency (aws_directory_service_directory), running.. 2020/07/09 09:27:48 [DEBUG] Sweeper (aws_directory_service_directory) has dependency (aws_fsx_windows_file_system), running.. 2020/07/09 09:27:48 [DEBUG] Sweeper (aws_fsx_windows_file_system) already ran in region (us-west-2) 2020/07/09 09:27:48 [DEBUG] Sweeper (aws_directory_service_directory) has dependency (aws_workspaces_directory), running.. 2020/07/09 09:27:48 [WARN] Sweeper (aws_workspaces_directory) has dependency (aws_workspaces_workspace), but that sweeper was not found 2020/07/09 09:27:48 [DEBUG] Sweeper (aws_workspaces_directory) already ran in region (us-west-2) 2020/07/09 09:27:48 [DEBUG] Running Sweeper (aws_directory_service_directory) in region (us-west-2) 2020/07/09 09:27:49 [DEBUG] Sweeper (aws_ec2_client_vpn_endpoint) has dependency (aws_ec2_client_vpn_network_association), running.. 2020/07/09 09:27:49 [DEBUG] Sweeper (aws_ec2_client_vpn_network_association) already ran in region (us-west-2) 2020/07/09 09:27:49 [DEBUG] Running Sweeper (aws_ec2_client_vpn_endpoint) in region (us-west-2) 2020/07/09 09:27:49 [INFO] Deleting EC2 Client VPN Endpoint: cvpn-endpoint-032094b1edaf8d7da 2020/07/09 09:27:50 [DEBUG] Waiting for state to become: [] 2020/07/09 09:27:50 [INFO] Deleting EC2 Client VPN Endpoint: cvpn-endpoint-0a777253d4dd52eba 2020/07/09 09:27:51 [DEBUG] Waiting for state to become: [] 2020/07/09 09:27:52 [DEBUG] Sweeper (aws_directory_service_directory) has dependency (aws_fsx_windows_file_system), running.. 2020/07/09 09:27:52 [DEBUG] Sweeper (aws_fsx_windows_file_system) already ran in region (us-west-2) 2020/07/09 09:27:52 [DEBUG] Sweeper (aws_directory_service_directory) has dependency (aws_workspaces_directory), running.. 2020/07/09 09:27:52 [WARN] Sweeper (aws_workspaces_directory) has dependency (aws_workspaces_workspace), but that sweeper was not found 2020/07/09 09:27:52 [DEBUG] Sweeper (aws_workspaces_directory) already ran in region (us-west-2) 2020/07/09 09:27:52 [DEBUG] Sweeper (aws_directory_service_directory) already ran in region (us-west-2) 2020/07/09 09:27:52 Sweeper Tests ran successfully: - aws_ec2_client_vpn_endpoint - aws_fsx_windows_file_system - aws_workspaces_directory - aws_ec2_client_vpn_network_association - aws_directory_service_directory ok github.com/terraform-providers/terraform-provider-aws/aws 575.715s ```
ghost
added
size/M
anGie44
approved these changes
Jul 28, 2020
Comment on lines
+58
to
+62
| r := resourceAwsEc2ClientVpnNetworkAssociation() | ||
| d := r.Data(nil) | ||
| d.SetId(associationID) | ||
| d.Set("client_vpn_endpoint_id", endpointID) | ||
| err := r.Delete(d, client) |
There was a problem hiding this comment.
interesting use of resource !
| }) | ||
|
|
||
| if testSweepSkipSweepError(err) { | ||
| log.Printf("[WARN] Skipping Client VPN Endpoint sweep for %s: %s", region, err) |
There was a problem hiding this comment.
small change here to reflect the resource being sweeped: Network Association or Target Network instead of Endpoint
|
Replaced by #14146 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #14115
Release note for CHANGELOG:
Output from sweeper: