Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects name of Workspaces Workspace sweeper #14165

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Corrects name of Workspaces Workspace sweeper #14165

merged 1 commit into from
Jul 15, 2020

Conversation

gdavison
Copy link
Contributor

The Workspaces Workspace sweeper had the wrong name, so it was not being called. This was causing some sweepers and tests to fail.

Extracted from #14146

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14146

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make sweep SWEEPARGS='-sweep-run=aws_workspaces_workspace'

Sweeper Tests ran successfully:
	- aws_workspaces_workspace

@gdavison gdavison requested a review from a team July 13, 2020 18:47
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 13, 2020
@gdavison gdavison mentioned this pull request Jul 13, 2020
Merged
bflad
bflad approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@gdavison gdavison merged commit 9194062 into master Jul 15, 2020
@gdavison gdavison deleted the t-fix-workspaces-workspace-sweeper-dependency branch July 15, 2020 19:16
@gdavison gdavison added this to the v3.0.0 milestone Jul 15, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
service/workspaces Issues and PRs that pertain to the workspaces service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @bflad