-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: aws_imagebuilder_infrastracture_configuration #14347
New resource: aws_imagebuilder_infrastracture_configuration #14347
Conversation
cf173b8
to
f7e8ae0
Compare
f7e8ae0
to
ade62ae
Compare
Squashed and rebased, run tests again:
|
Notification of Recent and Upcoming Changes to ContributionsThank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization. If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items. For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported. Terraform 0.12 SyntaxReference: #8950 Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations ( Action Required: Terraform Plugin SDK Version 2Reference: #14551 The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information. Action Required: Removal of website/aws.erb FileReference: #14712 Any changes to the Upcoming Change of Git Branch NamingReference: #14292 Development environments will need their upstream Git branch updated from Upcoming Change of GitHub OrganizationReference: #14715 This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including |
Reference: #11084 Reference: #13485 Reference: #14347 Changes: ``` * **New Data Source:** `aws_imagebuilder_infrastructure_configuration` * **New Resource:** `aws_imagebuilder_infrastructure_configuration` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (47.25s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (56.76s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (34.25s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (75.52s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (63.65s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (63.67s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (82.86s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (76.12s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (62.22s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (76.90s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (69.00s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (76.21s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (74.09s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (62.45s) --- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (26.62s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (51.08s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (66.77s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (44.79s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (76.02s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (71.91s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (73.11s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (88.93s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (84.10s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (71.55s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (81.06s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (69.43s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (83.06s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (87.65s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (71.96s) --- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (33.51s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/13 14:24:06 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/13 14:24:06 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-west-2) 2020/11/13 14:24:09 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration 2020/11/13 14:24:09 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/13 14:24:09 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-east-1) 2020/11/13 14:24:11 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 7.692s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/13 14:24:10 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/13 14:24:10 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-gov-west-1) 2020/11/13 14:24:12 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 4.976s ```
* Add aws_imagebuilder_infrastructureconfiguration * Fix issue with infraconfig logging * [#11084] Fix the imagebuilder resource, add test and docs * New Resource: aws_imagebuilder_infrastructure_configuration Reference: #11084 Reference: #13485 Reference: #14347 Changes: ``` * **New Data Source:** `aws_imagebuilder_infrastructure_configuration` * **New Resource:** `aws_imagebuilder_infrastructure_configuration` ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (47.25s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (56.76s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (34.25s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (75.52s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (63.65s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (63.67s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (82.86s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (76.12s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (62.22s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (76.90s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (69.00s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (76.21s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (74.09s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (62.45s) --- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (26.62s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_basic (51.08s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Description (66.77s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_disappears (44.79s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceProfileName (76.02s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_InstanceTypes (71.91s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_KeyPair (73.11s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3BucketName (88.93s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Logging_S3Logs_S3KeyPrefix (84.10s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_ResourceTags (71.55s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SecurityGroupIds (81.06s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SnsTopicArn (69.43s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_SubnetId (83.06s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_Tags (87.65s) --- PASS: TestAccAwsImageBuilderInfrastructureConfiguration_TerminateInstanceOnFailure (71.96s) --- PASS: TestAccAwsImageBuilderInfrastructureConfigurationDataSource_Arn (33.51s) ``` Output from sweeper in AWS Commercial: ``` 2020/11/13 14:24:06 [DEBUG] Running Sweepers for region (us-west-2): 2020/11/13 14:24:06 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-west-2) 2020/11/13 14:24:09 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration 2020/11/13 14:24:09 [DEBUG] Running Sweepers for region (us-east-1): 2020/11/13 14:24:09 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-east-1) 2020/11/13 14:24:11 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 7.692s ``` Output from sweeper in AWS GovCloud (US): ``` 2020/11/13 14:24:10 [DEBUG] Running Sweepers for region (us-gov-west-1): 2020/11/13 14:24:10 [DEBUG] Running Sweeper (aws_imagebuilder_infrastructure_configuration) in region (us-gov-west-1) 2020/11/13 14:24:12 Sweeper Tests ran successfully: - aws_imagebuilder_infrastructure_configuration ok github.com/terraform-providers/terraform-provider-aws/aws 4.976s ``` Co-authored-by: Dogers <[email protected]> Co-authored-by: Jakub Kania <[email protected]>
GitHub may not be able to automatically pick up on this, but these commits were included with #16186, which was just merged. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
New resource as part of image builder work, based on work by @Dogers
Part of #11084
Release note for CHANGELOG:
Output from acceptance testing: