Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/ecr_repository- make registry_id optional to allow to filter by account + add missing attributes #14368

Merged
merged 4 commits into from
Jul 31, 2020
Merged

d/ecr_repository- make registry_id optional to allow to filter by account + add missing attributes #14368

merged 4 commits into from
Jul 31, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14327

Release note for CHANGELOG:

data_source_aws_ecr_repository - make `registry_id` optional to allow to filter by account
data_source_aws_ecr_repository - add `image_scanning_configuration`, `image_tag_mutability` attributes

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcrDataSource_'
--- PASS: TestAccAWSEcrDataSource_ecrImage (42.83s)
--- PASS: TestAccAWSEcrDataSource_ecrRepository (53.71s)
--- PASS: TestAccAWSEcrDataSource_nonExistent (7.93s)

@DrFaust92
make registry_id optional to allow to filter by account
26cd670 
add `image_tag_mutability` and `image_scanning_configuration` attributes
@DrFaust92 DrFaust92 requested a review from a team July 28, 2020 16:42
@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ecr Issues and PRs that pertain to the ecr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 28, 2020
@DrFaust92 DrFaust92 mentioned this pull request Jul 28, 2020
Closed
bflad
bflad suggested changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little things and this should be good to go. 👍

aws/data_source_aws_ecr_repository.go Show resolved Hide resolved
aws/data_source_aws_ecr_repository_test.go Outdated Show resolved Hide resolved
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 31, 2020
@bflad bflad self-assigned this Jul 31, 2020
@DrFaust92 DrFaust92 requested a review from bflad July 31, 2020 14:09
@DrFaust92
Copy link
Collaborator Author

@bflad, addressed the changes. i also noticed the test names were not specific to the data source so i change them as well and ran test again.

bflad
bflad approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEcrRepositoryDataSource_nonExistent (1.90s)
--- PASS: TestAccAWSEcrRepositoryDataSource_basic (8.77s)

@bflad bflad added this to the v3.1.0 milestone Jul 31, 2020
@bflad bflad merged commit 8f53c48 into hashicorp:master Jul 31, 2020
bflad added a commit that referenced this pull request Jul 31, 2020
@bflad
Update CHANGELOG for #14368
db21712
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the d/ecr_respository_registry branch August 27, 2020 18:00
@ghost
Copy link

ghost commented Aug 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

The aws_ecr_repository data source doesn't work across accounts
2 participants
@DrFaust92 @bflad