Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data source test configs (up to s3 bucket) #14483

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8950

Release note for CHANGELOG:

NONE

The output from acceptance testing:

(Note that initially TestAccDataSourceAwsRouteTable_basic and TestAccDataSourceAWSS3BucketObject_allParams did not pass on TC. A minor fix was needed for one. They both passed on local re-run.)

--- PASS: TestAvailabilityZonesSort (0.40s)
--- PASS: TestAccDataSourceAWSS3BucketObject_basic (12.02s)
--- PASS: TestAccDataSourceAWSS3BucketObject_kmsEncrypted (12.35s)
--- PASS: TestAccDataSourceAWSS3BucketObject_readableBody (12.51s)
--- PASS: TestAccDataSourceAWSS3BucketObject_basicViaAccessPoint (13.99s)
--- PASS: TestAccDataSourceAWSS3BucketObject_ObjectLockLegalHoldOff (14.23s)
--- PASS: TestAccDataSourceS3Bucket_website (15.18s)
--- PASS: TestAccDataSourceS3Bucket_basic (15.18s)
--- PASS: TestAccDataSourceAWSS3BucketObject_ObjectLockLegalHoldOn (15.75s)
--- PASS: TestAccDataSourceAwsRouteTables_basic (20.84s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_fetchOwner (20.87s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_startAfter (20.88s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_override (21.41s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_maxKeys (22.03s)
--- PASS: TestAccDataSourceAWSS3BucketObject_MultipleSlashes (22.19s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_Statement_Principal_Identifiers_MultiplePrincipals (22.28s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_Statement_Principal_Identifiers_StringAndSlice (22.50s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_noStatementOverride (22.56s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_noStatementMerge (22.60s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_basicViaAccessPoint (22.62s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_basic (23.00s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_all (23.72s)
--- PASS: TestAccDataSourceAwsKmsKey_basic (23.82s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_encoded (24.10s)
--- PASS: TestAccDataSourceAWSS3BucketObject_LeadingSlash (24.77s)
--- PASS: TestAccDataSourceAWSS3BucketObjects_prefixes (24.99s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_basic (25.54s)
--- PASS: TestAccAWSAvailabilityZones_basic (25.93s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (25.96s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_basic (26.16s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_sourceConflicting (26.16s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (26.55s)
--- PASS: TestAccAWSAvailabilityZones_Filter (26.63s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (26.74s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (26.80s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeNames (27.41s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_duplicateSid (27.52s)
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (27.65s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (27.72s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeZoneIds (28.36s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_Version_20081017 (35.76s)
--- PASS: TestAccDataSourceAWSS3BucketObject_allParams (35.90s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_source (40.86s)
--- PASS: TestAccDataSourceAwsRouteTable_basic (40.86s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_basic (42.64s)
--- PASS: TestAccDataSourceAwsRouteTable_main (44.33s)
--- PASS: TestAccAWSEbsSnapshotDataSource_Filter (53.07s)
--- PASS: TestAccAWSEbsSnapshotDataSource_basic (53.25s)
--- PASS: TestAccDataSourceRoute53DelegationSet_basic (60.47s)
--- PASS: TestAccDataSourceAwsEbsVolumes_basic (60.65s)
--- PASS: TestAccAWSAutoscalingGroups_basic (71.21s)
--- PASS: TestAccDataSourceAwsRoute53Zone_id (73.08s)
--- PASS: TestAccDataSourceAwsRoute53Zone_name (83.81s)
--- PASS: TestAccAWSRouteDataSource_basic (103.02s)
--- PASS: TestAccAWSEbsSnapshotDataSource_MostRecent (107.47s)
--- PASS: TestAccDataSourceAwsRoute53Zone_vpc (108.23s)
--- PASS: TestAccDataSourceAwsRoute53Zone_tags (110.09s)
--- PASS: TestAccDataSourceAwsRoute53Zone_serviceDiscovery (111.48s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRules_ResolverEndpointId (212.42s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedWithMe (228.46s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_SharedByMe (232.14s)
--- PASS: TestAccDataSourceAwsRoute53ResolverRule_ResolverEndpointIdWithTags (234.37s)
--- PASS: TestAccAWSRouteDataSource_TransitGatewayID (336.83s)
--- PASS: TestAccAWSDataElasticsearchDomain_basic (1043.20s)
--- PASS: TestAccAWSDataElasticsearchDomain_advanced (1086.66s)

@YakDriver YakDriver requested a review from a team August 5, 2020 20:59
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/route53 Issues and PRs that pertain to the route53 service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 5, 2020
@YakDriver YakDriver merged commit 43d37bf into master Aug 6, 2020
@YakDriver YakDriver deleted the td-config-format-ds7 branch August 6, 2020 14:09
@YakDriver YakDriver added this to the v3.1.0 milestone Aug 6, 2020
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 27, 2020
@ghost
Copy link

ghost commented Sep 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/iam Issues and PRs that pertain to the iam service. service/kms Issues and PRs that pertain to the kms service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/route53 Issues and PRs that pertain to the route53 service. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants