Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Update resource testing to 0.12 syntax (S3/Sa Resources) #14695

Merged
merged 1 commit into from
Aug 18, 2020
Merged

tests/provider: Update resource testing to 0.12 syntax (S3/Sa Resources) #14695

merged 1 commit into from
Aug 18, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 17, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Related: #8950, #14417

Release note for CHANGELOG:

NONE

Output from acceptance testing: Handled via daily acceptance testing

Spot check (commercial partition):

--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (95.80s)
--- PASS: TestAccAWSS3BucketObject_tags (95.80s)

@YakDriver YakDriver requested a review from a team August 17, 2020 19:10
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. service/s3 Issues and PRs that pertain to the s3 service. service/s3control Issues and PRs that pertain to the s3control service. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 17, 2020
@gdavison gdavison self-assigned this Aug 17, 2020
gdavison
gdavison approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

A few nits about formatting

aws/resource_aws_s3_bucket_notification_test.go
}
POLICY

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra whitespace can be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave this for a future pass? The overwhelming majority of HEREDOC's have an empty line after so I've been doing it that way to be consistent - consistently wrong I guess.

aws/resource_aws_s3_bucket_notification_test.go
}
POLICY

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, too. And all of the other cases :)

aws/resource_aws_s3_bucket_notification_test.go Show resolved Hide resolved
aws/resource_aws_s3_bucket_object_test.go Show resolved Hide resolved
aws/resource_aws_s3_bucket_policy_test.go Show resolved Hide resolved
aws/resource_aws_s3_bucket_test.go Outdated Show resolved Hide resolved
@YakDriver YakDriver merged commit e526652 into master Aug 18, 2020
@YakDriver YakDriver deleted the t-012-syntax-and-fmt-s branch August 18, 2020 00:31
@YakDriver YakDriver added this to the v3.3.0 milestone Aug 18, 2020
@ghost
Copy link

ghost commented Aug 20, 2020

This has been released in version 3.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 27, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @gdavison