Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Update resource testing to 0.12 syntax (Si-Sq Resources) #14700

Merged
merged 2 commits into from
Aug 18, 2020
Merged

tests/provider: Update resource testing to 0.12 syntax (Si-Sq Resources) #14700

merged 2 commits into from
Aug 18, 2020

Conversation

YakDriver
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Related: #8950, #14417

Release note for CHANGELOG:

NONE

Output from acceptance testing: Handled via daily acceptance testing

@YakDriver YakDriver requested a review from a team August 17, 2020 20:45
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 17, 2020
@gdavison gdavison self-assigned this Aug 17, 2020
gdavison
gdavison approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

A few styling nits, plus extra space after HEREDOCs

aws/resource_aws_spot_instance_request_test.go Outdated Show resolved Hide resolved
@ghost ghost added the service/rds Issues and PRs that pertain to the rds service. label Aug 18, 2020
@ghost ghost added service/batch Issues and PRs that pertain to the batch service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudwatchlogs service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/configservice Issues and PRs that pertain to the configservice service. service/datasync Issues and PRs that pertain to the datasync service. service/dlm Issues and PRs that pertain to the dlm service. labels Aug 18, 2020
@YakDriver YakDriver force-pushed the t-012-syntax-and-fmt-si branch 2 times, most recently from 55b092c to 93ad666 Compare August 18, 2020 01:32
@YakDriver YakDriver force-pushed the t-012-syntax-and-fmt-si branch 2 times, most recently from 0fc031e to 49d1661 Compare August 18, 2020 01:35
@YakDriver YakDriver merged commit 02c9c77 into master Aug 18, 2020
@YakDriver YakDriver deleted the t-012-syntax-and-fmt-si branch August 18, 2020 01:54
@YakDriver YakDriver added this to the v3.3.0 milestone Aug 18, 2020
@ghost
Copy link

ghost commented Aug 20, 2020

This has been released in version 3.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 27, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/batch Issues and PRs that pertain to the batch service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/configservice Issues and PRs that pertain to the configservice service. service/datasync Issues and PRs that pertain to the datasync service. service/dlm Issues and PRs that pertain to the dlm service. service/ec2 Issues and PRs that pertain to the ec2 service. service/rds Issues and PRs that pertain to the rds service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @gdavison