tech-debt/waf_xss_match_set: update test configuration params, disappears methods, and enumerated vals

[anGie44]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14957
Relates #14601

Release note for CHANGELOG:

tech-debt/waf_xss_match_set: update configuration params, disappears methods and enumerated vals
tech-debt/waf_regional_xss_match_set: update configuration params, disappears methods and enumerated vals

Output from acceptance testing:

--- PASS: TestAccAWSWafRegionalXssMatchSet_changeTuples (42.65s)
--- PASS: TestAccAWSWafXssMatchSet_changeTuples (59.45s)

--- PASS: TestAccAWSWafRegionalXssMatchSet_basic (27.22s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_disappears (27.42s)
--- PASS: TestAccAWSWafXssMatchSet_noTuples (34.67s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_noTuples (36.26s)
--- PASS: TestAccAWSWafXssMatchSet_disappears (37.10s)
--- PASS: TestAccAWSWafXssMatchSet_basic (45.68s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_changeNameForceNew (47.83s)
--- PASS: TestAccAWSWafXssMatchSet_changeNameForceNew (54.72s)

[bflad]

Looks good, just one note for consideration 🚀

Output from acceptance testing:

--- PASS: TestAccAWSWafRegionalXssMatchSet_noTuples (22.19s)
--- PASS: TestAccAWSWafXssMatchSet_disappears (26.10s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_basic (26.89s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_disappears (28.46s)
--- PASS: TestAccAWSWafXssMatchSet_noTuples (28.76s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_changeTuples (39.56s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_changeNameForceNew (43.08s)
--- PASS: TestAccAWSWafXssMatchSet_basic (44.87s)
--- PASS: TestAccAWSWafXssMatchSet_changeTuples (48.84s)
--- PASS: TestAccAWSWafXssMatchSet_changeNameForceNew (67.30s)

[bflad]

😍

[bflad]

Just noting here that sometimes the nil checking is desirable to prevent unexpected difference output (null versus "" differences between configuration block updates that show as adding and removing the "same" block in Terraform plan output). I'm not sure if that is the case here, but usually the nil checking is more deterministic in behavior and what we will likely be doing in the future with code generation.

[anGie44]

Ooo that's a good point, i'll move this back as it was 👍

[anGie44]

Reverted to nil check method in 7ed2b1d

Output of acceptance tests:

--- PASS: TestAccAWSWafXssMatchSet_noTuples (13.95s)
--- PASS: TestAccAWSWafXssMatchSet_disappears (16.74s)
--- PASS: TestAccAWSWafXssMatchSet_basic (18.13s)
--- PASS: TestAccAWSWafXssMatchSet_changeTuples (27.63s)
--- PASS: TestAccAWSWafXssMatchSet_changeNameForceNew (30.29s)

--- PASS: TestAccAWSWafRegionalXssMatchSet_noTuples (16.33s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_basic (23.37s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_disappears (23.95s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_changeTuples (35.79s)
--- PASS: TestAccAWSWafRegionalXssMatchSet_changeNameForceNew (38.39s)

[ghost]

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!