Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data sources to acceptance test syntax workflow #15110

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Sep 11, 2020

Adds data sources to acceptance test syntax workflow, which was missed in #14837

Relates #14837
Relates #14417

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSNeptuneOrderableDbInstanceDataSource\|TestAccAWSRdsOrderableDbInstanceDataSource\|TestAccDataSourceAwsVpcPeeringConnections\|TestAccAWSDBProxyDefaultTargetGroup\|TestAccAWSVpc\|TestAccDataSourceAwsCurReportDefinition\|TestAccAWSDocdbOrderableDbInstanceDataSource\|TestAccDataSourceAwsLexSlotType"

--- SKIP: TestAccDataSourceAwsCurReportDefinition_basic (2.09s)
--- SKIP: TestAccDataSourceAwsCurReportDefinition_additional (1.56s)
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (36.64s)
--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_preferred (36.27s)
--- PASS: TestAccAWSDocdbOrderableDbInstanceDataSource_basic (37.49s)
--- PASS: TestAccDataSourceAwsLexSlotType_basic (38.06s)
--- PASS: TestAccDataSourceAwsLexSlotType_withVersion (38.72s)
--- PASS: TestAccAWSNeptuneOrderableDbInstanceDataSource_basic (40.32s)
--- PASS: TestAccAWSNeptuneOrderableDbInstanceDataSource_preferred (40.64s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_basic (40.89s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClass (42.13s)
--- PASS: TestAccDataSourceAwsVpcPeeringConnections_basic (42.15s)
--- PASS: TestAccAWSVpcEndpointRouteTableAssociation_basic (32.30s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredVersion (176.08s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIops (176.23s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_preferredClassAndVersion (177.74s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageEncryption (184.51s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsPerformanceInsights (185.36s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsEnhancedMonitoring (188.91s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsIAMDatabaseAuthentication (204.49s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsStorageAutoscaling (210.56s)
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (28.61s)
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (56.27s)
--- PASS: TestAccAWSRdsOrderableDbInstanceDataSource_supportsKerberosAuthentication (250.91s)
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (54.42s)
--- PASS: TestAccAWSVpcEndpoint_disappears (26.63s)
--- PASS: TestAccAWSVpcEndpointServiceAllowedPrincipal_basic (243.79s)
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (81.19s)
--- PASS: TestAccAWSVpcEndpointService_basic (247.90s)
--- FAIL: TestAccAWSVpcPeeringConnectionOptions_sameRegionDifferentAccount (0.98s)
--- PASS: TestAccAWSVpcPeeringConnectionOptions_basic (20.26s)
--- PASS: TestAccAWSVpcEndpointConnectionNotification_basic (267.91s)
--- PASS: TestAccAWSVpc_basic (17.95s)
--- PASS: TestAccAWSVpc_disappears (15.17s)
--- PASS: TestAccAWSVpcEndpointService_AllowedPrincipals (256.85s)
--- PASS: TestAccAWSVpcPeeringConnectionOptions_differentRegionSameAccount (59.01s)
--- PASS: TestAccAWSVpc_ignoreTags (55.25s)
--- PASS: TestAccAWSVpcEndpoint_tags (83.20s)
--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (70.33s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (26.57s)
--- PASS: TestAccAWSVpc_Tenancy (71.09s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (27.71s)
--- PASS: TestAccAWSVpc_update (47.42s)
--- PASS: TestAccAWSVpc_tags (71.97s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (24.54s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (21.48s)
--- PASS: TestAccAWSVpcEndpointService_disappears (261.64s)
--- PASS: TestAccAWSVpcEndpointService_tags (296.50s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_basic (312.54s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (291.32s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (293.76s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (393.45s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_ConnectionBorrowTimeout (703.57s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_Basic (745.01s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_InitQuery (725.49s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_disappears (729.56s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_SessionPinningFilters (735.53s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_MaxIdleConnectionsPercent (749.74s)
--- PASS: TestAccAWSVpcEndpointSubnetAssociation_multiple (626.01s)
--- PASS: TestAccAWSDBProxyDefaultTargetGroup_MaxConnectionsPercent (888.07s)

TestAccAWSVpcPeeringConnectionOptions_sameRegionDifferentAccount is an existing failure

@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/costandusagereportservice service/docdb Issues and PRs that pertain to the docdb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/lexmodels Issues and PRs that pertain to the lexmodels service. service/neptune Issues and PRs that pertain to the neptune service. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 11, 2020
@gdavison gdavison marked this pull request as ready for review September 11, 2020 01:13
@gdavison gdavison requested a review from a team September 11, 2020 01:13
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@gdavison gdavison merged commit 03e8467 into master Sep 11, 2020
@gdavison gdavison deleted the acctest-tflint-datasources-workflow branch September 11, 2020 17:06
@ghost
Copy link

ghost commented Oct 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. service/docdb Issues and PRs that pertain to the docdb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/lexmodels Issues and PRs that pertain to the lexmodels service. service/neptune Issues and PRs that pertain to the neptune service. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants