Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: VPC for endpoint_type to transfer_server #15373

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

PChambino
Copy link
Contributor

Document VPC value for endpoint_type attribute in transfer_server resource after being added by #12599.

I put VPC_ENDPOINT in parentheses because it is no longer possible to create this type of Transfer servers from AWS dashboard. It is only accessible via the API, so I believe it will be eventually deprecated, but I didn't find any information to support that.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12599

Release note for CHANGELOG:

NONE

Document `VPC` value for endpoint_type attribute in transfer_server resource.

I put `VPC_ENDPOINT` in parentheses because it is no longer possible to create this type of Transfer servers in AWS dashboard. It is only accessible via the API, so I believe it will be eventually deprecated, but I didn't find any information to support that.
@PChambino PChambino requested a review from a team September 27, 2020 16:56
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/transfer Issues and PRs that pertain to the transfer service. labels Sep 27, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 27, 2020
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Sep 27, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update, @PChambino 🚀

@bflad bflad added this to the v3.9.0 milestone Sep 29, 2020
@bflad bflad merged commit 706bc5f into hashicorp:master Sep 29, 2020
@PChambino PChambino deleted the patch-1 branch October 2, 2020 13:14
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/transfer Issues and PRs that pertain to the transfer service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants