Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Support (helper/schema.Resource).DeleteContext in testAccCheckResourceDisappears #15448

Merged
merged 1 commit into from
Oct 2, 2020
Merged

tests/provider: Support (helper/schema.Resource).DeleteContext in testAccCheckResourceDisappears #15448

merged 1 commit into from
Oct 2, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 2, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #15090
Reference: #15446

Release note for CHANGELOG:

NONE

Output from acceptance testing (example existing case, PRs like #15446 will catch new code path):

--- PASS: TestAccAwsBackupPlan_disappears (16.36s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. labels Oct 2, 2020
@bflad bflad requested a review from a team October 2, 2020 13:22
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Oct 2, 2020
@bflad bflad mentioned this pull request Oct 2, 2020
Merged
anGie44
anGie44 approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I think i ran into this the other day! LGTM 🚀

@bflad bflad added this to the v3.9.0 milestone Oct 2, 2020
@bflad bflad merged commit 9cd3645 into master Oct 2, 2020
@bflad bflad deleted the td-testAccCheckResourceDisappears-diag-support branch October 2, 2020 15:00
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @anGie44