Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the LB Target Group Attribute forgot deregistration_delay parameter at initial setting #17310

Conversation

notemusic110
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

#17309

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@notemusic110 notemusic110 requested a review from a team as a code owner January 27, 2021 09:09
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Jan 27, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 27, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @notemusic110 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@notemusic110
Copy link
Author

TEST Result as below:

TF_LOG=DEBUG make testacc TESTARGS='-run=TestAccAWSLBTargetGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLBTargetGroup_basic -timeout 120m
go: downloading github.com/hashicorp/go-getter v1.5.1
go: downloading google.golang.org/api v0.34.0
go: downloading cloud.google.com/go v0.65.0
=== RUN   TestAccAWSLBTargetGroup_basic
=== PAUSE TestAccAWSLBTargetGroup_basic
=== RUN   TestAccAWSLBTargetGroup_basicUdp
=== PAUSE TestAccAWSLBTargetGroup_basicUdp
=== CONT  TestAccAWSLBTargetGroup_basic
=== CONT  TestAccAWSLBTargetGroup_basicUdp
2021/01/28 14:34:50 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2021/01/28 14:34:50 [DEBUG] Trying to get account information via sts:GetCallerIdentity
...
--- PASS: TestAccAWSLBTargetGroup_basicUdp (62.30s)
--- PASS: TestAccAWSLBTargetGroup_basic (62.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	62.591s

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 16, 2021
@github-actions github-actions bot added this to the v3.62.0 milestone Oct 8, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants