Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuring-enhanced-monitoring to Pending state list #1744

Merged
merged 1 commit into from
Sep 27, 2017
Merged

Add configuring-enhanced-monitoring to Pending state list #1744

merged 1 commit into from
Sep 27, 2017

Conversation

pradeepbhadani
Copy link
Contributor

@pradeepbhadani pradeepbhadani commented Sep 25, 2017 •
edited by radeksimko
Loading

Fixes #1743

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Sep 27, 2017
radeksimko
radeksimko approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically we should treat some other states as pending there, e.g. maintenance, rebooting, renaming, resetting-master-credentials, starting and upgrading, but that's probably out of scope for this PR.

Thanks 👍

@radeksimko radeksimko merged commit 3fbb0db into hashicorp:master Sep 27, 2017
@pradeepbhadani
Copy link
Contributor Author

pradeepbhadani commented Oct 1, 2017 •
edited
Loading

@radeksimko Thanks, I will create another PR including above states

@pradeepbhadani pradeepbhadani mentioned this pull request Oct 1, 2017
Closed
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provider/aws: aws_rds_cluster_instance unexpected state when configuring enhanced monitoring
2 participants
@pradeepbhadani @radeksimko