[WIP] Remove Artificial limit on service registries

[chriskuchin]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000
ECS documentation accepts a list of service_registry objects with no specification in the docs that it is limited to a single entry. This may have been a bug when the support was first added based on comments on that PR. Seems better to allow AWS to return an error if there is a problem rather than artificially limiting it in the provider.

Docs on Service Definition
Docs on Create Service API

Closes: #9573

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcsService_withServiceRegistries'
run=TestAccAWSEcsService_withServiceRegistries'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsService_withServiceRegistries -timeout 120m
=== RUN   TestAccAWSEcsService_withServiceRegistries
=== PAUSE TestAccAWSEcsService_withServiceRegistries
=== RUN   TestAccAWSEcsService_withServiceRegistries_container
=== PAUSE TestAccAWSEcsService_withServiceRegistries_container
=== CONT  TestAccAWSEcsService_withServiceRegistries
=== CONT  TestAccAWSEcsService_withServiceRegistries_container
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (167.89s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (178.14s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       178.195s...

[github-actions]

Welcome @chriskuchin 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[chriskuchin]

Further testing shows that despite AWS having no documented limit and explicitly referring to it in plural the aws sdk seems to be throwing an error somewhere but I could not locate it to even understand why the error was there.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!