Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/ec2: Add ErrorCheck (Data Source Part 1) #18144

Merged
merged 1 commit into from
Mar 18, 2021
Merged

tests/ec2: Add ErrorCheck (Data Source Part 1) #18144

merged 1 commit into from
Mar 18, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Mar 18, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18175

Output from acceptance testing: NA (Handled through daily test run)

@YakDriver YakDriver requested a review from a team as a code owner March 18, 2021 01:51
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. service/kms Issues and PRs that pertain to the kms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 18, 2021
@YakDriver YakDriver changed the title tests/ec2: Add ErrorCheck tests/ec2: Add ErrorCheck (Data Source Part 1) Mar 18, 2021
@YakDriver YakDriver mentioned this pull request Mar 18, 2021
Closed
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Mar 18, 2021
breathingdust
breathingdust approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@breathingdust breathingdust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsAmiIds_\|TestAccDataSourceAwsAvailabilityZone_\|TestAccAWSAvailabilityZones_\|TestAccAWSCustomerGatewayDataSource\|TestAccDataSourceAwsEBSDefaultKmsKey_\|TestAccDataSourceAwsEbsSnapshotIds_\|TestAccAWSEbsSnapshotDataSource_\|TestAccAWSEbsVolumeDataSource_\|TestAccDataSourceAwsEbsVolumes_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAmiIds_\|TestAccDataSourceAwsAvailabilityZone_\|TestAccAWSAvailabilityZones_\|TestAccAWSCustomerGatewayDataSource\|TestAccDataSourceAwsEBSDefaultKmsKey_\|TestAccDataSourceAwsEbsSnapshotIds_\|TestAccAWSEbsSnapshotDataSource_\|TestAccAWSEbsVolumeDataSource_\|TestAccDataSourceAwsEbsVolumes_ -timeout 180m
=== RUN   TestAccDataSourceAwsAmiIds_basic
=== PAUSE TestAccDataSourceAwsAmiIds_basic
=== RUN   TestAccDataSourceAwsAmiIds_sorted
=== PAUSE TestAccDataSourceAwsAmiIds_sorted
=== RUN   TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== PAUSE TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== RUN   TestAccDataSourceAwsAvailabilityZone_Filter
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Filter
=== RUN   TestAccDataSourceAwsAvailabilityZone_LocalZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_LocalZone
=== RUN   TestAccDataSourceAwsAvailabilityZone_Name
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Name
=== RUN   TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== RUN   TestAccDataSourceAwsAvailabilityZone_ZoneId
=== PAUSE TestAccDataSourceAwsAvailabilityZone_ZoneId
=== RUN   TestAccAWSAvailabilityZones_basic
=== PAUSE TestAccAWSAvailabilityZones_basic
=== RUN   TestAccAWSAvailabilityZones_AllAvailabilityZones
=== PAUSE TestAccAWSAvailabilityZones_AllAvailabilityZones
=== RUN   TestAccAWSAvailabilityZones_Filter
=== PAUSE TestAccAWSAvailabilityZones_Filter
=== RUN   TestAccAWSAvailabilityZones_ExcludeNames
=== PAUSE TestAccAWSAvailabilityZones_ExcludeNames
=== RUN   TestAccAWSAvailabilityZones_ExcludeZoneIds
=== PAUSE TestAccAWSAvailabilityZones_ExcludeZoneIds
=== RUN   TestAccAWSAvailabilityZones_stateFilter
=== PAUSE TestAccAWSAvailabilityZones_stateFilter
=== RUN   TestAccAWSCustomerGatewayDataSource_Filter
=== PAUSE TestAccAWSCustomerGatewayDataSource_Filter
=== RUN   TestAccAWSCustomerGatewayDataSource_ID
=== PAUSE TestAccAWSCustomerGatewayDataSource_ID
=== RUN   TestAccDataSourceAwsEBSDefaultKmsKey_basic
=== PAUSE TestAccDataSourceAwsEBSDefaultKmsKey_basic
=== RUN   TestAccDataSourceAwsEbsSnapshotIds_basic
=== PAUSE TestAccDataSourceAwsEbsSnapshotIds_basic
=== RUN   TestAccDataSourceAwsEbsSnapshotIds_sorted
=== PAUSE TestAccDataSourceAwsEbsSnapshotIds_sorted
=== RUN   TestAccDataSourceAwsEbsSnapshotIds_empty
=== PAUSE TestAccDataSourceAwsEbsSnapshotIds_empty
=== RUN   TestAccAWSEbsSnapshotDataSource_basic
=== PAUSE TestAccAWSEbsSnapshotDataSource_basic
=== RUN   TestAccAWSEbsSnapshotDataSource_Filter
=== PAUSE TestAccAWSEbsSnapshotDataSource_Filter
=== RUN   TestAccAWSEbsSnapshotDataSource_MostRecent
=== PAUSE TestAccAWSEbsSnapshotDataSource_MostRecent
=== RUN   TestAccAWSEbsVolumeDataSource_basic
=== PAUSE TestAccAWSEbsVolumeDataSource_basic
=== RUN   TestAccAWSEbsVolumeDataSource_multipleFilters
=== PAUSE TestAccAWSEbsVolumeDataSource_multipleFilters
=== RUN   TestAccDataSourceAwsEbsVolumes_basic
=== PAUSE TestAccDataSourceAwsEbsVolumes_basic
=== CONT  TestAccDataSourceAwsAmiIds_basic
=== CONT  TestAccAWSCustomerGatewayDataSource_Filter
=== CONT  TestAccAWSEbsSnapshotDataSource_basic
=== CONT  TestAccAWSEbsVolumeDataSource_multipleFilters
=== CONT  TestAccDataSourceAwsAmiIds_sorted
=== CONT  TestAccAWSEbsSnapshotDataSource_Filter
=== CONT  TestAccDataSourceAwsEbsVolumes_basic
=== CONT  TestAccDataSourceAwsEBSDefaultKmsKey_basic
=== CONT  TestAccDataSourceAwsEbsSnapshotIds_basic
=== CONT  TestAccDataSourceAwsEbsSnapshotIds_empty
=== CONT  TestAccAWSCustomerGatewayDataSource_ID
=== CONT  TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== CONT  TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccDataSourceAwsEbsSnapshotIds_sorted
=== CONT  TestAccAWSAvailabilityZones_stateFilter
=== CONT  TestAccAWSAvailabilityZones_ExcludeZoneIds
=== CONT  TestAccAWSAvailabilityZones_ExcludeNames
=== CONT  TestAccDataSourceAwsAvailabilityZone_Filter
=== CONT  TestAccAWSAvailabilityZones_Filter
=== CONT  TestAccDataSourceAwsAvailabilityZone_LocalZone
=== CONT  TestAccDataSourceAwsAvailabilityZone_WavelengthZone
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_empty (16.35s)
--- PASS: TestAccDataSourceAwsEBSDefaultKmsKey_basic (17.27s)
=== CONT  TestAccAWSEbsVolumeDataSource_basic
--- PASS: TestAccAWSAvailabilityZones_ExcludeNames (19.04s)
=== CONT  TestAccAWSAvailabilityZones_AllAvailabilityZones
--- PASS: TestAccAWSAvailabilityZones_ExcludeZoneIds (19.05s)
=== CONT  TestAccAWSEbsSnapshotDataSource_MostRecent
--- PASS: TestAccAWSAvailabilityZones_Filter (19.36s)
=== CONT  TestAccAWSAvailabilityZones_basic
--- PASS: TestAccDataSourceAwsAvailabilityZone_LocalZone (19.41s)
=== CONT  TestAccDataSourceAwsAvailabilityZone_Name
--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (19.43s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (19.76s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (19.76s)
--- PASS: TestAccDataSourceAwsAmiIds_basic (19.77s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (19.78s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (28.64s)
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (29.14s)
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (29.14s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_WavelengthZone (13.53s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (12.39s)
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (12.76s)
--- PASS: TestAccAWSAvailabilityZones_basic (12.44s)
--- PASS: TestAccDataSourceAwsAmiIds_sorted (32.87s)
--- PASS: TestAccAWSEbsVolumeDataSource_basic (25.27s)
--- PASS: TestAccAWSEbsSnapshotDataSource_Filter (45.63s)
--- PASS: TestAccAWSEbsSnapshotDataSource_basic (46.03s)
--- PASS: TestAccDataSourceAwsEbsVolumes_basic (48.80s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_basic (77.43s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_sorted (86.27s)
--- PASS: TestAccAWSEbsSnapshotDataSource_MostRecent (103.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	124.891s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsAmiIds_\|TestAccDataSourceAwsAvailabilityZone_\|TestAccAWSAvailabilityZones_\|TestAccAWSCustomerGatewayDataSource\|TestAccDataSourceAwsEBSDefaultKmsKey_\|TestAccDataSourceAwsEbsSnapshotIds_\|TestAccAWSEbsSnapshotDataSource_\|TestAccAWSEbsVolumeDataSource_\|TestAccDataSourceAwsEbsVolumes_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAmiIds_\|TestAccDataSourceAwsAvailabilityZone_\|TestAccAWSAvailabilityZones_\|TestAccAWSCustomerGatewayDataSource\|TestAccDataSourceAwsEBSDefaultKmsKey_\|TestAccDataSourceAwsEbsSnapshotIds_\|TestAccAWSEbsSnapshotDataSource_\|TestAccAWSEbsVolumeDataSource_\|TestAccDataSourceAwsEbsVolumes_ -timeout 180m
=== RUN   TestAccDataSourceAwsAmiIds_basic
=== PAUSE TestAccDataSourceAwsAmiIds_basic
=== RUN   TestAccDataSourceAwsAmiIds_sorted
=== PAUSE TestAccDataSourceAwsAmiIds_sorted
=== RUN   TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== PAUSE TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
=== RUN   TestAccDataSourceAwsAvailabilityZone_Filter
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Filter
=== RUN   TestAccDataSourceAwsAvailabilityZone_LocalZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_LocalZone
=== RUN   TestAccDataSourceAwsAvailabilityZone_Name
=== PAUSE TestAccDataSourceAwsAvailabilityZone_Name
=== RUN   TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== PAUSE TestAccDataSourceAwsAvailabilityZone_WavelengthZone
=== RUN   TestAccDataSourceAwsAvailabilityZone_ZoneId
=== PAUSE TestAccDataSourceAwsAvailabilityZone_ZoneId
=== RUN   TestAccAWSAvailabilityZones_basic
=== PAUSE TestAccAWSAvailabilityZones_basic
=== RUN   TestAccAWSAvailabilityZones_AllAvailabilityZones
=== PAUSE TestAccAWSAvailabilityZones_AllAvailabilityZones
=== RUN   TestAccAWSAvailabilityZones_Filter
=== PAUSE TestAccAWSAvailabilityZones_Filter
=== RUN   TestAccAWSAvailabilityZones_ExcludeNames
=== PAUSE TestAccAWSAvailabilityZones_ExcludeNames
=== RUN   TestAccAWSAvailabilityZones_ExcludeZoneIds
=== PAUSE TestAccAWSAvailabilityZones_ExcludeZoneIds
=== RUN   TestAccAWSAvailabilityZones_stateFilter
=== PAUSE TestAccAWSAvailabilityZones_stateFilter
=== RUN   TestAccAWSCustomerGatewayDataSource_Filter
=== PAUSE TestAccAWSCustomerGatewayDataSource_Filter
=== RUN   TestAccAWSCustomerGatewayDataSource_ID
=== PAUSE TestAccAWSCustomerGatewayDataSource_ID
=== RUN   TestAccDataSourceAwsEBSDefaultKmsKey_basic
=== PAUSE TestAccDataSourceAwsEBSDefaultKmsKey_basic
=== RUN   TestAccDataSourceAwsEbsSnapshotIds_basic
=== PAUSE TestAccDataSourceAwsEbsSnapshotIds_basic
=== RUN   TestAccDataSourceAwsEbsSnapshotIds_sorted
=== PAUSE TestAccDataSourceAwsEbsSnapshotIds_sorted
=== RUN   TestAccDataSourceAwsEbsSnapshotIds_empty
=== PAUSE TestAccDataSourceAwsEbsSnapshotIds_empty
=== RUN   TestAccAWSEbsSnapshotDataSource_basic
=== PAUSE TestAccAWSEbsSnapshotDataSource_basic
=== RUN   TestAccAWSEbsSnapshotDataSource_Filter
=== PAUSE TestAccAWSEbsSnapshotDataSource_Filter
=== RUN   TestAccAWSEbsSnapshotDataSource_MostRecent
=== PAUSE TestAccAWSEbsSnapshotDataSource_MostRecent
=== RUN   TestAccAWSEbsVolumeDataSource_basic
=== PAUSE TestAccAWSEbsVolumeDataSource_basic
=== RUN   TestAccAWSEbsVolumeDataSource_multipleFilters
=== PAUSE TestAccAWSEbsVolumeDataSource_multipleFilters
=== RUN   TestAccDataSourceAwsEbsVolumes_basic
=== PAUSE TestAccDataSourceAwsEbsVolumes_basic
=== CONT  TestAccDataSourceAwsAmiIds_basic
=== CONT  TestAccAWSCustomerGatewayDataSource_Filter
=== CONT  TestAccDataSourceAwsEbsSnapshotIds_empty
=== CONT  TestAccAWSEbsSnapshotDataSource_basic
=== CONT  TestAccAWSAvailabilityZones_ExcludeZoneIds
=== CONT  TestAccDataSourceAwsEbsSnapshotIds_sorted
=== CONT  TestAccDataSourceAwsEbsSnapshotIds_basic
=== CONT  TestAccAWSEbsVolumeDataSource_basic
=== CONT  TestAccAWSAvailabilityZones_basic
=== CONT  TestAccDataSourceAwsEBSDefaultKmsKey_basic
=== CONT  TestAccAWSCustomerGatewayDataSource_ID
=== CONT  TestAccAWSAvailabilityZones_ExcludeNames
=== CONT  TestAccAWSAvailabilityZones_stateFilter
=== CONT  TestAccDataSourceAwsEbsVolumes_basic
=== CONT  TestAccAWSEbsVolumeDataSource_multipleFilters
=== CONT  TestAccDataSourceAwsAvailabilityZone_ZoneId
=== CONT  TestAccAWSEbsSnapshotDataSource_MostRecent
=== CONT  TestAccAWSAvailabilityZones_Filter
=== CONT  TestAccAWSEbsSnapshotDataSource_Filter
=== CONT  TestAccAWSAvailabilityZones_AllAvailabilityZones
--- PASS: TestAccAWSAvailabilityZones_basic (13.45s)
=== CONT  TestAccDataSourceAwsAvailabilityZone_LocalZone
    data_source_aws_availability_zone_test.go:201: skipping since no Local Zones are available
--- SKIP: TestAccDataSourceAwsAvailabilityZone_LocalZone (0.16s)
=== CONT  TestAccDataSourceAwsAvailabilityZone_WavelengthZone
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_empty (13.75s)
=== CONT  TestAccDataSourceAwsAvailabilityZone_Name
=== CONT  TestAccDataSourceAwsAvailabilityZone_WavelengthZone
    resource_aws_ec2_carrier_gateway_test.go:246: skipping since no Wavelength Zones are available
--- SKIP: TestAccDataSourceAwsAvailabilityZone_WavelengthZone (0.20s)
=== CONT  TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones
--- PASS: TestAccDataSourceAwsAmiIds_basic (14.16s)
=== CONT  TestAccDataSourceAwsAmiIds_sorted
--- PASS: TestAccDataSourceAwsAvailabilityZone_ZoneId (14.19s)
=== CONT  TestAccDataSourceAwsAvailabilityZone_Filter
--- PASS: TestAccAWSAvailabilityZones_stateFilter (14.24s)
--- PASS: TestAccDataSourceAwsEBSDefaultKmsKey_basic (14.24s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeNames (14.34s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeZoneIds (14.37s)
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (14.39s)
--- PASS: TestAccAWSAvailabilityZones_Filter (14.81s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Name (8.29s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_AllAvailabilityZones (8.23s)
--- PASS: TestAccDataSourceAwsAvailabilityZone_Filter (8.27s)
--- PASS: TestAccAWSCustomerGatewayDataSource_ID (24.38s)
--- PASS: TestAccAWSCustomerGatewayDataSource_Filter (24.88s)
--- PASS: TestAccAWSEbsVolumeDataSource_basic (24.98s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (25.29s)
--- PASS: TestAccDataSourceAwsAmiIds_sorted (17.46s)
--- PASS: TestAccDataSourceAwsEbsVolumes_basic (38.24s)
--- PASS: TestAccAWSEbsSnapshotDataSource_basic (40.27s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_basic (41.54s)
--- PASS: TestAccAWSEbsSnapshotDataSource_Filter (42.02s)
--- PASS: TestAccDataSourceAwsEbsSnapshotIds_sorted (64.25s)
--- PASS: TestAccAWSEbsSnapshotDataSource_MostRecent (73.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	76.028s

@YakDriver YakDriver added this to the v3.33.0 milestone Mar 18, 2021
@YakDriver YakDriver merged commit edd4649 into main Mar 18, 2021
@YakDriver YakDriver deleted the t-ec2-errorcheck branch March 18, 2021 17:41
@ghost
Copy link

ghost commented Mar 18, 2021

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@breathingdust breathingdust breathingdust approved these changes

Assignees
No one assigned
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. service/kms Issues and PRs that pertain to the kms service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @breathingdust