Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/rds: Add ErrorCheck (Resources Part 1) #18167

Merged
merged 10 commits into from
Mar 18, 2021
Merged

tests/rds: Add ErrorCheck (Resources Part 1) #18167

merged 10 commits into from
Mar 18, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Mar 18, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18175

Output from acceptance testing: NA (Handled through daily test run)

@YakDriver YakDriver requested a review from a team as a code owner March 18, 2021 07:10
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 18, 2021
@YakDriver YakDriver mentioned this pull request Mar 18, 2021
Closed
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Mar 18, 2021
breathingdust
breathingdust approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@breathingdust breathingdust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 🚀

@YakDriver YakDriver added this to the v3.33.0 milestone Mar 18, 2021
@YakDriver YakDriver merged commit e83f52c into main Mar 18, 2021
@YakDriver YakDriver deleted the t-rds-errorcheck branch March 18, 2021 17:52
@ghost
Copy link

ghost commented Mar 18, 2021

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@breathingdust breathingdust breathingdust approved these changes

Assignees
No one assigned
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @breathingdust