Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/service/lexmodelbuildingservice: Implement sweepers #18627

Merged
merged 3 commits into from
Apr 9, 2021
Merged

tests/service/lexmodelbuildingservice: Implement sweepers #18627

merged 3 commits into from
Apr 9, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 7, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15439

Output from sweeper in AWS Commercial:

2021/04/07 14:08:49 [DEBUG] Running Sweepers for region (us-west-2):
2021/04/07 14:08:49 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-west-2)
2021/04/07 14:08:50 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-west-2)
2021/04/07 14:08:51 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-west-2)
2021/04/07 14:11:47 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-west-2)
2021/04/07 14:12:16 Sweeper Tests ran successfully:
        - aws_lex_bot_alias
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
2021/04/07 14:12:16 [DEBUG] Running Sweepers for region (us-east-1):
2021/04/07 14:12:16 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-east-1)
2021/04/07 14:12:17 Sweeper Tests ran successfully:
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
        - aws_lex_bot_alias
ok      github.com/terraform-providers/terraform-provider-aws/aws       211.443s

Output from sweeper in AWS GovCloud (US):

2021/04/07 14:08:53 [DEBUG] Running Sweepers for region (us-gov-west-1):
2021/04/07 14:08:53 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-gov-west-1)
2021/04/07 14:08:55 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-gov-west-1)
2021/04/07 14:08:56 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-gov-west-1)
2021/04/07 14:08:56 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-gov-west-1)
2021/04/07 14:08:57 Sweeper Tests ran successfully:
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
        - aws_lex_bot_alias
ok      github.com/terraform-providers/terraform-provider-aws/aws       5.994s

@bflad
tests/service/lexmodelbuildingservice: Implement sweepers
6834bc3 
Reference: #15439

Output from sweeper in AWS Commercial:

```
2021/04/07 14:08:49 [DEBUG] Running Sweepers for region (us-west-2):
2021/04/07 14:08:49 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-west-2)
2021/04/07 14:08:50 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-west-2)
2021/04/07 14:08:51 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-west-2)
2021/04/07 14:11:47 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-west-2)
2021/04/07 14:12:16 Sweeper Tests ran successfully:
        - aws_lex_bot_alias
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
2021/04/07 14:12:16 [DEBUG] Running Sweepers for region (us-east-1):
2021/04/07 14:12:16 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-east-1)
2021/04/07 14:12:17 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-east-1)
2021/04/07 14:12:17 Sweeper Tests ran successfully:
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
        - aws_lex_bot_alias
ok      github.com/terraform-providers/terraform-provider-aws/aws       211.443s
```

Output from sweeper in AWS GovCloud (US):

```
2021/04/07 14:08:53 [DEBUG] Running Sweepers for region (us-gov-west-1):
2021/04/07 14:08:53 [DEBUG] Running Sweeper (aws_lex_bot_alias) in region (us-gov-west-1)
2021/04/07 14:08:55 [DEBUG] Running Sweeper (aws_lex_bot) in region (us-gov-west-1)
2021/04/07 14:08:56 [DEBUG] Running Sweeper (aws_lex_intent) in region (us-gov-west-1)
2021/04/07 14:08:56 [DEBUG] Running Sweeper (aws_lex_slot_type) in region (us-gov-west-1)
2021/04/07 14:08:57 Sweeper Tests ran successfully:
        - aws_lex_bot
        - aws_lex_intent
        - aws_lex_slot_type
        - aws_lex_bot_alias
ok      github.com/terraform-providers/terraform-provider-aws/aws       5.994s
```
@bflad bflad requested a review from a team as a code owner April 7, 2021 18:13
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/lexmodels Issues and PRs that pertain to the lexmodels service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 7, 2021
YakDriver
YakDriver approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

aws/resource_aws_lex_bot_alias_test.go Outdated Show resolved Hide resolved
aws/resource_aws_lex_bot_test.go Outdated Show resolved Hide resolved
aws/resource_aws_lex_intent_test.go Outdated Show resolved Hide resolved
aws/resource_aws_lex_slot_type_test.go Outdated Show resolved Hide resolved
@YakDriver YakDriver self-assigned this Apr 8, 2021
@bflad bflad merged commit be849f3 into main Apr 9, 2021
@bflad bflad deleted the t-lex-sweeper branch April 9, 2021 14:49
@ghost
Copy link

ghost commented May 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
service/lexmodels Issues and PRs that pertain to the lexmodels service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Sweepers: Add sweepers for Lex resources
2 participants
@bflad @YakDriver