Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add appconfig_configuration_profile #19320

Merged
merged 12 commits into from
Jul 12, 2021
Merged

feat: add appconfig_configuration_profile #19320

merged 12 commits into from
Jul 12, 2021

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented May 11, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #11973 #18032 #19307

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAppConfigConfigurationProfile'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppConfigConfigurationProfile -timeout 180m
=== RUN   TestAccAWSAppConfigConfigurationProfile_basic
=== PAUSE TestAccAWSAppConfigConfigurationProfile_basic
=== RUN   TestAccAWSAppConfigConfigurationProfile_disappears
=== PAUSE TestAccAWSAppConfigConfigurationProfile_disappears
=== RUN   TestAccAWSAppConfigConfigurationProfile_Tags
=== PAUSE TestAccAWSAppConfigConfigurationProfile_Tags
=== CONT  TestAccAWSAppConfigConfigurationProfile_basic
=== CONT  TestAccAWSAppConfigConfigurationProfile_Tags
=== CONT  TestAccAWSAppConfigConfigurationProfile_disappears
--- PASS: TestAccAWSAppConfigConfigurationProfile_disappears (52.39s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_basic (62.24s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Tags (121.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	123.624s

This adds aws_appconfig_configuration_profile to #19307 to support AWS AppConfig Configuration Profile.

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appconfig Issues and PRs that pertain to the appconfig service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 11, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 11, 2021
This was referenced May 12, 2021
Merged
Merged
Merged
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request May 30, 2021
Closed
@anGie44 anGie44 marked this pull request as ready for review July 12, 2021 02:04
@anGie44 anGie44 added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 12, 2021
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jul 12, 2021
@suzuki-shunsuke
Copy link
Contributor Author

CI was failed. I'll check.

FAIL	github.com/terraform-providers/terraform-provider-aws/aws [build failed]
aws/resource_aws_appconfig_configuration_profile_test.go:197:9: undefined: testAccAWSAppConfigApplicationName

@suzuki-shunsuke
Copy link
Contributor Author

Renamed 876c4be

testAccAWSAppConfigApplicationName => testAccAWSAppConfigApplicationConfigDescription

@anGie44
Copy link
Contributor

anGie44 commented Jul 12, 2021

Nice, thanks @suzuki-shunsuke! -- looked related to the method name change I introduced but that should do it 👍 I'm going to give this one a read through, and will merge this one as well. If you don't mind, could you rebase your other draft PRs when you have a moment so we can get those in as well :)

@suzuki-shunsuke
Copy link
Contributor Author

Thanks @anGie44 . I rebased #19324 and #19359

@suzuki-shunsuke
Copy link
Contributor Author

I'm running the acceptance test.

$ make testacc TESTARGS='-run=TestAccAWSAppConfigConfigurationProfile'

@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Jul 12, 2021 •
edited
Loading

The acceptance test was passed.
I updated the description.
#19320 (comment)

Please review.

anGie44
anGie44 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall @suzuki-shunsuke ! I'm just adding in a commit to add default tags support (using the data stored in meta.(*AWSClient).DefaultTagsConfig) and similar updates to #19307 .

Output of acceptance tests (commercial):

--- PASS: TestAccAWSAppConfigConfigurationProfile_disappears (15.89s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_basic (18.92s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_updateName (30.77s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_updateDescription (33.42s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Tags (40.95s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Validators_Multiple (41.04s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Validators_JSON (42.83s)

GovCloud:

--- PASS: TestAccAWSAppConfigConfigurationProfile_disappears (19.19s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_basic (22.68s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_updateName (37.49s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_updateDescription (39.54s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Validators_Multiple (46.53s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Tags (49.32s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Validators_JSON (52.54s)
--- PASS: TestAccAWSAppConfigConfigurationProfile_Validators_Lambda (54.22s)

@anGie44 anGie44 added this to the v3.50.0 milestone Jul 12, 2021
@anGie44 anGie44 merged commit dece377 into hashicorp:main Jul 12, 2021
@suzuki-shunsuke suzuki-shunsuke deleted the feat/appconfig_configuration_profile branch July 12, 2021 20:01
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/appconfig Issues and PRs that pertain to the appconfig service. size/XL Managed by automation to categorize the size of a PR. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.50.0
Development

Successfully merging this pull request may close these issues.
2 participants
@suzuki-shunsuke @anGie44