Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure AWS Provider #19347

Closed
wants to merge 3 commits into from
Closed

Restructure AWS Provider #19347

wants to merge 3 commits into from

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented May 12, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12840

This proposal is easier to view as a tree: https://github.com/hashicorp/terraform-provider-aws/tree/td-repackage

.
+-- service
|   +-- apigateway
|       +-- account.go
|       +-- account_test.go
|       +-- authorizer.go
|       +-- authorizer_test.go
|       +-- find.go
|       +-- status.go
|       +-- wait.go
|   +-- appmesh
|   +-- cloudfront
|   +-- ec2
...

@YakDriver YakDriver requested review from ewbankkit and a team as code owners May 12, 2021 20:13
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. labels May 12, 2021
@YakDriver YakDriver added proposal Proposes new design or functionality. provider Pertains to the provider itself, rather than any interaction with AWS. labels May 12, 2021
@YakDriver
Copy link
Member Author

Go provides an abundance of ways of calling acceptance tests in subdirectories:

What How To
All tests in current directory and all of its subdirectories $ go test ./...
Tests for given specific directories $ go test ./tests/... ./unit-tests/... ./my-packages/...
Tests with import path prefixed with foo/ $ go test foo/...
Tests import path prefixed with foo $ go test foo...
All tests in $GOPATH $ go test ...

See: https://stackoverflow.com/questions/16353016/how-to-go-test-all-tests-in-my-project

@YakDriver YakDriver marked this pull request as draft August 16, 2021 21:21
@YakDriver YakDriver closed this Oct 14, 2021
@YakDriver YakDriver deleted the td-repackage branch October 14, 2021 12:52
@github-actions github-actions bot added this to the v3.64.0 milestone Oct 14, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
proposal Proposes new design or functionality. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant