Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudbuild_project: fix plan validation to take into account computed cache location #21458

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

LumaKernel
Copy link
Contributor

@LumaKernel LumaKernel commented Oct 23, 2021

This is required when the bucket name is not available at plan time (when using bucket_prefix or when the bucket name is computed).

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR cherrypicked #20618.

Closes #10195

Output from acceptance testing:

$ # It's too heavy, sorry
$ # AWS_PROFILE=acc ACCTEST_PARALLELISM=1 make testacc TESTARGS='-run=TestAccCodeBuildProject_cache'
$ AWS_PROFILE=acc TF_ACC=1 go test ./internal/service/codebuild/project_test.go -run=TestAccCodeBuildProject_cache -v -count 1 -parallel 1 -timeout 180m
=== RUN   TestAccCodeBuildProject_cache
=== PAUSE TestAccCodeBuildProject_cache
=== CONT  TestAccCodeBuildProject_cache
--- PASS: TestAccCodeBuildProject_cache (384.18s)
PASS
ok      command-line-arguments  384.235s

…mputed cache location

This is required when the bucket name is not available at plan time (when using bucket_prefix or when the bucket name is computed).
@github-actions github-actions bot added service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. labels Oct 23, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @LumaKernel 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeBuildProject_basic\|TestAccCodeBuildProject_cache' PKG_NAME=internal/service/codebuild
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run=TestAccCodeBuildProject_basic\|TestAccCodeBuildProject_cache -timeout 180m
=== RUN   TestAccCodeBuildProject_basic
=== PAUSE TestAccCodeBuildProject_basic
=== RUN   TestAccCodeBuildProject_cache
=== PAUSE TestAccCodeBuildProject_cache
=== CONT  TestAccCodeBuildProject_basic
=== CONT  TestAccCodeBuildProject_cache
--- PASS: TestAccCodeBuildProject_basic (28.41s)
--- PASS: TestAccCodeBuildProject_cache (193.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	196.519s

@ewbankkit
Copy link
Contributor

@LumaKernel Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3388a82 into hashicorp:main Jan 3, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 3, 2022
@LumaKernel LumaKernel deleted the fix-codecommit-cache branch January 4, 2022 04:39
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/codebuild Issues and PRs that pertain to the codebuild service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provisioning CodeBuild - "Error: cache location is required when cache type is "S3""
4 participants