Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apprunner/service: Make instance_role_arn optional #21842

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Conversation

gdavison
Copy link
Contributor

Copied from #20149 due to Git shenanigans.

Closes #20145

Output from acceptance testing:

$ make testacc TESTS=TestAccAppRunnerService_ PKG= apprunner

--- PASS: TestAccAppRunnerService_disappears (287.45s)
--- PASS: TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars (292.23s)
--- PASS: TestAccAppRunnerService_ImageRepository_basic (302.72s)
--- PASS: TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole (304.72s)
--- PASS: TestAccAppRunnerService_tags (366.45s)
--- PASS: TestAccAppRunnerService_ImageRepository_autoScaling (436.97s)
--- PASS: TestAccAppRunnerService_ImageRepository_instance_Update (483.29s)
--- PASS: TestAccAppRunnerService_ImageRepository_encryption (528.42s)
--- PASS: TestAccAppRunnerService_ImageRepository_healthCheck (570.65s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/apprunner Issues and PRs that pertain to the apprunner service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Nov 19, 2021
@gdavison gdavison merged commit 3c0c5f4 into main Nov 19, 2021
@gdavison gdavison deleted the evantbyrne_main branch November 19, 2021 08:03
@github-actions github-actions bot added this to the v3.67.0 milestone Nov 19, 2021
github-actions bot pushed a commit that referenced this pull request Nov 19, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/apprunner Issues and PRs that pertain to the apprunner service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_apprunner_service instance_configuration.instance_role_arn is required
2 participants