Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forked awspolicyequivalence #22048

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 4, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #21968
Relates jen20/awspolicyequivalence#10 (comment)
Relates hashicorp/awspolicyequivalence#1

Output from acceptance testing:

% make testacc TESTS=TestAccKMSKey PKG=kms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kms/... -v -count 1 -parallel 20 -run='TestAccKMSKey' -timeout 180m
--- PASS: TestAccKMSKey_disappears (21.59s)
--- PASS: TestAccKMSKey_asymmetricKey (24.46s)
--- PASS: TestAccKMSKeyDataSource_basic (25.53s)
--- PASS: TestAccKMSKeyDataSource_multiRegionConfiguration (25.75s)
--- PASS: TestAccKMSKey_basic (27.18s)
--- PASS: TestAccKMSKey_multiRegion (27.30s)
--- PASS: TestAccKMSKeyDataSource_grantToken (31.58s)
--- PASS: TestAccKMSKey_Policy_iamRole (37.96s)
--- PASS: TestAccKMSKey_Policy_basic (42.88s)
--- PASS: TestAccKMSKey_Policy_bypassUpdate (43.10s)
--- PASS: TestAccKMSKey_Policy_iamServiceLinkedRole (48.45s)
--- PASS: TestAccKMSKey_Policy_iamRoleOrder (59.88s)
--- PASS: TestAccKMSKey_tags (68.97s)
--- PASS: TestAccKMSKey_Policy_bypass (150.81s)
--- PASS: TestAccKMSKey_isEnabled (171.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	172.484s

@github-actions github-actions bot added service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/glue Issues and PRs that pertain to the glue service. service/kms Issues and PRs that pertain to the kms service. service/s3 Issues and PRs that pertain to the s3 service. service/s3control Issues and PRs that pertain to the s3control service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.) size/S Managed by automation to categorize the size of a PR. labels Dec 4, 2021
@YakDriver YakDriver added this to the Roadmap milestone Dec 4, 2021
@YakDriver YakDriver merged commit 6356238 into main Dec 6, 2021
@YakDriver YakDriver deleted the f-use-hashi-awspolicyequivalence branch December 6, 2021 13:40
@github-actions github-actions bot modified the milestones: Roadmap, v3.69.0 Dec 6, 2021
@github-actions
Copy link

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/glue Issues and PRs that pertain to the glue service. service/kms Issues and PRs that pertain to the kms service. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant