Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/codebuild_source_credential - finder, sweeper and disappears test #22344

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Dec 25, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13826

Output from acceptance testing:

$ make testacc TESTS=TestAccCodeBuildSourceCredential_ PKG=codebuild
--- PASS: TestAccCodeBuildSourceCredential_disappears (48.68s)
--- PASS: TestAccCodeBuildSourceCredential_basic (94.34s)
--- PASS: TestAccCodeBuildSourceCredential_basicAuth (96.39s)

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/codebuild Issues and PRs that pertain to the codebuild service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 25, 2021
@DrFaust92 DrFaust92 changed the title r/codebuild_source_credential + codebuild_webhook - finder, sweeper and disappears test r/codebuild_source_credential - finder, sweeper and disappears test Dec 25, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review December 25, 2021 14:20
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccCodeBuildSourceCredential_ PKG=codebuild
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildSourceCredential_' -timeout 180m
=== RUN   TestAccCodeBuildSourceCredential_basic
=== PAUSE TestAccCodeBuildSourceCredential_basic
=== RUN   TestAccCodeBuildSourceCredential_basicAuth
=== PAUSE TestAccCodeBuildSourceCredential_basicAuth
=== RUN   TestAccCodeBuildSourceCredential_disappears
=== PAUSE TestAccCodeBuildSourceCredential_disappears
=== CONT  TestAccCodeBuildSourceCredential_basic
=== CONT  TestAccCodeBuildSourceCredential_disappears
=== CONT  TestAccCodeBuildSourceCredential_basicAuth
--- PASS: TestAccCodeBuildSourceCredential_disappears (12.69s)
--- PASS: TestAccCodeBuildSourceCredential_basic (26.76s)
--- PASS: TestAccCodeBuildSourceCredential_basicAuth (26.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	30.646s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d2d62a1 into hashicorp:main Jan 3, 2022
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the r/codebuild_source_creds branch February 12, 2022 12:50
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/codebuild Issues and PRs that pertain to the codebuild service. size/L Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Technical debt: Add missing '_disappears' acceptance test cases
2 participants