Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading and updating Security Group error #22420

Merged
merged 40 commits into from
Jan 18, 2022
Merged

Fix reading and updating Security Group error #22420

merged 40 commits into from
Jan 18, 2022

Conversation

fomichevmi
Copy link
Contributor

@fomichevmi fomichevmi commented Jan 5, 2022 •
edited by justinretzolk
Loading

Fix for updating Security Group error (#21628)

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21628

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@fomichevmi
Fix reading security group after create
ce11e31 
Fix for the bug described in hashicorp#21628

Update default_security_group.go
@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jan 5, 2022
@fomichevmi fomichevmi force-pushed the patch-2 branch 2 times, most recently from 996d0cc to be55c85 Compare January 7, 2022 11:54
@fomichevmi
Fix updating Security Group error
9cbd6c5 
Fix reading security group right after creation (hashicorp#21628)
@fomichevmi fomichevmi changed the title Fix updating Security Group error Fix reading and updating Security Group error Jan 7, 2022
rommy1204
rommy1204 approved these changes Jan 11, 2022
View reviewed changes
Copy link

@rommy1204 rommy1204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 12, 2022
@ewbankkit
r/aws_egress_only_internet_gateway: Tidy up resource Create, Update a…
a488293 
…nd Delete.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2EgressOnlyInternetGateway_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2EgressOnlyInternetGateway_ -timeout 180m
=== RUN   TestAccEC2EgressOnlyInternetGateway_basic
=== PAUSE TestAccEC2EgressOnlyInternetGateway_basic
=== RUN   TestAccEC2EgressOnlyInternetGateway_tags
=== PAUSE TestAccEC2EgressOnlyInternetGateway_tags
=== CONT  TestAccEC2EgressOnlyInternetGateway_basic
=== CONT  TestAccEC2EgressOnlyInternetGateway_tags
--- PASS: TestAccEC2EgressOnlyInternetGateway_basic (28.35s)
--- PASS: TestAccEC2EgressOnlyInternetGateway_tags (68.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	73.982s
@ewbankkit
r/aws_egress_only_internet_gateway: Tidy up resource Read.
94aa071 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2EgressOnlyInternetGateway_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2EgressOnlyInternetGateway_ -timeout 180m
=== RUN   TestAccEC2EgressOnlyInternetGateway_basic
=== PAUSE TestAccEC2EgressOnlyInternetGateway_basic
=== RUN   TestAccEC2EgressOnlyInternetGateway_tags
=== PAUSE TestAccEC2EgressOnlyInternetGateway_tags
=== CONT  TestAccEC2EgressOnlyInternetGateway_basic
=== CONT  TestAccEC2EgressOnlyInternetGateway_tags
--- PASS: TestAccEC2EgressOnlyInternetGateway_basic (30.34s)
--- PASS: TestAccEC2EgressOnlyInternetGateway_tags (74.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	79.152s
@ewbankkit
r/aws_nat_gateway: Tidy up resource Create and Delete.
d6cbb17 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2NatGateway_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2NatGateway_basic -timeout 180m
=== RUN   TestAccEC2NatGateway_basic
=== PAUSE TestAccEC2NatGateway_basic
=== CONT  TestAccEC2NatGateway_basic
--- PASS: TestAccEC2NatGateway_basic (190.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	194.755s
@ewbankkit
r/aws_nat_gateway: Tidy up resource Read.
00deb80 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2NatGateway_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2NatGateway_ -timeout 180m
=== RUN   TestAccEC2NatGateway_basic
=== PAUSE TestAccEC2NatGateway_basic
=== RUN   TestAccEC2NatGateway_disappears
=== PAUSE TestAccEC2NatGateway_disappears
=== RUN   TestAccEC2NatGateway_ConnectivityType_private
=== PAUSE TestAccEC2NatGateway_ConnectivityType_private
=== RUN   TestAccEC2NatGateway_tags
=== PAUSE TestAccEC2NatGateway_tags
=== CONT  TestAccEC2NatGateway_basic
=== CONT  TestAccEC2NatGateway_disappears
=== CONT  TestAccEC2NatGateway_tags
=== CONT  TestAccEC2NatGateway_ConnectivityType_private
--- PASS: TestAccEC2NatGateway_basic (200.59s)
--- PASS: TestAccEC2NatGateway_ConnectivityType_private (209.87s)
--- PASS: TestAccEC2NatGateway_tags (222.37s)
--- PASS: TestAccEC2NatGateway_disappears (233.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	237.892s
@ewbankkit
r/aws_nat_gateway: Rename resource functions.
01ea2cf 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2NatGateway_tags' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2NatGateway_tags -timeout 180m
=== RUN   TestAccEC2NatGateway_tags
=== PAUSE TestAccEC2NatGateway_tags
=== CONT  TestAccEC2NatGateway_tags
--- PASS: TestAccEC2NatGateway_tags (239.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	243.729s
@ewbankkit
r/aws_nat_gateway: Tidy up sweeper.
8c0b4b7 
Acceptance test output:

% make sweep SWEEPARGS=-sweep-run=aws_nat_gateway,aws_egress_only_internet_gateway  SWEEP=us-west-1
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-1 -sweep-run=aws_nat_gateway,aws_egress_only_internet_gateway -timeout 60m
2022/01/13 09:18:56 [DEBUG] Running Sweepers for region (us-west-1):
2022/01/13 09:18:56 [DEBUG] Running Sweeper (aws_nat_gateway) in region (us-west-1)
2022/01/13 09:18:56 [INFO] AWS Auth provider used: "EnvProvider"
2022/01/13 09:18:56 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/01/13 09:18:57 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/01/13 09:18:58 [DEBUG] Completed Sweeper (aws_nat_gateway) in region (us-west-1) in 1.211199642s
2022/01/13 09:18:58 [DEBUG] Running Sweeper (aws_egress_only_internet_gateway) in region (us-west-1)
2022/01/13 09:18:58 [DEBUG] Completed Sweeper (aws_egress_only_internet_gateway) in region (us-west-1) in 352.685481ms
2022/01/13 09:18:58 Completed Sweepers for region (us-west-1) in 1.564160899s
2022/01/13 09:18:58 Sweeper Tests for region (us-west-1) ran successfully:
	- aws_nat_gateway
	- aws_egress_only_internet_gateway
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	5.135s
@ewbankkit
d/aws_nat_gateway: Tidy up.
8c45580 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2NATGateway_\|TestAccEC2NATGatewayDataSource_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2NATGateway_\|TestAccEC2NATGatewayDataSource_ -timeout 180m
=== RUN   TestAccEC2NATGatewayDataSource_basic
=== PAUSE TestAccEC2NATGatewayDataSource_basic
=== RUN   TestAccEC2NATGateway_basic
=== PAUSE TestAccEC2NATGateway_basic
=== RUN   TestAccEC2NATGateway_disappears
=== PAUSE TestAccEC2NATGateway_disappears
=== RUN   TestAccEC2NATGateway_ConnectivityType_private
=== PAUSE TestAccEC2NATGateway_ConnectivityType_private
=== RUN   TestAccEC2NATGateway_tags
=== PAUSE TestAccEC2NATGateway_tags
=== CONT  TestAccEC2NATGatewayDataSource_basic
=== CONT  TestAccEC2NATGateway_ConnectivityType_private
=== CONT  TestAccEC2NATGateway_disappears
=== CONT  TestAccEC2NATGateway_basic
=== CONT  TestAccEC2NATGateway_tags
--- PASS: TestAccEC2NATGateway_ConnectivityType_private (191.40s)
--- PASS: TestAccEC2NATGateway_disappears (202.08s)
--- PASS: TestAccEC2NATGatewayDataSource_basic (203.84s)
--- PASS: TestAccEC2NATGateway_tags (208.55s)
--- PASS: TestAccEC2NATGateway_basic (215.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	219.916s
@ewbankkit
r/aws_vpc_dhcp_options: Tidy resource Create and Read.
ba949c9 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2VPCDHCPOptions_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2VPCDHCPOptions_ -timeout 180m
=== RUN   TestAccEC2VPCDHCPOptions_basic
=== PAUSE TestAccEC2VPCDHCPOptions_basic
=== RUN   TestAccEC2VPCDHCPOptions_tags
=== PAUSE TestAccEC2VPCDHCPOptions_tags
=== RUN   TestAccEC2VPCDHCPOptions_disappears
=== PAUSE TestAccEC2VPCDHCPOptions_disappears
=== CONT  TestAccEC2VPCDHCPOptions_basic
=== CONT  TestAccEC2VPCDHCPOptions_disappears
=== CONT  TestAccEC2VPCDHCPOptions_tags
--- PASS: TestAccEC2VPCDHCPOptions_disappears (12.40s)
--- PASS: TestAccEC2VPCDHCPOptions_basic (18.49s)
--- PASS: TestAccEC2VPCDHCPOptions_tags (37.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	41.768s
@ewbankkit
r/aws_vpc_dhcp_options: Tidy resource Delete.
797bf72 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2VPCDHCPOptions_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2VPCDHCPOptions_ -timeout 180m
=== RUN   TestAccEC2VPCDHCPOptions_basic
=== PAUSE TestAccEC2VPCDHCPOptions_basic
=== RUN   TestAccEC2VPCDHCPOptions_tags
=== PAUSE TestAccEC2VPCDHCPOptions_tags
=== RUN   TestAccEC2VPCDHCPOptions_disappears
=== PAUSE TestAccEC2VPCDHCPOptions_disappears
=== CONT  TestAccEC2VPCDHCPOptions_basic
=== CONT  TestAccEC2VPCDHCPOptions_disappears
=== CONT  TestAccEC2VPCDHCPOptions_tags
--- PASS: TestAccEC2VPCDHCPOptions_disappears (12.09s)
--- PASS: TestAccEC2VPCDHCPOptions_basic (17.83s)
--- PASS: TestAccEC2VPCDHCPOptions_tags (37.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	42.073s
@ewbankkit
r/aws_vpc_dhcp_options_association: Tidy up resource.
01a5114 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2VPCDHCPOptionsAssociation_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2VPCDHCPOptionsAssociation_ -timeout 180m
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_basic
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_basic
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_disappears
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_disappears
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_basic
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_disappears
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc (20.46s)
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_disappears (23.63s)
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp (24.30s)
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_basic (26.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	30.673s
@ewbankkit
'FindDhcpOptions' -> 'FindDHCPOptions'.
914e503
@ewbankkit
r/aws_vpc_dhcp_options: Tidy up sweeper.
a0cc439 
Acceptance test output:

% make sweep SWEEPARGS=-sweep-run=aws_vpc_dhcp_options SWEEP=us-west-2
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2 -sweep-run=aws_vpc_dhcp_options -timeout 60m
2022/01/14 09:27:07 [DEBUG] Running Sweepers for region (us-west-2):
2022/01/14 09:27:07 [DEBUG] Running Sweeper (aws_vpc_dhcp_options) in region (us-west-2)
2022/01/14 09:27:07 [INFO] AWS Auth provider used: "EnvProvider"
2022/01/14 09:27:07 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/01/14 09:27:07 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/01/14 09:27:08 [DEBUG] Waiting for state to become: [success]
2022/01/14 09:27:08 [DEBUG] Waiting for state to become: [success]
2022/01/14 09:27:08 [DEBUG] Waiting for state to become: [success]
2022/01/14 09:27:08 [DEBUG] Waiting for state to become: [success]
2022/01/14 09:27:08 [INFO] Disassociating EC2 DHCP Options Set (dopt-0091271536eebfab3) from VPC (vpc-0438ef61a7dd278d4)
2022/01/14 09:27:08 [INFO] Disassociating EC2 DHCP Options Set (dopt-0d9d41b02deb15236) from VPC (vpc-066da02a4ac34f0c9)
2022/01/14 09:27:08 [INFO] Disassociating EC2 DHCP Options Set (dopt-06c51547e5084420a) from VPC (vpc-0b40101e420debcad)
2022/01/14 09:27:08 [INFO] Disassociating EC2 DHCP Options Set (dopt-0c6f0d3371719443f) from VPC (vpc-05cfd9a4cfad3a128)
2022/01/14 09:27:09 [INFO] Deleting EC2 DHCP Options Set: dopt-0091271536eebfab3
2022/01/14 09:27:09 [DEBUG] Waiting for state to become: [success]
2022/01/14 09:27:09 [INFO] Deleting EC2 DHCP Options Set: dopt-0d9d41b02deb15236
2022/01/14 09:27:09 [DEBUG] Waiting for state to become: [success]
2022/01/14 09:27:09 [INFO] Deleting EC2 DHCP Options Set: dopt-06c51547e5084420a
2022/01/14 09:27:09 [DEBUG] Waiting for state to become: [success]
2022/01/14 09:27:09 [INFO] Deleting EC2 DHCP Options Set: dopt-0c6f0d3371719443f
2022/01/14 09:27:09 [DEBUG] Waiting for state to become: [success]
2022/01/14 09:27:09 [DEBUG] Completed Sweeper (aws_vpc_dhcp_options) in region (us-west-2) in 2.644398839s
2022/01/14 09:27:09 Completed Sweepers for region (us-west-2) in 2.644659654s
2022/01/14 09:27:09 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_vpc_dhcp_options
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	5.836s
@ewbankkit
d/aws_vpc_dhcp_options: Tidy up.
03aa14c 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2VPCDHCPOptionsDataSource_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2VPCDHCPOptionsDataSource_ -timeout 180m
=== RUN   TestAccEC2VPCDHCPOptionsDataSource_basic
=== PAUSE TestAccEC2VPCDHCPOptionsDataSource_basic
=== RUN   TestAccEC2VPCDHCPOptionsDataSource_filter
=== PAUSE TestAccEC2VPCDHCPOptionsDataSource_filter
=== CONT  TestAccEC2VPCDHCPOptionsDataSource_basic
=== CONT  TestAccEC2VPCDHCPOptionsDataSource_filter
--- PASS: TestAccEC2VPCDHCPOptionsDataSource_basic (17.24s)
--- PASS: TestAccEC2VPCDHCPOptionsDataSource_filter (24.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	28.287s
% make testacc TESTARGS='-run=TestAccEC2VPCDHCPOptions_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2VPCDHCPOptions_ -timeout 180m
=== RUN   TestAccEC2VPCDHCPOptions_basic
=== PAUSE TestAccEC2VPCDHCPOptions_basic
=== RUN   TestAccEC2VPCDHCPOptions_tags
=== PAUSE TestAccEC2VPCDHCPOptions_tags
=== RUN   TestAccEC2VPCDHCPOptions_disappears
=== PAUSE TestAccEC2VPCDHCPOptions_disappears
=== CONT  TestAccEC2VPCDHCPOptions_basic
=== CONT  TestAccEC2VPCDHCPOptions_disappears
=== CONT  TestAccEC2VPCDHCPOptions_tags
--- PASS: TestAccEC2VPCDHCPOptions_disappears (13.44s)
--- PASS: TestAccEC2VPCDHCPOptions_basic (16.43s)
--- PASS: TestAccEC2VPCDHCPOptions_tags (35.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	39.374s
@ewbankkit
r/aws_vpc: Tidy up use of 'FindVPCByID'.
d7f5c52 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPC_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPC_basic -timeout 180m
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== CONT  TestAccVPC_basic
--- PASS: TestAccVPC_basic (25.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	29.629s
@ewbankkit
r/aws_vpc: Tidy up resource Create and Delete.
fc55808 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPC_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPC_basic -timeout 180m
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== CONT  TestAccVPC_basic
--- PASS: TestAccVPC_basic (27.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	31.925s
@ewbankkit
r/aws_vpc: Tweak 'FindVPCAttribute'.
58c4dfa 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPC_ -short' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccVPC_ -short -timeout 180m
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== RUN   TestAccVPC_disappears
=== PAUSE TestAccVPC_disappears
=== RUN   TestAccVPC_DefaultTags_providerOnly
=== PAUSE TestAccVPC_DefaultTags_providerOnly
=== RUN   TestAccVPC_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPC_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPC_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPC_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== RUN   TestAccVPC_DynamicResourceTags_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTags_ignoreChanges
=== RUN   TestAccVPC_defaultAndIgnoreTags
=== PAUSE TestAccVPC_defaultAndIgnoreTags
=== RUN   TestAccVPC_ignoreTags
=== PAUSE TestAccVPC_ignoreTags
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlock
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlock
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlockWithBorder
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlockWithBorder
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== RUN   TestAccVPC_IpamIpv4BasicNetmask
    vpc_test.go:700: skipping long-running test in short mode
--- SKIP: TestAccVPC_IpamIpv4BasicNetmask (0.00s)
=== RUN   TestAccVPC_IpamIpv4BasicExplicitCidr
    vpc_test.go:725: skipping long-running test in short mode
--- SKIP: TestAccVPC_IpamIpv4BasicExplicitCidr (0.00s)
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== RUN   TestAccVPC_update
=== PAUSE TestAccVPC_update
=== RUN   TestAccVPC_bothDNSOptionsSet
=== PAUSE TestAccVPC_bothDNSOptionsSet
=== RUN   TestAccVPC_disabledDNSSupport
=== PAUSE TestAccVPC_disabledDNSSupport
=== RUN   TestAccVPC_classicLinkOptionSet
=== PAUSE TestAccVPC_classicLinkOptionSet
=== RUN   TestAccVPC_classicLinkDNSSupportOptionSet
=== PAUSE TestAccVPC_classicLinkDNSSupportOptionSet
=== CONT  TestAccVPC_basic
=== CONT  TestAccVPC_ignoreTags
=== CONT  TestAccVPC_update
=== CONT  TestAccVPC_bothDNSOptionsSet
--- PASS: TestAccVPC_basic (28.21s)
=== CONT  TestAccVPC_tags
--- PASS: TestAccVPC_bothDNSOptionsSet (38.40s)
=== CONT  TestAccVPC_tenancy
--- PASS: TestAccVPC_ignoreTags (49.14s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlockWithBorder
--- PASS: TestAccVPC_update (53.28s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlock
--- PASS: TestAccVPC_tags (65.74s)
=== CONT  TestAccVPC_DynamicResourceTags_ignoreChanges
--- PASS: TestAccVPC_tenancy (66.71s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlockWithBorder (68.43s)
=== CONT  TestAccVPC_defaultAndIgnoreTags
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (68.21s)
=== CONT  TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (40.70s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (1.01s)
=== CONT  TestAccVPC_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (40.61s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (57.04s)
=== CONT  TestAccVPC_classicLinkDNSSupportOptionSet
--- PASS: TestAccVPC_defaultAndIgnoreTags (49.39s)
=== CONT  TestAccVPC_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (36.30s)
=== CONT  TestAccVPC_DefaultTags_providerOnly
--- PASS: TestAccVPC_classicLinkDNSSupportOptionSet (26.98s)
=== CONT  TestAccVPC_disappears
--- PASS: TestAccVPC_disappears (16.34s)
=== CONT  TestAccVPC_disabledDNSSupport
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (39.93s)
=== CONT  TestAccVPC_classicLinkOptionSet
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (57.28s)
--- PASS: TestAccVPC_DefaultTags_providerOnly (58.49s)
--- PASS: TestAccVPC_classicLinkOptionSet (25.62s)
--- PASS: TestAccVPC_disabledDNSSupport (35.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	244.478s
@ewbankkit
d/aws_vpc: Tidy up.
9876f50 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccEC2VPCDataSource_ -short' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccEC2VPCDataSource_ -short -timeout 180m
=== RUN   TestAccEC2VPCDataSource_basic
=== PAUSE TestAccEC2VPCDataSource_basic
=== RUN   TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
=== PAUSE TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
=== CONT  TestAccEC2VPCDataSource_basic
=== CONT  TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
--- PASS: TestAccEC2VPCDataSource_basic (26.91s)
--- PASS: TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple (50.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	54.480s
@ewbankkit
r/aws_vpc_ipv4_cidr_block_association: Tidy up resource Create and De…
1cdfe94 
…lete.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCIPv4CIDRBlockAssociation_ -short' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccVPCIPv4CIDRBlockAssociation_ -short -timeout 180m
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_basic
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_basic
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_IpamBasic
    vpc_ipv4_cidr_block_association_test.go:55: skipping long-running test in short mode
--- SKIP: TestAccVPCIPv4CIDRBlockAssociation_IpamBasic (0.00s)
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_IpamBasicExplicitCIDR
    vpc_ipv4_cidr_block_association_test.go:80: skipping long-running test in short mode
--- SKIP: TestAccVPCIPv4CIDRBlockAssociation_IpamBasicExplicitCIDR (0.00s)
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_basic
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_basic (46.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	50.454s
@ewbankkit
r/aws_vpc_ipv4_cidr_block_association: Tidy up resource Read.
9231b1a 
% make testacc TESTARGS='-run=TestAccVPCIPv4CIDRBlockAssociation_ -short' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccVPCIPv4CIDRBlockAssociation_ -short -timeout 180m
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_basic
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_basic
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_IpamBasic
    vpc_ipv4_cidr_block_association_test.go:56: skipping long-running test in short mode
--- SKIP: TestAccVPCIPv4CIDRBlockAssociation_IpamBasic (0.00s)
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_IpamBasicExplicitCIDR
    vpc_ipv4_cidr_block_association_test.go:81: skipping long-running test in short mode
--- SKIP: TestAccVPCIPv4CIDRBlockAssociation_IpamBasicExplicitCIDR (0.00s)
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_basic
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_basic (47.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	51.208s
@ewbankkit
r/aws_vpc_ipv4_cidr_block_association: Add 'TestAccVPCIPv4CIDRBlockAs…
ab7c5c1 
…sociation_disappears'.

% make testacc TESTARGS='-run=TestAccVPCIPv4CIDRBlockAssociation_disappears' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCIPv4CIDRBlockAssociation_disappears -timeout 180m
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_disappears
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_disappears
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_disappears
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_disappears (57.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	63.555s
@ewbankkit
r/aws_vpc_ipv6_cidr_block_association: Tidy up.
6991904 
% make testacc TESTARGS='-run=TestAccVPCIpam_ByoipIPv6' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCIpam_ByoipIPv6 -timeout 180m
=== RUN   TestAccVPCIpam_ByoipIPv6
    vpc_byoip_test.go:21: Environment variable IPAM_BYOIP_IPV6_MESSAGE, IPAM_BYOIP_IPV6_SIGNATURE, or IPAM_BYOIP_IPV6_PROVISIONED_CIDR is not set
--- SKIP: TestAccVPCIpam_ByoipIPv6 (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	4.067s
@ewbankkit
r/aws_instance: Use 'FindVPCByID' to determine whether or not the ins…
1a818a4 
…tance is running in the default VPC.

% make testacc TESTARGS='-run=TestAccEC2Instance_inDefaultVPCBySgID' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2Instance_inDefaultVPCBySgID -timeout 180m
=== RUN   TestAccEC2Instance_inDefaultVPCBySgID
=== PAUSE TestAccEC2Instance_inDefaultVPCBySgID
=== CONT  TestAccEC2Instance_inDefaultVPCBySgID
--- PASS: TestAccEC2Instance_inDefaultVPCBySgID (126.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	133.645s
@ewbankkit
Revert "Fix reading security group after create"
f7b28d7 
This reverts commit ce11e31.
@ewbankkit
Revert "Fix updating Security Group error"
0cec865 
This reverts commit 9cbd6c5.
@ewbankkit
Merge branch 'tmp-22415' into HEAD
3d1c9e9
@ewbankkit
Merge remote-tracking branch 'origin/f-modernize-aws_egress_only_inte…
b41c162 
…rnet_gateway+aws_nat_gateway+aws_vpc' into HEAD
@ewbankkit ewbankkit mentioned this pull request Jan 18, 2022
Closed
@ewbankkit
r/aws_security_group: Ensure that the Security Group is found 3 times…
25c4af4 
… in a row before declaring that it has been created.

% make testacc TESTARGS='-run=TestAccEC2SecurityGroup_basic' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2SecurityGroup_basic -timeout 180m
=== RUN   TestAccEC2SecurityGroup_basic
=== PAUSE TestAccEC2SecurityGroup_basic
=== CONT  TestAccEC2SecurityGroup_basic
--- PASS: TestAccEC2SecurityGroup_basic (27.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	31.672s
@ewbankkit
r/aws_security_group: Add 'TestAccEC2SecurityGroup_disappears' (hashi…
f45ee16 
…corp#13527).

% make testacc TESTARGS='-run=TestAccEC2SecurityGroup_disappears' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2SecurityGroup_basic -timeout 180m
=== RUN   TestAccEC2SecurityGroup_basic
=== PAUSE TestAccEC2SecurityGroup_basic
=== CONT  TestAccEC2SecurityGroup_basic
--- PASS: TestAccEC2SecurityGroup_basic (27.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	31.672s
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jan 18, 2022
ewbankkit
ewbankkit approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccEC2EgressOnlyInternetGateway_\|TestAccEC2NATGatewayDataSource_\|TestAccEC2NATGateway_\|TestAccEC2SecurityGroup_basic\|TestAccEC2VPCDataSource_\|TestAccEC2VPCDHCPOptionsAssociation_\|TestAccEC2VPCDHCPOptionsDataSource_\|TestAccEC2VPCDHCPOptions_\|TestAccVPCIPv4CIDRBlockAssociation_\|TestAccVPC_ -short' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccEC2EgressOnlyInternetGateway_\|TestAccEC2NATGatewayDataSource_\|TestAccEC2NATGateway_\|TestAccEC2SecurityGroup_basic\|TestAccEC2VPCDataSource_\|TestAccEC2VPCDHCPOptionsAssociation_\|TestAccEC2VPCDHCPOptionsDataSource_\|TestAccEC2VPCDHCPOptions_\|TestAccVPCIPv4CIDRBlockAssociation_\|TestAccVPC_ -short -timeout 180m
=== RUN   TestAccEC2EgressOnlyInternetGateway_basic
=== PAUSE TestAccEC2EgressOnlyInternetGateway_basic
=== RUN   TestAccEC2EgressOnlyInternetGateway_tags
=== PAUSE TestAccEC2EgressOnlyInternetGateway_tags
=== RUN   TestAccEC2NATGatewayDataSource_basic
=== PAUSE TestAccEC2NATGatewayDataSource_basic
=== RUN   TestAccEC2NATGateway_basic
=== PAUSE TestAccEC2NATGateway_basic
=== RUN   TestAccEC2NATGateway_disappears
=== PAUSE TestAccEC2NATGateway_disappears
=== RUN   TestAccEC2NATGateway_ConnectivityType_private
=== PAUSE TestAccEC2NATGateway_ConnectivityType_private
=== RUN   TestAccEC2NATGateway_tags
=== PAUSE TestAccEC2NATGateway_tags
=== RUN   TestAccEC2SecurityGroup_basic
=== PAUSE TestAccEC2SecurityGroup_basic
=== RUN   TestAccEC2VPCDataSource_basic
=== PAUSE TestAccEC2VPCDataSource_basic
=== RUN   TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
=== PAUSE TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_basic
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_basic
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_disappears
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_disappears
=== RUN   TestAccEC2VPCDHCPOptionsDataSource_basic
=== PAUSE TestAccEC2VPCDHCPOptionsDataSource_basic
=== RUN   TestAccEC2VPCDHCPOptionsDataSource_filter
=== PAUSE TestAccEC2VPCDHCPOptionsDataSource_filter
=== RUN   TestAccEC2VPCDHCPOptions_basic
=== PAUSE TestAccEC2VPCDHCPOptions_basic
=== RUN   TestAccEC2VPCDHCPOptions_tags
=== PAUSE TestAccEC2VPCDHCPOptions_tags
=== RUN   TestAccEC2VPCDHCPOptions_disappears
=== PAUSE TestAccEC2VPCDHCPOptions_disappears
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_basic
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_basic
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_disappears
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_disappears
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_IpamBasic
    vpc_ipv4_cidr_block_association_test.go:81: skipping long-running test in short mode
--- SKIP: TestAccVPCIPv4CIDRBlockAssociation_IpamBasic (0.00s)
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_IpamBasicExplicitCIDR
    vpc_ipv4_cidr_block_association_test.go:106: skipping long-running test in short mode
--- SKIP: TestAccVPCIPv4CIDRBlockAssociation_IpamBasicExplicitCIDR (0.00s)
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== RUN   TestAccVPC_disappears
=== PAUSE TestAccVPC_disappears
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== RUN   TestAccVPC_DefaultTags_providerOnly
=== PAUSE TestAccVPC_DefaultTags_providerOnly
=== RUN   TestAccVPC_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPC_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPC_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPC_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== RUN   TestAccVPC_DynamicResourceTags_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTags_ignoreChanges
=== RUN   TestAccVPC_defaultAndIgnoreTags
=== PAUSE TestAccVPC_defaultAndIgnoreTags
=== RUN   TestAccVPC_ignoreTags
=== PAUSE TestAccVPC_ignoreTags
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== RUN   TestAccVPC_updateDNSHostnames
=== PAUSE TestAccVPC_updateDNSHostnames
=== RUN   TestAccVPC_bothDNSOptionsSet
=== PAUSE TestAccVPC_bothDNSOptionsSet
=== RUN   TestAccVPC_disabledDNSSupport
=== PAUSE TestAccVPC_disabledDNSSupport
=== RUN   TestAccVPC_classicLinkOptionSet
=== PAUSE TestAccVPC_classicLinkOptionSet
=== RUN   TestAccVPC_classicLinkDNSSupportOptionSet
=== PAUSE TestAccVPC_classicLinkDNSSupportOptionSet
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlock
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlock
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== RUN   TestAccVPC_IpamIpv4BasicNetmask
    vpc_test.go:877: skipping long-running test in short mode
--- SKIP: TestAccVPC_IpamIpv4BasicNetmask (0.00s)
=== RUN   TestAccVPC_IpamIpv4BasicExplicitCidr
    vpc_test.go:903: skipping long-running test in short mode
--- SKIP: TestAccVPC_IpamIpv4BasicExplicitCidr (0.00s)
=== CONT  TestAccEC2EgressOnlyInternetGateway_basic
=== CONT  TestAccVPC_basic
=== CONT  TestAccVPC_defaultAndIgnoreTags
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
--- PASS: TestAccVPC_basic (24.58s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlock
--- PASS: TestAccEC2EgressOnlyInternetGateway_basic (33.37s)
=== CONT  TestAccVPC_updateDNSHostnames
--- PASS: TestAccVPC_defaultAndIgnoreTags (46.44s)
=== CONT  TestAccVPC_tenancy
--- PASS: TestAccVPC_updateDNSHostnames (48.28s)
=== CONT  TestAccVPC_ignoreTags
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup (84.28s)
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc (16.65s)
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_disappears
--- PASS: TestAccVPC_tenancy (61.63s)
=== CONT  TestAccVPC_bothDNSOptionsSet
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (94.92s)
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_basic
--- PASS: TestAccVPC_ignoreTags (44.72s)
=== CONT  TestAccVPC_classicLinkDNSSupportOptionSet
--- PASS: TestAccVPC_bothDNSOptionsSet (34.63s)
=== CONT  TestAccVPC_classicLinkOptionSet
--- PASS: TestAccVPC_classicLinkDNSSupportOptionSet (23.77s)
=== CONT  TestAccEC2VPCDHCPOptions_disappears
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_disappears (54.07s)
=== CONT  TestAccVPC_disabledDNSSupport
--- PASS: TestAccEC2VPCDHCPOptions_disappears (10.42s)
=== CONT  TestAccEC2VPCDHCPOptions_tags
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_basic (47.36s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPC_classicLinkOptionSet (25.12s)
=== CONT  TestAccEC2VPCDHCPOptions_basic
--- PASS: TestAccEC2VPCDHCPOptions_basic (14.05s)
=== CONT  TestAccVPC_DynamicResourceTags_ignoreChanges
--- PASS: TestAccVPC_disabledDNSSupport (34.05s)
=== CONT  TestAccEC2VPCDHCPOptionsDataSource_filter
--- PASS: TestAccEC2VPCDHCPOptions_tags (35.65s)
=== CONT  TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
--- PASS: TestAccEC2VPCDHCPOptionsDataSource_filter (20.81s)
=== CONT  TestAccEC2VPCDHCPOptionsDataSource_basic
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (50.80s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (36.89s)
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_disappears
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (1.12s)
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
--- PASS: TestAccEC2VPCDHCPOptionsDataSource_basic (14.84s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (38.11s)
=== CONT  TestAccVPC_DefaultTags_providerOnly
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_disappears (21.94s)
=== CONT  TestAccVPC_tags
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp (22.43s)
=== CONT  TestAccVPC_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (50.48s)
=== CONT  TestAccEC2NATGateway_tags
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (34.15s)
=== CONT  TestAccVPC_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPC_DefaultTags_providerOnly (50.79s)
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_basic
--- PASS: TestAccVPC_tags (61.29s)
=== CONT  TestAccEC2SecurityGroup_basic
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_basic (24.08s)
=== CONT  TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (35.26s)
=== CONT  TestAccEC2VPCDataSource_basic
--- PASS: TestAccEC2SecurityGroup_basic (25.51s)
=== CONT  TestAccEC2NATGateway_basic
--- PASS: TestAccEC2VPCDataSource_basic (34.72s)
=== CONT  TestAccEC2NATGateway_ConnectivityType_private
--- PASS: TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple (47.88s)
=== CONT  TestAccEC2EgressOnlyInternetGateway_tags
--- PASS: TestAccEC2EgressOnlyInternetGateway_tags (54.78s)
=== CONT  TestAccVPC_disappears
--- PASS: TestAccVPC_disappears (13.30s)
=== CONT  TestAccEC2NATGateway_disappears
--- PASS: TestAccEC2NATGateway_tags (224.00s)
=== CONT  TestAccEC2NATGatewayDataSource_basic
--- PASS: TestAccEC2NATGateway_ConnectivityType_private (167.84s)
--- PASS: TestAccEC2NATGateway_basic (220.02s)
--- PASS: TestAccEC2NATGateway_disappears (206.32s)
--- PASS: TestAccEC2NATGatewayDataSource_basic (167.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	670.488s
% AWS_DEFAULT_REGION=eu-south-1 make testacc TESTARGS='-run=TestAccEC2EgressOnlyInternetGateway_\|TestAccEC2NATGatewayDataSource_\|TestAccEC2NATGateway_\|TestAccEC2SecurityGroup_basic\|TestAccEC2VPCDataSource_\|TestAccEC2VPCDHCPOptionsAssociation_\|TestAccEC2VPCDHCPOptionsDataSource_\|TestAccEC2VPCDHCPOptions_\|TestAccVPCIPv4CIDRBlockAssociation_\|TestAccVPC_ -short' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccEC2EgressOnlyInternetGateway_\|TestAccEC2NATGatewayDataSource_\|TestAccEC2NATGateway_\|TestAccEC2SecurityGroup_basic\|TestAccEC2VPCDataSource_\|TestAccEC2VPCDHCPOptionsAssociation_\|TestAccEC2VPCDHCPOptionsDataSource_\|TestAccEC2VPCDHCPOptions_\|TestAccVPCIPv4CIDRBlockAssociation_\|TestAccVPC_ -short -timeout 180m
=== RUN   TestAccEC2EgressOnlyInternetGateway_basic
=== PAUSE TestAccEC2EgressOnlyInternetGateway_basic
=== RUN   TestAccEC2EgressOnlyInternetGateway_tags
=== PAUSE TestAccEC2EgressOnlyInternetGateway_tags
=== RUN   TestAccEC2NATGatewayDataSource_basic
=== PAUSE TestAccEC2NATGatewayDataSource_basic
=== RUN   TestAccEC2NATGateway_basic
=== PAUSE TestAccEC2NATGateway_basic
=== RUN   TestAccEC2NATGateway_disappears
=== PAUSE TestAccEC2NATGateway_disappears
=== RUN   TestAccEC2NATGateway_ConnectivityType_private
=== PAUSE TestAccEC2NATGateway_ConnectivityType_private
=== RUN   TestAccEC2NATGateway_tags
=== PAUSE TestAccEC2NATGateway_tags
=== RUN   TestAccEC2SecurityGroup_basic
=== PAUSE TestAccEC2SecurityGroup_basic
=== RUN   TestAccEC2VPCDataSource_basic
=== PAUSE TestAccEC2VPCDataSource_basic
=== RUN   TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
=== PAUSE TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_basic
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_basic
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_disappears
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_disappears
=== RUN   TestAccEC2VPCDHCPOptionsDataSource_basic
=== PAUSE TestAccEC2VPCDHCPOptionsDataSource_basic
=== RUN   TestAccEC2VPCDHCPOptionsDataSource_filter
=== PAUSE TestAccEC2VPCDHCPOptionsDataSource_filter
=== RUN   TestAccEC2VPCDHCPOptions_basic
=== PAUSE TestAccEC2VPCDHCPOptions_basic
=== RUN   TestAccEC2VPCDHCPOptions_tags
=== PAUSE TestAccEC2VPCDHCPOptions_tags
=== RUN   TestAccEC2VPCDHCPOptions_disappears
=== PAUSE TestAccEC2VPCDHCPOptions_disappears
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_basic
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_basic
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_disappears
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_disappears
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_IpamBasic
    vpc_ipv4_cidr_block_association_test.go:81: skipping long-running test in short mode
--- SKIP: TestAccVPCIPv4CIDRBlockAssociation_IpamBasic (0.00s)
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_IpamBasicExplicitCIDR
    vpc_ipv4_cidr_block_association_test.go:106: skipping long-running test in short mode
--- SKIP: TestAccVPCIPv4CIDRBlockAssociation_IpamBasicExplicitCIDR (0.00s)
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== RUN   TestAccVPC_disappears
=== PAUSE TestAccVPC_disappears
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== RUN   TestAccVPC_DefaultTags_providerOnly
=== PAUSE TestAccVPC_DefaultTags_providerOnly
=== RUN   TestAccVPC_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPC_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPC_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPC_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== RUN   TestAccVPC_DynamicResourceTags_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTags_ignoreChanges
=== RUN   TestAccVPC_defaultAndIgnoreTags
=== PAUSE TestAccVPC_defaultAndIgnoreTags
=== RUN   TestAccVPC_ignoreTags
=== PAUSE TestAccVPC_ignoreTags
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== RUN   TestAccVPC_updateDNSHostnames
=== PAUSE TestAccVPC_updateDNSHostnames
=== RUN   TestAccVPC_bothDNSOptionsSet
=== PAUSE TestAccVPC_bothDNSOptionsSet
=== RUN   TestAccVPC_disabledDNSSupport
=== PAUSE TestAccVPC_disabledDNSSupport
=== RUN   TestAccVPC_classicLinkOptionSet
=== PAUSE TestAccVPC_classicLinkOptionSet
=== RUN   TestAccVPC_classicLinkDNSSupportOptionSet
=== PAUSE TestAccVPC_classicLinkDNSSupportOptionSet
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlock
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlock
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== RUN   TestAccVPC_IpamIpv4BasicNetmask
    vpc_test.go:877: skipping long-running test in short mode
--- SKIP: TestAccVPC_IpamIpv4BasicNetmask (0.00s)
=== RUN   TestAccVPC_IpamIpv4BasicExplicitCidr
    vpc_test.go:903: skipping long-running test in short mode
--- SKIP: TestAccVPC_IpamIpv4BasicExplicitCidr (0.00s)
=== CONT  TestAccEC2EgressOnlyInternetGateway_basic
=== CONT  TestAccVPC_basic
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_disappears
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc (27.68s)
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_basic
--- PASS: TestAccVPC_basic (36.12s)
=== CONT  TestAccEC2VPCDHCPOptions_disappears
--- PASS: TestAccEC2EgressOnlyInternetGateway_basic (46.04s)
=== CONT  TestAccEC2VPCDHCPOptions_tags
--- PASS: TestAccEC2VPCDHCPOptions_disappears (16.51s)
=== CONT  TestAccEC2VPCDHCPOptions_basic
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_disappears (64.79s)
=== CONT  TestAccEC2VPCDHCPOptionsDataSource_filter
--- PASS: TestAccEC2VPCDHCPOptions_basic (21.50s)
=== CONT  TestAccEC2VPCDHCPOptionsDataSource_basic
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_basic (58.14s)
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_disappears
--- PASS: TestAccEC2VPCDHCPOptionsDataSource_basic (24.09s)
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
--- PASS: TestAccEC2VPCDHCPOptions_tags (53.41s)
=== CONT  TestAccVPC_disabledDNSSupport
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
--- PASS: TestAccEC2VPCDHCPOptionsDataSource_filter (35.40s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
    availability_zone_data_source_test.go:204: skipping since no Local Zones are available
--- SKIP: TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup (0.47s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlock
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_disappears (30.68s)
=== CONT  TestAccVPC_classicLinkDNSSupportOptionSet
    acctest.go:1008: skipping test for aws/eu-south-1: Error running apply: exit status 1
        
        Error: error enabling EC2 VPC (vpc-010d2d88431bb215a) ClassicLink: UnsupportedOperation: The functionality you requested is not available in this region.
        	status code: 400, request id: 7c67eaa8-9659-45a7-bff7-258c02a99824
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 2, in resource "aws_vpc" "test":
           2: resource "aws_vpc" "test" {
        
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp (29.28s)
=== CONT  TestAccVPC_classicLinkOptionSet
--- SKIP: TestAccVPC_classicLinkDNSSupportOptionSet (11.54s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccVPC_classicLinkOptionSet
    acctest.go:1008: skipping test for aws/eu-south-1: Error running apply: exit status 1
        
        Error: error enabling EC2 VPC (vpc-04c7dff9c96caeeab) ClassicLink: UnsupportedOperation: The functionality you requested is not available in this region.
        	status code: 400, request id: 7b88cec1-3e2e-4954-ad9e-713d7971348d
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 2, in resource "aws_vpc" "test":
           2: resource "aws_vpc" "test" {
        
--- SKIP: TestAccVPC_classicLinkOptionSet (11.36s)
=== CONT  TestAccVPC_DynamicResourceTags_ignoreChanges
--- PASS: TestAccVPC_disabledDNSSupport (43.60s)
=== CONT  TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (58.11s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (0.95s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (53.22s)
=== CONT  TestAccVPC_updateDNSHostnames
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (52.58s)
=== CONT  TestAccVPC_bothDNSOptionsSet
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (117.28s)
=== CONT  TestAccVPC_tenancy
--- PASS: TestAccVPC_bothDNSOptionsSet (46.50s)
=== CONT  TestAccEC2NATGateway_tags
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (61.38s)
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_basic
--- PASS: TestAccVPC_updateDNSHostnames (65.85s)
=== CONT  TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_basic (34.88s)
=== CONT  TestAccEC2VPCDataSource_basic
--- PASS: TestAccVPC_tenancy (89.56s)
=== CONT  TestAccEC2SecurityGroup_basic
--- PASS: TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple (58.16s)
=== CONT  TestAccEC2NATGateway_basic
--- PASS: TestAccEC2VPCDataSource_basic (45.11s)
=== CONT  TestAccEC2NATGateway_ConnectivityType_private
--- PASS: TestAccEC2SecurityGroup_basic (38.04s)
=== CONT  TestAccEC2NATGateway_disappears
--- PASS: TestAccEC2NATGateway_basic (193.75s)
=== CONT  TestAccVPC_ignoreTags
--- PASS: TestAccEC2NATGateway_tags (274.32s)
=== CONT  TestAccEC2NATGatewayDataSource_basic
--- PASS: TestAccEC2NATGateway_disappears (192.29s)
=== CONT  TestAccVPC_DefaultTags_providerOnly
--- PASS: TestAccEC2NATGateway_ConnectivityType_private (217.39s)
=== CONT  TestAccVPC_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPC_ignoreTags (68.92s)
=== CONT  TestAccVPC_defaultAndIgnoreTags
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (49.90s)
=== CONT  TestAccVPC_tags
--- PASS: TestAccVPC_DefaultTags_providerOnly (65.51s)
=== CONT  TestAccEC2EgressOnlyInternetGateway_tags
--- PASS: TestAccVPC_defaultAndIgnoreTags (63.64s)
=== CONT  TestAccVPC_disappears
--- PASS: TestAccVPC_disappears (21.45s)
=== CONT  TestAccVPC_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPC_tags (86.90s)
--- PASS: TestAccEC2EgressOnlyInternetGateway_tags (80.01s)
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (42.66s)
--- PASS: TestAccEC2NATGatewayDataSource_basic (215.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	735.064s
GovCloud
% make testacc TESTARGS='-run=TestAccEC2EgressOnlyInternetGateway_\|TestAccEC2NATGatewayDataSource_\|TestAccEC2NATGateway_\|TestAccEC2SecurityGroup_basic\|TestAccEC2VPCDataSource_\|TestAccEC2VPCDHCPOptionsAssociation_\|TestAccEC2VPCDHCPOptionsDataSource_\|TestAccEC2VPCDHCPOptions_\|TestAccVPCIPv4CIDRBlockAssociation_\|TestAccVPC_ -short' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccEC2EgressOnlyInternetGateway_\|TestAccEC2NATGatewayDataSource_\|TestAccEC2NATGateway_\|TestAccEC2SecurityGroup_basic\|TestAccEC2VPCDataSource_\|TestAccEC2VPCDHCPOptionsAssociation_\|TestAccEC2VPCDHCPOptionsDataSource_\|TestAccEC2VPCDHCPOptions_\|TestAccVPCIPv4CIDRBlockAssociation_\|TestAccVPC_ -short -timeout 180m
=== RUN   TestAccEC2EgressOnlyInternetGateway_basic
=== PAUSE TestAccEC2EgressOnlyInternetGateway_basic
=== RUN   TestAccEC2EgressOnlyInternetGateway_tags
=== PAUSE TestAccEC2EgressOnlyInternetGateway_tags
=== RUN   TestAccEC2NATGatewayDataSource_basic
=== PAUSE TestAccEC2NATGatewayDataSource_basic
=== RUN   TestAccEC2NATGateway_basic
=== PAUSE TestAccEC2NATGateway_basic
=== RUN   TestAccEC2NATGateway_disappears
=== PAUSE TestAccEC2NATGateway_disappears
=== RUN   TestAccEC2NATGateway_ConnectivityType_private
=== PAUSE TestAccEC2NATGateway_ConnectivityType_private
=== RUN   TestAccEC2NATGateway_tags
=== PAUSE TestAccEC2NATGateway_tags
=== RUN   TestAccEC2SecurityGroup_basic
=== PAUSE TestAccEC2SecurityGroup_basic
=== RUN   TestAccEC2VPCDataSource_basic
=== PAUSE TestAccEC2VPCDataSource_basic
=== RUN   TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
=== PAUSE TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_basic
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_basic
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
=== RUN   TestAccEC2VPCDHCPOptionsAssociation_disappears
=== PAUSE TestAccEC2VPCDHCPOptionsAssociation_disappears
=== RUN   TestAccEC2VPCDHCPOptionsDataSource_basic
=== PAUSE TestAccEC2VPCDHCPOptionsDataSource_basic
=== RUN   TestAccEC2VPCDHCPOptionsDataSource_filter
=== PAUSE TestAccEC2VPCDHCPOptionsDataSource_filter
=== RUN   TestAccEC2VPCDHCPOptions_basic
=== PAUSE TestAccEC2VPCDHCPOptions_basic
=== RUN   TestAccEC2VPCDHCPOptions_tags
=== PAUSE TestAccEC2VPCDHCPOptions_tags
=== RUN   TestAccEC2VPCDHCPOptions_disappears
=== PAUSE TestAccEC2VPCDHCPOptions_disappears
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_basic
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_basic
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_disappears
=== PAUSE TestAccVPCIPv4CIDRBlockAssociation_disappears
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_IpamBasic
    vpc_ipv4_cidr_block_association_test.go:81: skipping long-running test in short mode
--- SKIP: TestAccVPCIPv4CIDRBlockAssociation_IpamBasic (0.00s)
=== RUN   TestAccVPCIPv4CIDRBlockAssociation_IpamBasicExplicitCIDR
    vpc_ipv4_cidr_block_association_test.go:106: skipping long-running test in short mode
--- SKIP: TestAccVPCIPv4CIDRBlockAssociation_IpamBasicExplicitCIDR (0.00s)
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== RUN   TestAccVPC_disappears
=== PAUSE TestAccVPC_disappears
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== RUN   TestAccVPC_DefaultTags_providerOnly
=== PAUSE TestAccVPC_DefaultTags_providerOnly
=== RUN   TestAccVPC_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPC_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPC_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPC_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== RUN   TestAccVPC_DynamicResourceTags_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTags_ignoreChanges
=== RUN   TestAccVPC_defaultAndIgnoreTags
=== PAUSE TestAccVPC_defaultAndIgnoreTags
=== RUN   TestAccVPC_ignoreTags
=== PAUSE TestAccVPC_ignoreTags
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== RUN   TestAccVPC_updateDNSHostnames
=== PAUSE TestAccVPC_updateDNSHostnames
=== RUN   TestAccVPC_bothDNSOptionsSet
=== PAUSE TestAccVPC_bothDNSOptionsSet
=== RUN   TestAccVPC_disabledDNSSupport
=== PAUSE TestAccVPC_disabledDNSSupport
=== RUN   TestAccVPC_classicLinkOptionSet
=== PAUSE TestAccVPC_classicLinkOptionSet
=== RUN   TestAccVPC_classicLinkDNSSupportOptionSet
=== PAUSE TestAccVPC_classicLinkDNSSupportOptionSet
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlock
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlock
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== RUN   TestAccVPC_IpamIpv4BasicNetmask
    vpc_test.go:877: skipping long-running test in short mode
--- SKIP: TestAccVPC_IpamIpv4BasicNetmask (0.00s)
=== RUN   TestAccVPC_IpamIpv4BasicExplicitCidr
    vpc_test.go:903: skipping long-running test in short mode
--- SKIP: TestAccVPC_IpamIpv4BasicExplicitCidr (0.00s)
=== CONT  TestAccEC2EgressOnlyInternetGateway_basic
=== CONT  TestAccVPC_basic
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlock
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
    availability_zone_data_source_test.go:204: skipping since no Local Zones are available
--- SKIP: TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup (1.71s)
=== CONT  TestAccVPC_classicLinkDNSSupportOptionSet
    acctest.go:1008: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error enabling EC2 VPC (vpc-00b37238585c73c78) ClassicLink: UnsupportedOperation: The functionality you requested is not available in this region.
        	status code: 400, request id: 035436ad-8394-4f6f-b4a4-447019259d44
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 2, in resource "aws_vpc" "test":
           2: resource "aws_vpc" "test" {
        
--- SKIP: TestAccVPC_classicLinkDNSSupportOptionSet (9.63s)
=== CONT  TestAccVPC_classicLinkOptionSet
    acctest.go:1008: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error enabling EC2 VPC (vpc-0488cc220fe29c47f) ClassicLink: UnsupportedOperation: The functionality you requested is not available in this region.
        	status code: 400, request id: c471bb3b-269e-44ae-9ebd-7daf4169f31a
        
          with aws_vpc.test,
          on terraform_plugin_test.tf line 2, in resource "aws_vpc" "test":
           2: resource "aws_vpc" "test" {
        
--- SKIP: TestAccVPC_classicLinkOptionSet (10.85s)
=== CONT  TestAccVPC_disabledDNSSupport
--- PASS: TestAccVPC_basic (30.11s)
=== CONT  TestAccVPC_bothDNSOptionsSet
--- PASS: TestAccEC2EgressOnlyInternetGateway_basic (39.30s)
=== CONT  TestAccVPC_updateDNSHostnames
--- PASS: TestAccVPC_disabledDNSSupport (36.73s)
=== CONT  TestAccVPC_tenancy
--- PASS: TestAccVPC_bothDNSOptionsSet (37.06s)
=== CONT  TestAccVPC_ignoreTags
--- PASS: TestAccVPC_updateDNSHostnames (53.76s)
=== CONT  TestAccVPC_defaultAndIgnoreTags
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (103.48s)
=== CONT  TestAccVPC_DynamicResourceTags_ignoreChanges
--- PASS: TestAccVPC_ignoreTags (51.07s)
=== CONT  TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
--- PASS: TestAccVPC_tenancy (70.99s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (1.04s)
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc
--- PASS: TestAccVPC_defaultAndIgnoreTags (50.46s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (43.53s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_Disappears_vpc (22.00s)
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_disappears
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (43.25s)
=== CONT  TestAccVPCIPv4CIDRBlockAssociation_basic
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (47.50s)
=== CONT  TestAccEC2VPCDHCPOptions_disappears
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (46.88s)
=== CONT  TestAccEC2VPCDHCPOptions_tags
--- PASS: TestAccEC2VPCDHCPOptions_disappears (15.02s)
=== CONT  TestAccVPC_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_disappears (55.26s)
=== CONT  TestAccEC2VPCDHCPOptions_basic
--- PASS: TestAccVPCIPv4CIDRBlockAssociation_basic (48.95s)
=== CONT  TestAccVPC_DefaultTags_updateToProviderOnly
--- PASS: TestAccEC2VPCDHCPOptions_basic (18.06s)
=== CONT  TestAccEC2VPCDHCPOptionsDataSource_filter
--- PASS: TestAccEC2VPCDHCPOptions_tags (45.15s)
=== CONT  TestAccEC2VPCDHCPOptionsDataSource_basic
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (35.87s)
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_disappears
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (35.38s)
=== CONT  TestAccVPC_tags
--- PASS: TestAccEC2VPCDHCPOptionsDataSource_filter (27.38s)
=== CONT  TestAccEC2NATGateway_tags
--- PASS: TestAccEC2VPCDHCPOptionsDataSource_basic (19.06s)
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_basic
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_disappears (25.47s)
=== CONT  TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_basic (27.22s)
=== CONT  TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp
--- PASS: TestAccEC2VPCDHCPOptionsAssociation_Disappears_dhcp (22.56s)
=== CONT  TestAccVPC_disappears
--- PASS: TestAccVPC_tags (68.53s)
=== CONT  TestAccEC2VPCDataSource_basic
--- PASS: TestAccEC2VPCDataSource_CIDRBlockAssociations_multiple (49.95s)
=== CONT  TestAccEC2SecurityGroup_basic
--- PASS: TestAccVPC_disappears (17.91s)
=== CONT  TestAccEC2NATGatewayDataSource_basic
--- PASS: TestAccEC2SecurityGroup_basic (30.31s)
=== CONT  TestAccEC2EgressOnlyInternetGateway_tags
--- PASS: TestAccEC2VPCDataSource_basic (36.96s)
=== CONT  TestAccEC2NATGateway_ConnectivityType_private
--- PASS: TestAccEC2EgressOnlyInternetGateway_tags (64.01s)
=== CONT  TestAccEC2NATGateway_basic
--- PASS: TestAccEC2NATGateway_tags (212.27s)
=== CONT  TestAccVPC_DefaultTags_providerOnly
--- PASS: TestAccEC2NATGatewayDataSource_basic (169.21s)
=== CONT  TestAccEC2NATGateway_disappears
--- PASS: TestAccVPC_DefaultTags_providerOnly (49.12s)
--- PASS: TestAccEC2NATGateway_ConnectivityType_private (188.97s)
--- PASS: TestAccEC2NATGateway_basic (211.85s)
--- PASS: TestAccEC2NATGateway_disappears (169.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	668.600s

@ewbankkit ewbankkit merged commit 6a605b2 into hashicorp:main Jan 18, 2022
@github-actions github-actions bot added this to the v3.73.0 milestone Jan 18, 2022
@jasonkinsella jasonkinsella mentioned this pull request Jan 20, 2022
Closed
@github-actions
Copy link

This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

ewbankkit added a commit that referenced this pull request Feb 8, 2022
@ewbankkit
r/aws_vpc: Restore resourceVPCCustomizeDiff functionality from #6721 …
3e0c6d7 
…mistakenly removed in #22420.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rommy1204 rommy1204 rommy1204 approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.73.0
Development

Successfully merging this pull request may close these issues.

resource/aws_security_group: error updating Security Group (sg-xxx): couldn't find resource
4 participants
@fomichevmi @ewbankkit @rommy1204 @justinretzolk