Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudwatch: ISO-friendly tagging #22556

Merged
merged 6 commits into from
Jan 13, 2022
Merged

cloudwatch: ISO-friendly tagging #22556

merged 6 commits into from
Jan 13, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 12, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18593
Relates #22532

Output from acceptance testing (us-west-2):

% make testacc TESTS=TestAccCloudWatchCompositeAlarm_ PKG=cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch/... -v -count 1 -parallel 20 -run='TestAccCloudWatchCompositeAlarm_'  -timeout 180m
--- PASS: TestAccCloudWatchCompositeAlarm_disappears (20.04s)
--- PASS: TestAccCloudWatchCompositeAlarm_basic (23.79s)
--- PASS: TestAccCloudWatchCompositeAlarm_updateAlarmRule (39.98s)
--- PASS: TestAccCloudWatchCompositeAlarm_description (40.27s)
--- PASS: TestAccCloudWatchCompositeAlarm_actionsEnabled (40.38s)
--- PASS: TestAccCloudWatchCompositeAlarm_allActions (42.97s)
--- PASS: TestAccCloudWatchCompositeAlarm_okActions (57.93s)
--- PASS: TestAccCloudWatchCompositeAlarm_alarmActions (58.02s)
--- PASS: TestAccCloudWatchCompositeAlarm_insufficientDataActions (58.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	59.533s
% make testacc TESTS=TestAccCloudWatchMetricAlarm_ PKG=cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch/... -v -count 1 -parallel 20 -run='TestAccCloudWatchMetricAlarm_'  -timeout 180m
--- PASS: TestAccCloudWatchMetricAlarm_missingStatistic (8.44s)
--- PASS: TestAccCloudWatchMetricAlarm_disappears (18.27s)
--- PASS: TestAccCloudWatchMetricAlarm_dataPointsToAlarm (20.92s)
--- PASS: TestAccCloudWatchMetricAlarm_extendedStatistic (20.95s)
--- PASS: TestAccCloudWatchMetricAlarm_basic (23.15s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_swfAction (23.76s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic (26.04s)
--- PASS: TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (32.17s)
--- PASS: TestAccCloudWatchMetricAlarm_treatMissingData (43.94s)
--- PASS: TestAccCloudWatchMetricAlarm_tags (46.23s)
--- PASS: TestAccCloudWatchMetricAlarm_expression (79.77s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate (226.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	228.299s
% make testacc TESTS=TestAccCloudWatchMetricStream_ PKG=cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch/... -v -count 1 -parallel 20 -run='TestAccCloudWatchMetricStream_'  -timeout 180m
--- PASS: TestAccCloudWatchMetricStream_noName (19.99s)
--- PASS: TestAccCloudWatchMetricStream_excludeFilters (20.31s)
--- PASS: TestAccCloudWatchMetricStream_includeFilters (20.34s)
--- PASS: TestAccCloudWatchMetricStream_namePrefix (20.42s)
--- PASS: TestAccCloudWatchMetricStream_tags (20.42s)
--- PASS: TestAccCloudWatchMetricStream_basic (137.60s)
--- PASS: TestAccCloudWatchMetricStream_update (150.95s)
--- PASS: TestAccCloudWatchMetricStream_updateName (261.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	262.424s

Output from acceptance testing (GovCloud):

% make testacc TESTS=TestAccCloudWatchCompositeAlarm_ PKG=cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch/... -v -count 1 -parallel 20 -run='TestAccCloudWatchCompositeAlarm_'  -timeout 180m
--- PASS: TestAccCloudWatchCompositeAlarm_disappears (28.98s)
--- PASS: TestAccCloudWatchCompositeAlarm_basic (30.33s)
--- PASS: TestAccCloudWatchCompositeAlarm_description (56.80s)
--- PASS: TestAccCloudWatchCompositeAlarm_allActions (57.21s)
--- PASS: TestAccCloudWatchCompositeAlarm_actionsEnabled (57.42s)
--- PASS: TestAccCloudWatchCompositeAlarm_updateAlarmRule (57.48s)
--- PASS: TestAccCloudWatchCompositeAlarm_okActions (77.59s)
--- PASS: TestAccCloudWatchCompositeAlarm_alarmActions (77.81s)
--- PASS: TestAccCloudWatchCompositeAlarm_insufficientDataActions (77.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	79.566s
% make testacc TESTS=TestAccCloudWatchMetricAlarm_ PKG=cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch/... -v -count 1 -parallel 20 -run='TestAccCloudWatchMetricAlarm_'  -timeout 180m
--- PASS: TestAccCloudWatchMetricAlarm_missingStatistic (9.19s)
--- PASS: TestAccCloudWatchMetricAlarm_disappears (19.08s)
--- PASS: TestAccCloudWatchMetricAlarm_extendedStatistic (22.76s)
--- PASS: TestAccCloudWatchMetricAlarm_dataPointsToAlarm (22.78s)
--- PASS: TestAccCloudWatchMetricAlarm_basic (25.79s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_swfAction (25.86s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_snsTopic (29.38s)
--- PASS: TestAccCloudWatchMetricAlarm_evaluateLowSampleCountPercentiles (41.41s)
--- PASS: TestAccCloudWatchMetricAlarm_tags (57.46s)
--- PASS: TestAccCloudWatchMetricAlarm_treatMissingData (58.90s)
--- PASS: TestAccCloudWatchMetricAlarm_expression (104.35s)
--- PASS: TestAccCloudWatchMetricAlarm_AlarmActions_ec2Automate (214.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	216.268s
% make testacc TESTS=TestAccCloudWatchMetricStream_ PKG=cloudwatch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudwatch/... -v -count 1 -parallel 20 -run='TestAccCloudWatchMetricStream_'  -timeout 180m
--- SKIP: TestAccCloudWatchMetricStream_includeFilters (70.10s)
--- SKIP: TestAccCloudWatchMetricStream_update (70.10s)
--- SKIP: TestAccCloudWatchMetricStream_tags (70.10s)
--- SKIP: TestAccCloudWatchMetricStream_excludeFilters (70.10s)
--- SKIP: TestAccCloudWatchMetricStream_namePrefix (70.10s)
--- SKIP: TestAccCloudWatchMetricStream_noName (70.11s)
--- SKIP: TestAccCloudWatchMetricStream_updateName (119.92s)
--- SKIP: TestAccCloudWatchMetricStream_basic (141.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	143.419s

@github-actions github-actions bot added service/cloudwatch Issues and PRs that pertain to the cloudwatch service. size/S Managed by automation to categorize the size of a PR. labels Jan 12, 2022
@YakDriver YakDriver mentioned this pull request Jan 12, 2022
27 tasks
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jan 13, 2022
@YakDriver YakDriver merged commit c6f9483 into main Jan 13, 2022
@YakDriver YakDriver deleted the f-iso-tagging-cloudwatch branch January 13, 2022 02:03
@github-actions github-actions bot added this to the v3.72.0 milestone Jan 13, 2022
github-actions bot pushed a commit that referenced this pull request Jan 13, 2022
@github-actions
Copy link

This functionality has been released in v3.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/cloudwatch Issues and PRs that pertain to the cloudwatch service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant