Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Adds s3_use_path_style and deprecates s3_force_path_style #23055

Merged
merged 3 commits into from
Feb 9, 2022
Merged

provider: Adds s3_use_path_style and deprecates s3_force_path_style #23055

merged 3 commits into from
Feb 9, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Feb 9, 2022

Adds s3_use_path_style and deprecates s3_force_path_style

Closes #23026

Output from acceptance testing:

N/A

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. labels Feb 9, 2022
@gdavison gdavison added this to the v4.0.0 milestone Feb 9, 2022
ewbankkit
ewbankkit approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test ./internal/conns
ok  	github.com/hashicorp/terraform-provider-aws/internal/conns	0.732s

@gdavison gdavison merged commit eb9db5d into main Feb 9, 2022
@gdavison gdavison deleted the s3-use-pathname-parameter branch February 9, 2022 17:46
github-actions bot pushed a commit that referenced this pull request Feb 9, 2022
Update CHANGELOG.md for #23055
31df6c0
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

provider: S3 use path style configuration
2 participants
@gdavison @ewbankkit