Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source large enum validations from AWS Go SDK #24286

Merged
merged 4 commits into from
Apr 18, 2022
Merged

source large enum validations from AWS Go SDK #24286

merged 4 commits into from
Apr 18, 2022

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Apr 16, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14601.
picks up a couple new workspace compute types: GRAPHICS_G4DN and GRAPHICSPRO_G4DN

@PatMyron
source large enum validations from AWS Go SDK
d880385 
picks up a couple new workspace compute types
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. service/waf Issues and PRs that pertain to the waf service. service/workspaces Issues and PRs that pertain to the workspaces service. labels Apr 16, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Apr 16, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 18, 2022
ewbankkit
ewbankkit approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@PatMyron Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 18, 2022
@ewbankkit ewbankkit merged commit e0a2f55 into hashicorp:main Apr 18, 2022
@github-actions github-actions bot added this to the v4.11.0 milestone Apr 18, 2022
@PatMyron PatMyron deleted the sdk branch April 18, 2022 15:21
@github-actions
Copy link

This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. service/workspaces Issues and PRs that pertain to the workspaces service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PatMyron @ewbankkit