-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_athena_named_query #24815
d/aws_athena_named_query #24815
Conversation
Hi @justinretzolk! Was able to update the docs and fix some formatting issues so now all checks are passing! |
Hey @LukeHendrick 👋 Thank you very much for your contribution! I'm the community manager for the provider, so I'm mostly taking a quick glance over this until one of our maintainers can take a look at the PR itself (in case you're unfamiliar with how we prioritize, we have a document that details that). One thing I did notice on a quick check that we'll need a changelog entry as well. Other than that, this looks to be in good shape for review! |
# Conflicts: # internal/provider/provider.go # internal/service/athena/named_query_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAthenaNamedQuery' PKG=athena ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/athena/... -v -count 1 -parallel 2 -run=TestAccAthenaNamedQuery -timeout 360m
=== RUN TestAccAthenaNamedQueryDataSource_basic
=== PAUSE TestAccAthenaNamedQueryDataSource_basic
=== RUN TestAccAthenaNamedQuery_basic
=== PAUSE TestAccAthenaNamedQuery_basic
=== RUN TestAccAthenaNamedQuery_withWorkGroup
=== PAUSE TestAccAthenaNamedQuery_withWorkGroup
=== CONT TestAccAthenaNamedQueryDataSource_basic
=== CONT TestAccAthenaNamedQuery_withWorkGroup
--- PASS: TestAccAthenaNamedQueryDataSource_basic (54.79s)
=== CONT TestAccAthenaNamedQuery_basic
--- PASS: TestAccAthenaNamedQuery_withWorkGroup (57.49s)
--- PASS: TestAccAthenaNamedQuery_basic (39.33s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/athena 99.976s
@LukeHendrick Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Output from acceptance testing:
AWS API does not provide a way to natively retrieve aws_athena_named_query by name (id only). This data source allows you to do that (and filter by workspace)