-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support skip_destroy
on aws_cloudwatch_logs_group
resource
#26775
feat: support skip_destroy
on aws_cloudwatch_logs_group
resource
#26775
Conversation
204b277
to
24ffed0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @G-Rath 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Acceptance test output: % make testacc TESTARGS='-run=TestAccLogsGroup_' PKG=logs ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 2 -run=TestAccLogsGroup_ -timeout 180m === RUN TestAccLogsGroup_basic === PAUSE TestAccLogsGroup_basic === RUN TestAccLogsGroup_nameGenerate === PAUSE TestAccLogsGroup_nameGenerate === RUN TestAccLogsGroup_namePrefix === PAUSE TestAccLogsGroup_namePrefix === RUN TestAccLogsGroup_disappears === PAUSE TestAccLogsGroup_disappears === RUN TestAccLogsGroup_tags === PAUSE TestAccLogsGroup_tags === RUN TestAccLogsGroup_kmsKey === PAUSE TestAccLogsGroup_kmsKey === RUN TestAccLogsGroup_retentionPolicy === PAUSE TestAccLogsGroup_retentionPolicy === RUN TestAccLogsGroup_multiple === PAUSE TestAccLogsGroup_multiple === RUN TestAccLogsGroup_skipDestroy === PAUSE TestAccLogsGroup_skipDestroy === CONT TestAccLogsGroup_basic === CONT TestAccLogsGroup_kmsKey --- PASS: TestAccLogsGroup_basic (20.73s) === CONT TestAccLogsGroup_disappears --- PASS: TestAccLogsGroup_disappears (14.22s) === CONT TestAccLogsGroup_tags --- PASS: TestAccLogsGroup_kmsKey (54.26s) === CONT TestAccLogsGroup_skipDestroy --- PASS: TestAccLogsGroup_skipDestroy (14.95s) === CONT TestAccLogsGroup_namePrefix --- PASS: TestAccLogsGroup_tags (45.38s) === CONT TestAccLogsGroup_nameGenerate --- PASS: TestAccLogsGroup_namePrefix (18.51s) === CONT TestAccLogsGroup_retentionPolicy --- PASS: TestAccLogsGroup_nameGenerate (18.57s) === CONT TestAccLogsGroup_multiple --- PASS: TestAccLogsGroup_multiple (15.86s) --- PASS: TestAccLogsGroup_retentionPolicy (31.38s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/logs 123.609s
Acceptance test output: % make testacc TESTARGS='-run=TestAccLogsGroupDataSource_' PKG=logs ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 2 -run=TestAccLogsGroupDataSource_ -timeout 180m === RUN TestAccLogsGroupDataSource_basic === PAUSE TestAccLogsGroupDataSource_basic === CONT TestAccLogsGroupDataSource_basic --- PASS: TestAccLogsGroupDataSource_basic (18.36s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/logs 23.186s
…ashicorp#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccLogsGroup' PKG=logs ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 2 -run=TestAccLogsGroup -timeout 180m === RUN TestAccLogsGroupDataSource_basic === PAUSE TestAccLogsGroupDataSource_basic === RUN TestAccLogsGroup_basic === PAUSE TestAccLogsGroup_basic === RUN TestAccLogsGroup_nameGenerate === PAUSE TestAccLogsGroup_nameGenerate === RUN TestAccLogsGroup_namePrefix === PAUSE TestAccLogsGroup_namePrefix === RUN TestAccLogsGroup_disappears === PAUSE TestAccLogsGroup_disappears === RUN TestAccLogsGroup_tags === PAUSE TestAccLogsGroup_tags === RUN TestAccLogsGroup_kmsKey === PAUSE TestAccLogsGroup_kmsKey === RUN TestAccLogsGroup_retentionPolicy === PAUSE TestAccLogsGroup_retentionPolicy === RUN TestAccLogsGroup_multiple === PAUSE TestAccLogsGroup_multiple === RUN TestAccLogsGroup_skipDestroy === PAUSE TestAccLogsGroup_skipDestroy === RUN TestAccLogsGroupsDataSource_basic === PAUSE TestAccLogsGroupsDataSource_basic === RUN TestAccLogsGroupsDataSource_noPrefix === PAUSE TestAccLogsGroupsDataSource_noPrefix === CONT TestAccLogsGroupDataSource_basic === CONT TestAccLogsGroup_kmsKey --- PASS: TestAccLogsGroupDataSource_basic (19.91s) === CONT TestAccLogsGroup_skipDestroy --- PASS: TestAccLogsGroup_skipDestroy (16.49s) === CONT TestAccLogsGroupsDataSource_noPrefix --- PASS: TestAccLogsGroupsDataSource_noPrefix (17.97s) === CONT TestAccLogsGroupsDataSource_basic --- PASS: TestAccLogsGroup_kmsKey (56.70s) === CONT TestAccLogsGroup_multiple --- PASS: TestAccLogsGroupsDataSource_basic (16.42s) === CONT TestAccLogsGroup_namePrefix --- PASS: TestAccLogsGroup_multiple (16.25s) === CONT TestAccLogsGroup_tags --- PASS: TestAccLogsGroup_namePrefix (18.53s) === CONT TestAccLogsGroup_disappears --- PASS: TestAccLogsGroup_disappears (13.91s) === CONT TestAccLogsGroup_nameGenerate --- PASS: TestAccLogsGroup_tags (45.44s) === CONT TestAccLogsGroup_basic --- PASS: TestAccLogsGroup_nameGenerate (18.80s) === CONT TestAccLogsGroup_retentionPolicy --- PASS: TestAccLogsGroup_basic (18.65s) --- PASS: TestAccLogsGroup_retentionPolicy (32.96s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/logs 159.501s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLogsGroup' PKG=logs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/logs/... -v -count 1 -parallel 2 -run=TestAccLogsGroup -timeout 180m
=== RUN TestAccLogsGroupDataSource_basic
=== PAUSE TestAccLogsGroupDataSource_basic
=== RUN TestAccLogsGroup_basic
=== PAUSE TestAccLogsGroup_basic
=== RUN TestAccLogsGroup_nameGenerate
=== PAUSE TestAccLogsGroup_nameGenerate
=== RUN TestAccLogsGroup_namePrefix
=== PAUSE TestAccLogsGroup_namePrefix
=== RUN TestAccLogsGroup_disappears
=== PAUSE TestAccLogsGroup_disappears
=== RUN TestAccLogsGroup_tags
=== PAUSE TestAccLogsGroup_tags
=== RUN TestAccLogsGroup_kmsKey
=== PAUSE TestAccLogsGroup_kmsKey
=== RUN TestAccLogsGroup_retentionPolicy
=== PAUSE TestAccLogsGroup_retentionPolicy
=== RUN TestAccLogsGroup_multiple
=== PAUSE TestAccLogsGroup_multiple
=== RUN TestAccLogsGroup_skipDestroy
=== PAUSE TestAccLogsGroup_skipDestroy
=== RUN TestAccLogsGroupsDataSource_basic
=== PAUSE TestAccLogsGroupsDataSource_basic
=== RUN TestAccLogsGroupsDataSource_noPrefix
=== PAUSE TestAccLogsGroupsDataSource_noPrefix
=== CONT TestAccLogsGroupDataSource_basic
=== CONT TestAccLogsGroup_kmsKey
--- PASS: TestAccLogsGroupDataSource_basic (19.91s)
=== CONT TestAccLogsGroup_skipDestroy
--- PASS: TestAccLogsGroup_skipDestroy (16.49s)
=== CONT TestAccLogsGroupsDataSource_noPrefix
--- PASS: TestAccLogsGroupsDataSource_noPrefix (17.97s)
=== CONT TestAccLogsGroupsDataSource_basic
--- PASS: TestAccLogsGroup_kmsKey (56.70s)
=== CONT TestAccLogsGroup_multiple
--- PASS: TestAccLogsGroupsDataSource_basic (16.42s)
=== CONT TestAccLogsGroup_namePrefix
--- PASS: TestAccLogsGroup_multiple (16.25s)
=== CONT TestAccLogsGroup_tags
--- PASS: TestAccLogsGroup_namePrefix (18.53s)
=== CONT TestAccLogsGroup_disappears
--- PASS: TestAccLogsGroup_disappears (13.91s)
=== CONT TestAccLogsGroup_nameGenerate
--- PASS: TestAccLogsGroup_tags (45.44s)
=== CONT TestAccLogsGroup_basic
--- PASS: TestAccLogsGroup_nameGenerate (18.80s)
=== CONT TestAccLogsGroup_retentionPolicy
--- PASS: TestAccLogsGroup_basic (18.65s)
--- PASS: TestAccLogsGroup_retentionPolicy (32.96s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/logs 159.501s
@G-Rath Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #26752
Output from acceptance testing: