Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/3.x: r/aws_sqs_queue: Send any configured value of sqs_managed_sse_enabled on Create #27338

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 19, 2022

Description

release/3.x backport of #27335.

Relations

Relates #22197.
Relates #26843 (comment).
Relates #27313.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSQSQueue_managedEncryption\|TestAccSQSQueue_basic\|TestAccSQSQueue_encryption' PKG=sqs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 20  -run=TestAccSQSQueue_managedEncryption\|TestAccSQSQueue_basic\|TestAccSQSQueue_encryption -timeout 180m
=== RUN   TestAccSQSQueue_basic
=== PAUSE TestAccSQSQueue_basic
=== RUN   TestAccSQSQueue_encryption
=== PAUSE TestAccSQSQueue_encryption
=== RUN   TestAccSQSQueue_managedEncryption
=== PAUSE TestAccSQSQueue_managedEncryption
=== CONT  TestAccSQSQueue_basic
=== CONT  TestAccSQSQueue_managedEncryption
=== CONT  TestAccSQSQueue_encryption
--- PASS: TestAccSQSQueue_basic (58.68s)
--- PASS: TestAccSQSQueue_managedEncryption (151.06s)
--- PASS: TestAccSQSQueue_encryption (151.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	157.721s

…d' on Create.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccSQSQueue_managedEncryption\|TestAccSQSQueue_basic\|TestAccSQSQueue_encryption' PKG=sqs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 20  -run=TestAccSQSQueue_managedEncryption\|TestAccSQSQueue_basic\|TestAccSQSQueue_encryption -timeout 180m
=== RUN   TestAccSQSQueue_basic
=== PAUSE TestAccSQSQueue_basic
=== RUN   TestAccSQSQueue_encryption
=== PAUSE TestAccSQSQueue_encryption
=== RUN   TestAccSQSQueue_managedEncryption
=== PAUSE TestAccSQSQueue_managedEncryption
=== CONT  TestAccSQSQueue_basic
=== CONT  TestAccSQSQueue_encryption
=== CONT  TestAccSQSQueue_managedEncryption
--- PASS: TestAccSQSQueue_basic (49.88s)
--- PASS: TestAccSQSQueue_encryption (128.82s)
--- PASS: TestAccSQSQueue_managedEncryption (129.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	133.199s
@github-actions github-actions bot added service/sqs Issues and PRs that pertain to the sqs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Oct 19, 2022
@ewbankkit ewbankkit merged commit 8a4453c into release/3.x Oct 19, 2022
@ewbankkit ewbankkit deleted the release/3.x-b-aws_sqs_queue.sqs_managed_sse_enabled-pass-false branch October 19, 2022 21:37
@ewbankkit ewbankkit added this to the v3.75.3 milestone Oct 19, 2022
github-actions bot pushed a commit that referenced this pull request Oct 19, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/sqs Issues and PRs that pertain to the sqs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant