Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource_ssm_document): handle dynamic field refresh when content is updated #28489

Closed
wants to merge 1 commit into from

Conversation

jBouyoud
Copy link
Contributor

@jBouyoud jBouyoud commented Dec 20, 2022

Description

Declare computed field for *_version, hash, parameter when content is updated

Relations

Closes #26363

References

Output from Acceptance Testing

➜ make testacc TESTS=TestAccSSMDocument_update PKG=ssm                                                                                                                        15:24:22 

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMDocument_update'  -timeout 180m
=== RUN   TestAccSSMDocument_update
=== PAUSE TestAccSSMDocument_update
=== CONT  TestAccSSMDocument_update
--- PASS: TestAccSSMDocument_update (62.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        65.890s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 20, 2022
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@github-actions github-actions bot removed documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Dec 20, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jBouyoud 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@jBouyoud jBouyoud marked this pull request as ready for review December 20, 2022 14:34
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 6, 2023
@jBouyoud
Copy link
Contributor Author

jBouyoud commented Mar 2, 2023

Hello @justinretzolk (sorry for the direct ping).

This bug fix is now opened for few month, this bug is really painful in our organization, and I'd like to know how can I help to get this PR merge.

Thanks.

@jBouyoud
Copy link
Contributor Author

@ewbankkit This PR is not related to tags , It fix an issue with multiple ssm_document resources that depends each others.

@ewbankkit
Copy link
Contributor

@jBouyoud I rolled this PR into that other one as I was working on the same resource; we are calling out the fix in the release notes. Thanks.

@jBouyoud jBouyoud deleted the fix-ssm-doc-refresh branch April 3, 2023 06:41
@github-actions
Copy link

github-actions bot commented May 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ssm Issues and PRs that pertain to the ssm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ssm_document doesn't update latest_version when the content is updated
3 participants