Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_mediaconnect_flow: Add aws_mediaconnect_flow resource. #33516

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

gbw
Copy link
Contributor

@gbw gbw commented Sep 19, 2023

Description

Adds MediaConnect Flow support using aws-sdk-go-v2.

Relations

Relates PR #7431

References

MediaConnect Documentation

Output from Acceptance Testing

make testacc PKG=mediaconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mediaconnect/... -v -count 1 -parallel 20   -timeout 360m
=== RUN   TestAccMediaConnectFlow_basic
=== PAUSE TestAccMediaConnectFlow_basic
=== RUN   TestAccMediaConnectFlow_update
=== PAUSE TestAccMediaConnectFlow_update
=== RUN   TestAccMediaConnectFlow_disappears
=== PAUSE TestAccMediaConnectFlow_disappears
=== CONT  TestAccMediaConnectFlow_basic
=== CONT  TestAccMediaConnectFlow_update
=== CONT  TestAccMediaConnectFlow_disappears
--- PASS: TestAccMediaConnectFlow_disappears (21.52s)
--- PASS: TestAccMediaConnectFlow_basic (25.11s)
--- PASS: TestAccMediaConnectFlow_update (35.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediaconnect       37.518s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/mediaconnect Issues and PRs that pertain to the mediaconnect service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. github_actions Pull requests that update Github_actions code labels Sep 19, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 19, 2023
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@gbw gbw marked this pull request as ready for review September 19, 2023 18:07
@gbw gbw marked this pull request as draft September 23, 2023 23:56
@gbw gbw force-pushed the f-mediaconnect_v2_flow branch 2 times, most recently from 2cc1ef0 to f7bdf7a Compare October 4, 2023 08:43
@github-actions github-actions bot removed tags Pertains to resource tagging. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. client-connections Pertains to the AWS Client and service connections. github_actions Pull requests that update Github_actions code labels Oct 4, 2023
@gbw gbw marked this pull request as ready for review October 4, 2023 19:58
@johnsonaj johnsonaj added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/mediaconnect Issues and PRs that pertain to the mediaconnect service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants