Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added client_cache to expandHLSGroupSettings #33798

Merged

Conversation

peletv2
Copy link
Contributor

@peletv2 peletv2 commented Oct 6, 2023

Description

Added missing client_cache to expandHLSGroupSettings.

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccMediaLiveChannel_hls PKG=medialive
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveChannel_hls'  -timeout 360m
=== RUN   TestAccMediaLiveChannel_hls
=== PAUSE TestAccMediaLiveChannel_hls
=== CONT  TestAccMediaLiveChannel_hls
--- PASS: TestAccMediaLiveChannel_hls (67.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	69.526s
...

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/medialive Issues and PRs that pertain to the medialive service. labels Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Hey @peletv2 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 6, 2023
@peletv2 peletv2 marked this pull request as ready for review October 6, 2023 11:38
@peletv2
Copy link
Contributor Author

peletv2 commented Oct 16, 2023

Due to our organization policy, we aren't able to allow you to make direct edits.

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 25, 2023
@peletv2 peletv2 force-pushed the b-aws_medialive_channel_hls_group_settings_client_cache branch from f411aa9 to 473824f Compare December 14, 2023 10:19
@peletv2
Copy link
Contributor Author

peletv2 commented Dec 14, 2023

I just rebased in order to stay up to date with main, making sure there are no conflicts.

@johnsonaj johnsonaj self-assigned this Feb 9, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 9, 2024
@johnsonaj
Copy link
Contributor

@peletv2 thank you for your contribution! 🎉. Since I could not edit your PR I merged it into the separate one tagged above.

@johnsonaj johnsonaj closed this pull request by merging all changes into hashicorp:main in 0a329df Feb 9, 2024
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 15, 2024
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/medialive Issues and PRs that pertain to the medialive service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants