-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated backups can be retained when deleting Aurora clusters. #34309
Automated backups can be retained when deleting Aurora clusters. #34309
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @xiaxuantan 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSCluster_basic\|TestAccRDSCluster_NoDeleteAutomatedBackups' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2 -run=TestAccRDSCluster_basic\|TestAccRDSCluster_NoDeleteAutomatedBackups -timeout 360m
=== RUN TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN TestAccRDSCluster_NoDeleteAutomatedBackups
=== PAUSE TestAccRDSCluster_NoDeleteAutomatedBackups
=== CONT TestAccRDSCluster_basic
=== CONT TestAccRDSCluster_NoDeleteAutomatedBackups
--- PASS: TestAccRDSCluster_basic (167.03s)
--- PASS: TestAccRDSCluster_NoDeleteAutomatedBackups (584.59s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 589.696s
@xiaxuantan Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
There is no support for
no-delete-automated-backups
foraws_rds_cluster
. This PR adds this field, allowing users to retain automatic snapshots after an rds aurora cluster is destroyed via Terraform.Relations
Closes #20839
References
Output from Acceptance Testing
All the failed cases are either:
engine
in the terraform input file13.5
, etc.Fixing them is out of scope.