r/lakeformation_data_lake_settings: add allow_full_table_external_data_access attribute

[pixie79]

Description

This PR add the missing setting to datalake_settings to allow for missing or miss configured STS:TagSessions to be ignored by AWS. It is a new bool setting avaliable within the AWS Datalake settings.

Updates both resource and data-source.

Relations

Closes #34471

Output from Acceptance Testing

I attempted to run the tests however, it would appear my dev environment does not have the resources for this to work

% make testacc TESTS= testAccDataLakeSettings_basic, testAccDataLakeSettingsDataSource_basic PKG=lakeformation

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[github-actions]

Welcome @pixie79 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[nickdelnano]

@pixie79 @justinretzolk can this be reviewed and (hopefully) merged? It would be great to have this supported in the terraform resource.

[alcysec]

cc @ewbankkit

[johnsonaj]

LGTM 🚀

% make testacc TESTARGS="-run=TestAccLakeFormation_serial/DataLakeSettings$" PKG=lakeformation

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/lakeformation/... -v -count 1 -parallel 20  -run=TestAccLakeFormation_serial/DataLakeSettings -timeout 360m
=== RUN   TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT  TestAccLakeFormation_serial
=== RUN   TestAccLakeFormation_serial/DataLakeSettings
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/basic
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/disappears
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId
=== RUN   TestAccLakeFormation_serial/DataLakeSettings/readOnlyAdmins
=== RUN   TestAccLakeFormation_serial/DataLakeSettingsDataSource
=== RUN   TestAccLakeFormation_serial/DataLakeSettingsDataSource/basic
=== RUN   TestAccLakeFormation_serial/DataLakeSettingsDataSource/readOnlyAdmins
--- PASS: TestAccLakeFormation_serial (77.46s)
    --- PASS: TestAccLakeFormation_serial/DataLakeSettings (51.77s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/basic (13.84s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/disappears (13.11s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId (12.32s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettings/readOnlyAdmins (12.50s)
    --- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource (25.69s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource/basic (12.73s)
        --- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource/readOnlyAdmins (12.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	83.476s

[johnsonaj]

@pixie79 thank you for the contribution! 🎉

[github-actions]

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.