Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Migrate mq resources to AWS SDK for Go v2 #35187

Merged
merged 14 commits into from
Jan 8, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 8, 2024

Description

Ibid.

Output from Acceptance Testing

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccMQ' PKG=mq ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mq/... -v -count 1 -parallel 3  -run=TestAccMQ -timeout 720m
=== RUN   TestAccMQBrokerDataSource_basic
=== PAUSE TestAccMQBrokerDataSource_basic
=== RUN   TestAccMQBrokerEngineTypesDataSource_basic
=== PAUSE TestAccMQBrokerEngineTypesDataSource_basic
=== RUN   TestAccMQBrokerInstanceTypeOfferingsDataSource_basic
=== PAUSE TestAccMQBrokerInstanceTypeOfferingsDataSource_basic
=== RUN   TestAccMQBroker_basic
=== PAUSE TestAccMQBroker_basic
=== RUN   TestAccMQBroker_disappears
=== PAUSE TestAccMQBroker_disappears
=== RUN   TestAccMQBroker_tags
=== PAUSE TestAccMQBroker_tags
=== RUN   TestAccMQBroker_throughputOptimized
=== PAUSE TestAccMQBroker_throughputOptimized
=== RUN   TestAccMQBroker_AllFields_defaultVPC
=== PAUSE TestAccMQBroker_AllFields_defaultVPC
=== RUN   TestAccMQBroker_AllFields_customVPC
=== PAUSE TestAccMQBroker_AllFields_customVPC
=== RUN   TestAccMQBroker_EncryptionOptions_kmsKeyID
=== PAUSE TestAccMQBroker_EncryptionOptions_kmsKeyID
=== RUN   TestAccMQBroker_EncryptionOptions_managedKeyDisabled
=== PAUSE TestAccMQBroker_EncryptionOptions_managedKeyDisabled
=== RUN   TestAccMQBroker_EncryptionOptions_managedKeyEnabled
=== PAUSE TestAccMQBroker_EncryptionOptions_managedKeyEnabled
=== RUN   TestAccMQBroker_Update_users
=== PAUSE TestAccMQBroker_Update_users
=== RUN   TestAccMQBroker_Update_securityGroup
=== PAUSE TestAccMQBroker_Update_securityGroup
=== RUN   TestAccMQBroker_Update_engineVersion
=== PAUSE TestAccMQBroker_Update_engineVersion
=== RUN   TestAccMQBroker_Update_hostInstanceType
=== PAUSE TestAccMQBroker_Update_hostInstanceType
=== RUN   TestAccMQBroker_RabbitMQ_basic
=== PAUSE TestAccMQBroker_RabbitMQ_basic
=== RUN   TestAccMQBroker_RabbitMQ_config
=== PAUSE TestAccMQBroker_RabbitMQ_config
=== RUN   TestAccMQBroker_RabbitMQ_logs
=== PAUSE TestAccMQBroker_RabbitMQ_logs
=== RUN   TestAccMQBroker_RabbitMQ_validationAuditLog
=== PAUSE TestAccMQBroker_RabbitMQ_validationAuditLog
=== RUN   TestAccMQBroker_RabbitMQ_cluster
=== PAUSE TestAccMQBroker_RabbitMQ_cluster
=== RUN   TestAccMQBroker_ldap
=== PAUSE TestAccMQBroker_ldap
=== RUN   TestAccMQConfiguration_basic
=== PAUSE TestAccMQConfiguration_basic
=== RUN   TestAccMQConfiguration_withActiveMQData
=== PAUSE TestAccMQConfiguration_withActiveMQData
=== RUN   TestAccMQConfiguration_withActiveMQLdapData
=== PAUSE TestAccMQConfiguration_withActiveMQLdapData
=== RUN   TestAccMQConfiguration_withRabbitMQData
=== PAUSE TestAccMQConfiguration_withRabbitMQData
=== RUN   TestAccMQConfiguration_tags
=== PAUSE TestAccMQConfiguration_tags
=== CONT  TestAccMQBrokerDataSource_basic
=== CONT  TestAccMQBroker_Update_engineVersion
=== CONT  TestAccMQBroker_ldap
--- PASS: TestAccMQBroker_ldap (915.56s)
=== CONT  TestAccMQBroker_RabbitMQ_logs
--- PASS: TestAccMQBrokerDataSource_basic (975.41s)
=== CONT  TestAccMQBroker_RabbitMQ_cluster
--- PASS: TestAccMQBroker_Update_engineVersion (1208.93s)
=== CONT  TestAccMQBroker_RabbitMQ_validationAuditLog
--- PASS: TestAccMQBroker_RabbitMQ_logs (620.82s)
=== CONT  TestAccMQConfiguration_withActiveMQLdapData
--- PASS: TestAccMQConfiguration_withActiveMQLdapData (25.36s)
=== CONT  TestAccMQConfiguration_tags
--- PASS: TestAccMQConfiguration_tags (42.57s)
=== CONT  TestAccMQConfiguration_withRabbitMQData
--- PASS: TestAccMQConfiguration_withRabbitMQData (17.78s)
=== CONT  TestAccMQConfiguration_withActiveMQData
--- PASS: TestAccMQConfiguration_withActiveMQData (18.22s)
=== CONT  TestAccMQConfiguration_basic
--- PASS: TestAccMQConfiguration_basic (35.00s)
=== CONT  TestAccMQBroker_AllFields_defaultVPC
--- PASS: TestAccMQBroker_RabbitMQ_validationAuditLog (537.20s)
=== CONT  TestAccMQBroker_Update_securityGroup
--- PASS: TestAccMQBroker_RabbitMQ_cluster (947.89s)
=== CONT  TestAccMQBroker_Update_users
--- PASS: TestAccMQBroker_Update_securityGroup (1174.15s)
=== CONT  TestAccMQBroker_EncryptionOptions_managedKeyEnabled
--- PASS: TestAccMQBroker_AllFields_defaultVPC (1638.92s)
=== CONT  TestAccMQBroker_EncryptionOptions_managedKeyDisabled
--- PASS: TestAccMQBroker_Update_users (1402.03s)
=== CONT  TestAccMQBroker_EncryptionOptions_kmsKeyID
--- PASS: TestAccMQBroker_EncryptionOptions_managedKeyEnabled (1120.29s)
=== CONT  TestAccMQBroker_AllFields_customVPC
--- PASS: TestAccMQBroker_EncryptionOptions_managedKeyDisabled (958.04s)
=== CONT  TestAccMQBroker_disappears
--- PASS: TestAccMQBroker_EncryptionOptions_kmsKeyID (968.51s)
=== CONT  TestAccMQBroker_throughputOptimized
--- PASS: TestAccMQBroker_disappears (887.30s)
=== CONT  TestAccMQBroker_tags
--- PASS: TestAccMQBroker_throughputOptimized (865.87s)
=== CONT  TestAccMQBroker_RabbitMQ_basic
--- PASS: TestAccMQBroker_AllFields_customVPC (1749.23s)
=== CONT  TestAccMQBroker_RabbitMQ_config
--- PASS: TestAccMQBroker_RabbitMQ_basic (746.06s)
=== CONT  TestAccMQBrokerInstanceTypeOfferingsDataSource_basic
--- PASS: TestAccMQBrokerInstanceTypeOfferingsDataSource_basic (14.13s)
=== CONT  TestAccMQBroker_basic
--- PASS: TestAccMQBroker_tags (1028.72s)
=== CONT  TestAccMQBrokerEngineTypesDataSource_basic
--- PASS: TestAccMQBrokerEngineTypesDataSource_basic (11.30s)
=== CONT  TestAccMQBroker_Update_hostInstanceType
--- PASS: TestAccMQBroker_RabbitMQ_config (567.46s)
--- PASS: TestAccMQBroker_basic (957.19s)
--- PASS: TestAccMQBroker_Update_hostInstanceType (1369.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mq	7575.386s

Copy link

github-actions bot commented Jan 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@ewbankkit ewbankkit changed the title Tech debt: Migrate mq resources to AWS SDK for Go v2 [WIP] Tech debt: Migrate mq resources to AWS SDK for Go v2 Jan 8, 2024
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. service/mq Issues and PRs that pertain to the mq service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Jan 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 8, 2024
Copy link

github-actions bot commented Jan 8, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jan 8, 2024
@ewbankkit ewbankkit changed the title [WIP] Tech debt: Migrate mq resources to AWS SDK for Go v2 Tech debt: Migrate mq resources to AWS SDK for Go v2 Jan 8, 2024
@ewbankkit ewbankkit merged commit b6d2bb4 into main Jan 8, 2024
56 checks passed
@ewbankkit ewbankkit deleted the td-migrate-mq-to-aws-sdk-v2 branch January 8, 2024 22:02
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 8, 2024
github-actions bot pushed a commit that referenced this pull request Jan 8, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2024
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/lambda Issues and PRs that pertain to the lambda service. service/mq Issues and PRs that pertain to the mq service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants