Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sagemaker user_profile r_studio_server_pro_app_settings drift #35477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix sagemaker user_profile r_studio_server_pro_app_settings drift #35477

wants to merge 1 commit into from
+4 −2

Conversation

deepakbshetty
Copy link
Contributor

@deepakbshetty deepakbshetty commented Jan 25, 2024 •
edited
Loading

Description

Add/Fix r_studio_server_pro_domain_settings update under domain_settings update to avoid drift.

Relations

Fixes #35382

References

Create User API
Update User API

Output from Acceptance Testing

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Jan 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 25, 2024
@deepakbshetty deepakbshetty mentioned this pull request Jan 25, 2024
Merged
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 25, 2024
@deepakbshetty deepakbshetty force-pushed the f-aws_sagemaker_user_profile-domain_settings_r_studio_server_pro_app_settings branch 2 times, most recently from a92bbaf to 6a7e1f0 Compare January 25, 2024 21:28
@deepakbshetty deepakbshetty force-pushed the f-aws_sagemaker_user_profile-domain_settings_r_studio_server_pro_app_settings branch from 67fd88c to 482aecd Compare May 5, 2024 19:36
@deepakbshetty deepakbshetty force-pushed the f-aws_sagemaker_user_profile-domain_settings_r_studio_server_pro_app_settings branch from 482aecd to aeafa05 Compare July 20, 2024 18:38
@deepakbshetty deepakbshetty requested a review from a team as a code owner July 20, 2024 18:38
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@deepakbshetty
Copy link
Contributor Author

Hi @DrFaust92 , Kindly review. This PR was split from #35416

@DrFaust92
Copy link
Collaborator

Im concerned this is a breaking change, @ewbankkit wdyt?

@deepakbshetty deepakbshetty force-pushed the f-aws_sagemaker_user_profile-domain_settings_r_studio_server_pro_app_settings branch from aeafa05 to 92eb5e8 Compare August 31, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: sagemaker_domain r_studio_server_pro_app_settings reports drift on every apply if disabled
3 participants
@deepakbshetty @DrFaust92 @justinretzolk