Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Datasource Resource Explorer2 Search #36560

Merged
merged 8 commits into from
Mar 28, 2024

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Mar 25, 2024

Description

New datasource Search for Resource Explorer 2

Relations

Relates #36033

References

Output from Acceptance Testing

> make testacc TESTARGS="-run=TestAccResourceExplorer2_serial/SearchDataSource" PKG=resourceexplorer2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/resourceexplorer2/... -v -count 1 -parallel 20  -run=TestAccResourceExplorer2_serial/SearchDataSource -timeout 360m
=== RUN   TestAccResourceExplorer2_serial
=== PAUSE TestAccResourceExplorer2_serial
=== CONT  TestAccResourceExplorer2_serial
=== RUN   TestAccResourceExplorer2_serial/SearchDataSource
=== RUN   TestAccResourceExplorer2_serial/SearchDataSource/basic
=== RUN   TestAccResourceExplorer2_serial/SearchDataSource/indexType
--- PASS: TestAccResourceExplorer2_serial (30.28s)
    --- PASS: TestAccResourceExplorer2_serial/SearchDataSource (30.28s)
        --- PASS: TestAccResourceExplorer2_serial/SearchDataSource/basic (14.03s)
        --- PASS: TestAccResourceExplorer2_serial/SearchDataSource/indexType (16.25s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourceexplorer2  36.584s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. labels Mar 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 25, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@nam054 nam054 marked this pull request as ready for review March 27, 2024 16:27
@nam054 nam054 force-pushed the f-resourceexplorer-search-datasource branch from 6c181e5 to e89c58a Compare March 27, 2024 20:15
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions, but looking really good!

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS="-run=TestAccResourceExplorer2_serial/SearchDataSource" PKG=resourceexplorer2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/resourceexplorer2/... -v -count 1 -parallel 20  -run=TestAccResourceExplorer2_serial/SearchDataSource -timeout 360m
=== RUN   TestAccResourceExplorer2_serial
=== PAUSE TestAccResourceExplorer2_serial
=== CONT  TestAccResourceExplorer2_serial
=== RUN   TestAccResourceExplorer2_serial/SearchDataSource
=== RUN   TestAccResourceExplorer2_serial/SearchDataSource/basic
=== RUN   TestAccResourceExplorer2_serial/SearchDataSource/indexType
    search_data_source_test.go:52: Environment variable RESOURCEEXPLORER_INDEX_TYPE is not set to AGGREGATOR. Before setting this environment variable and running this test, ensure no tests with a LOCAL index type also need to run. Changing the index type will trigger a cool down period of 24 hours.
--- PASS: TestAccResourceExplorer2_serial (14.00s)
    --- PASS: TestAccResourceExplorer2_serial/SearchDataSource (14.00s)
        --- PASS: TestAccResourceExplorer2_serial/SearchDataSource/basic (14.00s)
        --- SKIP: TestAccResourceExplorer2_serial/SearchDataSource/indexType (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/resourceexplorer2  19.558s

website/docs/d/resourceexplorer2_search.html.markdown Outdated Show resolved Hide resolved
website/docs/d/resourceexplorer2_search.html.markdown Outdated Show resolved Hide resolved
@jar-b
Copy link
Member

jar-b commented Mar 28, 2024

Needs a changelog.

@nam054 nam054 merged commit 8354648 into main Mar 28, 2024
47 checks passed
@nam054 nam054 deleted the f-resourceexplorer-search-datasource branch March 28, 2024 19:48
@github-actions github-actions bot added this to the v5.43.0 milestone Mar 28, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 28, 2024
Copy link

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants