-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Datasource Resource Explorer2 Search #36560
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
6c181e5
to
e89c58a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small suggestions, but looking really good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc TESTARGS="-run=TestAccResourceExplorer2_serial/SearchDataSource" PKG=resourceexplorer2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/resourceexplorer2/... -v -count 1 -parallel 20 -run=TestAccResourceExplorer2_serial/SearchDataSource -timeout 360m
=== RUN TestAccResourceExplorer2_serial
=== PAUSE TestAccResourceExplorer2_serial
=== CONT TestAccResourceExplorer2_serial
=== RUN TestAccResourceExplorer2_serial/SearchDataSource
=== RUN TestAccResourceExplorer2_serial/SearchDataSource/basic
=== RUN TestAccResourceExplorer2_serial/SearchDataSource/indexType
search_data_source_test.go:52: Environment variable RESOURCEEXPLORER_INDEX_TYPE is not set to AGGREGATOR. Before setting this environment variable and running this test, ensure no tests with a LOCAL index type also need to run. Changing the index type will trigger a cool down period of 24 hours.
--- PASS: TestAccResourceExplorer2_serial (14.00s)
--- PASS: TestAccResourceExplorer2_serial/SearchDataSource (14.00s)
--- PASS: TestAccResourceExplorer2_serial/SearchDataSource/basic (14.00s)
--- SKIP: TestAccResourceExplorer2_serial/SearchDataSource/indexType (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/resourceexplorer2 19.558s
Needs a changelog. |
This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
New datasource Search for Resource Explorer 2
Relations
Relates #36033
References
Output from Acceptance Testing