Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approximate_creation_date_time_precision to aws_dynamodb_kinesis_streaming_destination #38098

Merged
merged 23 commits into from
Oct 23, 2024

Conversation

rob93c
Copy link
Contributor

@rob93c rob93c commented Jun 24, 2024

Description

Add approximate_creation_date_time_precision to aws_dynamodb_kinesis_streaming_destination resource to be able to set a timestamp precision (only accepted values are either MILLISECOND or MICROSECOND).

References

EnableKinesisStreamingConfiguration API documentation

Closes #38753.
Closes #39844.

Output from Acceptance Testing

% make testacc TESTS=TestAccDynamoDBKinesisStreamingDestination_ PKG=dynamodb
TF_ACC=1 go1.22.4 test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBKinesisStreamingDestination_'  -timeout 360m
=== RUN   TestAccDynamoDBKinesisStreamingDestination_basic
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_basic
=== RUN   TestAccDynamoDBKinesisStreamingDestination_disappears
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_disappears
=== RUN   TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable
=== CONT  TestAccDynamoDBKinesisStreamingDestination_basic
=== CONT  TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable
=== CONT  TestAccDynamoDBKinesisStreamingDestination_disappears
--- PASS: TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable (60.38s)
--- PASS: TestAccDynamoDBKinesisStreamingDestination_disappears (60.70s)
--- PASS: TestAccDynamoDBKinesisStreamingDestination_basic (63.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb   64.952s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jun 24, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 24, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dynamodb Issues and PRs that pertain to the dynamodb service. linter Pertains to changes to or issues with the various linters. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 24, 2024
@rob93c rob93c marked this pull request as ready for review June 24, 2024 15:17
@rob93c rob93c requested a review from a team as a code owner June 24, 2024 15:17
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @rob93c 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit self-assigned this Oct 23, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 23, 2024
# Conflicts:
#	internal/service/dynamodb/kinesis_streaming_destination.go
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDynamoDBKinesisStreamingDestination_' PKG=dynamodb ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/dynamodb/... -v -count 1 -parallel 2  -run=TestAccDynamoDBKinesisStreamingDestination_ -timeout 360m
2024/10/23 12:16:06 Initializing Terraform AWS Provider...
=== RUN   TestAccDynamoDBKinesisStreamingDestination_basic
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_basic
=== RUN   TestAccDynamoDBKinesisStreamingDestination_approximateCreationDateTimePrecision
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_approximateCreationDateTimePrecision
=== RUN   TestAccDynamoDBKinesisStreamingDestination_disappears
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_disappears
=== RUN   TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable
=== PAUSE TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable
=== CONT  TestAccDynamoDBKinesisStreamingDestination_basic
=== CONT  TestAccDynamoDBKinesisStreamingDestination_disappears
--- PASS: TestAccDynamoDBKinesisStreamingDestination_disappears (53.81s)
=== CONT  TestAccDynamoDBKinesisStreamingDestination_approximateCreationDateTimePrecision
--- PASS: TestAccDynamoDBKinesisStreamingDestination_basic (61.46s)
=== CONT  TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable
--- PASS: TestAccDynamoDBKinesisStreamingDestination_approximateCreationDateTimePrecision (55.03s)
--- PASS: TestAccDynamoDBKinesisStreamingDestination_Disappears_dynamoDBTable (52.87s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	119.626s
% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_basic\|TestAccFirehoseDeliveryStream_iceberg' PKG=firehose
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/firehose/... -v -count 1 -parallel 20  -run=TestAccFirehoseDeliveryStream_basic\|TestAccFirehoseDeliveryStream_iceberg -timeout 360m
2024/10/23 14:33:05 Initializing Terraform AWS Provider...
=== RUN   TestAccFirehoseDeliveryStream_basic
=== PAUSE TestAccFirehoseDeliveryStream_basic
=== RUN   TestAccFirehoseDeliveryStream_icebergUpdates
    delivery_stream_test.go:1011: Unresolvable Glue permission issue
--- SKIP: TestAccFirehoseDeliveryStream_icebergUpdates (0.00s)
=== CONT  TestAccFirehoseDeliveryStream_basic
--- PASS: TestAccFirehoseDeliveryStream_basic (160.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	165.175s

@github-actions github-actions bot added the service/firehose Issues and PRs that pertain to the firehose service. label Oct 23, 2024
@ewbankkit
Copy link
Contributor

@rob93c @sonya Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 20fac1c into hashicorp:main Oct 23, 2024
47 checks passed
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 23, 2024
@rob93c rob93c deleted the add-kinesis-timestamp-precision branch October 24, 2024 07:30
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2024
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. linter Pertains to changes to or issues with the various linters. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/firehose Issues and PRs that pertain to the firehose service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants