guardduty: Migrate to AWS SDK v2

[mattburgess]

Description

Relations

Closes #36167
Relates #32976

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[johnsonaj]

LGTM 🚀

% make testacc TESTARGS="-run=TestAccGuardDuty" PKG=guardduty

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/guardduty/... -v -count 1 -parallel 20  -run=TestAccGuardDuty -timeout 360m
=== NAME  TestAccGuardDuty_serial/OrganizationAdminAccount/basic
    organization_admin_account_test.go:28: skipping tests; this AWS account must not be an existing member of an AWS Organization
    guardduty_test.go:89: Environment variable AWS_GUARDDUTY_MEMBER_ACCOUNT_ID is not set. To properly test inviting GuardDuty member accounts, a valid AWS account ID must be provided.
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:89: Environment variable AWS_GUARDDUTY_MEMBER_ACCOUNT_ID is not set. To properly test inviting GuardDuty member accounts, a valid AWS account ID must be provided.
    guardduty_test.go:89: Environment variable AWS_GUARDDUTY_MEMBER_ACCOUNT_ID is not set. To properly test inviting GuardDuty member accounts, a valid AWS account ID must be provided.
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:89: Environment variable AWS_GUARDDUTY_MEMBER_ACCOUNT_ID is not set. To properly test inviting GuardDuty member accounts, a valid AWS account ID must be provided.
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    organization_configuration_test.go:193: skipping tests; this AWS account must not be an existing member of an AWS Organization
    organization_configuration_test.go:241: skipping tests; this AWS account must not be an existing member of an AWS Organization
    organization_configuration_test.go:27: skipping tests; this AWS account must not be an existing member of an AWS Organization
    organization_configuration_test.go:69: skipping tests; this AWS account must not be an existing member of an AWS Organization
    organization_configuration_test.go:147: skipping tests; this AWS account must not be an existing member of an AWS Organization
    organization_configuration_feature_test.go:26: skipping tests; this AWS account must not be an existing member of an AWS Organization
    organization_configuration_feature_test.go:54: skipping tests; this AWS account must not be an existing member of an AWS Organization
    organization_configuration_feature_test.go:96: skipping tests; this AWS account must not be an existing member of an AWS Organization
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
    guardduty_test.go:133: this AWS account has a GuardDuty Detector
--- PASS: TestAccGuardDuty_serial (21.94s)
    --- PASS: TestAccGuardDuty_serial/OrganizationAdminAccount (1.36s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationAdminAccount/basic (1.36s)
    --- PASS: TestAccGuardDuty_serial/Member (0.07s)
        --- SKIP: TestAccGuardDuty_serial/Member/invitationMessage (0.00s)
        --- SKIP: TestAccGuardDuty_serial/Member/basic (0.07s)
        --- SKIP: TestAccGuardDuty_serial/Member/inviteOnUpdate (0.00s)
        --- SKIP: TestAccGuardDuty_serial/Member/inviteDisassociate (0.00s)
    --- PASS: TestAccGuardDuty_serial/DetectorFeature (0.20s)
        --- SKIP: TestAccGuardDuty_serial/DetectorFeature/basic (0.06s)
        --- SKIP: TestAccGuardDuty_serial/DetectorFeature/additional_configuration (0.07s)
        --- SKIP: TestAccGuardDuty_serial/DetectorFeature/multiple (0.07s)
    --- PASS: TestAccGuardDuty_serial/Filter (0.27s)
        --- SKIP: TestAccGuardDuty_serial/Filter/tags (0.07s)
        --- SKIP: TestAccGuardDuty_serial/Filter/disappears (0.07s)
        --- SKIP: TestAccGuardDuty_serial/Filter/basic (0.07s)
        --- SKIP: TestAccGuardDuty_serial/Filter/update (0.07s)
    --- PASS: TestAccGuardDuty_serial/FindingIDs (11.18s)
        --- PASS: TestAccGuardDuty_serial/FindingIDs/datasource_basic (11.18s)
    --- PASS: TestAccGuardDuty_serial/InviteAccepter (0.00s)
        --- SKIP: TestAccGuardDuty_serial/InviteAccepter/basic (0.00s)
    --- PASS: TestAccGuardDuty_serial/IPSet (0.13s)
        --- SKIP: TestAccGuardDuty_serial/IPSet/tags (0.07s)
        --- SKIP: TestAccGuardDuty_serial/IPSet/basic (0.07s)
    --- PASS: TestAccGuardDuty_serial/Detector (0.56s)
        --- SKIP: TestAccGuardDuty_serial/Detector/datasources_s3logs (0.07s)
        --- SKIP: TestAccGuardDuty_serial/Detector/datasources_kubernetes_audit_logs (0.07s)
        --- SKIP: TestAccGuardDuty_serial/Detector/datasources_malware_protection (0.07s)
        --- SKIP: TestAccGuardDuty_serial/Detector/datasources_all (0.07s)
        --- SKIP: TestAccGuardDuty_serial/Detector/tags (0.07s)
        --- SKIP: TestAccGuardDuty_serial/Detector/datasource_basic (0.07s)
        --- SKIP: TestAccGuardDuty_serial/Detector/datasource_id (0.08s)
        --- SKIP: TestAccGuardDuty_serial/Detector/basic (0.06s)
    --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration (4.55s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfiguration/kubernetes (0.12s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfiguration/malwareProtection (0.11s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfiguration/basic (2.28s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfiguration/autoEnableOrganizationMembers (0.12s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfiguration/s3Logs (1.92s)
    --- PASS: TestAccGuardDuty_serial/OrganizationConfigurationFeature (3.34s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfigurationFeature/basic (0.11s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfigurationFeature/additional_configuration (1.32s)
        --- SKIP: TestAccGuardDuty_serial/OrganizationConfigurationFeature/multiple (1.91s)
    --- PASS: TestAccGuardDuty_serial/ThreatIntelSet (0.14s)
        --- SKIP: TestAccGuardDuty_serial/ThreatIntelSet/basic (0.07s)
        --- SKIP: TestAccGuardDuty_serial/ThreatIntelSet/tags (0.07s)
    --- PASS: TestAccGuardDuty_serial/PublishingDestination (0.13s)
        --- SKIP: TestAccGuardDuty_serial/PublishingDestination/basic (0.07s)
        --- SKIP: TestAccGuardDuty_serial/PublishingDestination/disappears (0.07s)
--- PASS: TestAccGuardDutyMalwareProtectionPlan_disappears (30.31s)
--- PASS: TestAccGuardDutyMalwareProtectionPlan_basic (33.03s)
--- PASS: TestAccGuardDutyMalwareProtectionPlan_role (45.58s)
--- PASS: TestAccGuardDutyMalwareProtectionPlan_protectedResourceS3BucketName (48.17s)
--- PASS: TestAccGuardDutyMalwareProtectionPlan_actionsTaggingStatus (52.37s)
--- PASS: TestAccGuardDutyMalwareProtectionPlan_tags (58.26s)
--- PASS: TestAccGuardDutyMalwareProtectionPlan_protectedResourceS3BucketObjectPrefix (59.05s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/guardduty	64.856s

[johnsonaj]

@mattburgess thank you for the contribution! 🎉

[github-actions]

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.