Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_elasticache_replication_group: fix crash setting replicas_per_node_group #38797

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Aug 9, 2024

Description

In cases where the NodeGroups list in the read ouput is empty, the provider would crash attempting to read the NodeGroupMembers count from the first item in the list.

Relations

Closes #37771

Output from Acceptance Testing

% make testacc PKG=elasticache TESTS="TestAccElastiCacheReplicationGroup_basic|TestAccElastiCacheReplicationGroup_ClusterMode_basic"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheReplicationGroup_basic|TestAccElastiCacheReplicationGroup_ClusterMode_basic'  -timeout 360m

--- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (775.08s)
--- PASS: TestAccElastiCacheReplicationGroup_basic (775.23s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (915.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        921.685s

Copy link

github-actions bot commented Aug 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/elasticache Issues and PRs that pertain to the elasticache service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 9, 2024
…node_group`

In cases where the `NodeGroups` list in the read ouput is empty, the provider would crash attempting to read the `NodeGroupMembers` count from the first item in the list.

```console
% make testacc PKG=elasticache TESTS="TestAccElastiCacheReplicationGroup_basic|TestAccElastiCacheReplicationGroup_ClusterMode_basic"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/elasticache/... -v -count 1 -parallel 20 -run='TestAccElastiCacheReplicationGroup_basic|TestAccElastiCacheReplicationGroup_ClusterMode_basic'  -timeout 360m

--- PASS: TestAccElastiCacheReplicationGroup_basic_v5 (775.08s)
--- PASS: TestAccElastiCacheReplicationGroup_basic (775.23s)
--- PASS: TestAccElastiCacheReplicationGroup_ClusterMode_basic (915.76s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elasticache        921.685s
```
@jar-b jar-b force-pushed the b-elasticache-replication-group-crash branch from 5e84f7c to 366b28e Compare August 9, 2024 14:48
@jar-b jar-b added crash Results from or addresses a Terraform crash or kernel panic. bug Addresses a defect in current functionality. labels Aug 9, 2024
@jar-b jar-b marked this pull request as ready for review August 9, 2024 15:37
@jar-b jar-b requested a review from a team as a code owner August 9, 2024 15:37
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@jar-b jar-b merged commit e8c4241 into main Aug 9, 2024
52 checks passed
@jar-b jar-b deleted the b-elasticache-replication-group-crash branch August 9, 2024 19:45
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 9, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_elasticache_replication_group panics with runtime error: index out of range [0] with length 0
2 participants