Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RabbitMQ 3.13 and ActiveMQ 5.18 Version Mismatch #39024

Merged

Commits on Aug 22, 2024

  1. fix: fixed bug for aws_mq_broker that simplified version RabbitMQ 3.1…

    …3 and ActiveMQ 5.18 change to their corresponding patch version
    architec committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    73fcefe View commit details
    Browse the repository at this point in the history
  2. fix: fixed bug for aws_mq_broker that simplified version RabbitMQ 3.1…

    …3 and ActiveMQ 5.18 change to their corresponding patch version
    architec committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    635d825 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2024

  1. fix: fixed bug for aws_mq_broker that simplified version RabbitMQ 3.1…

    …3 and ActiveMQ 5.18 change to their corresponding patch version
    architec committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3e775e7 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    4038f6c View commit details
    Browse the repository at this point in the history
  2. chore: make testacc-lint-fix

    jar-b committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    8331fda View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9501238 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    73df9e2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    16b4fb5 View commit details
    Browse the repository at this point in the history
  6. r/aws_mq_broker: adjust normalization function args, unit test

    ```console
    % make testacc PKG=mq TESTS=TestAccMQBroker_normalizedEngineVersion
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.6 test ./internal/service/mq/... -v -count 1 -parallel 20 -run='TestAccMQBroker_normalizedEngineVersion'  -timeout 360m
    
    --- PASS: TestAccMQBroker_normalizedEngineVersion (973.99s)
    PASS
    ok      github.com/hashicorp/terraform-provider-aws/internal/service/mq 980.237s
    ```
    
    ```console
    % go test -count=1 ./internal/service/mq/... -run=TestNormalizeEngineVersion
    ok      github.com/hashicorp/terraform-provider-aws/internal/service/mq 6.269s
    ```
    jar-b committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    51e25a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    391e82f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    567daf6 View commit details
    Browse the repository at this point in the history
  3. chore: changelog

    jar-b committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ca45ed9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    01ab5f8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d9c4feb View commit details
    Browse the repository at this point in the history
  6. chore: make clean-tidy

    jar-b committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b189df9 View commit details
    Browse the repository at this point in the history
  7. r/aws_mq_broker: fix engine_version update logic

    Previously the `engine_version` sent to the update API was the version read from the remote resource, rather than the configured value. This change passes the configured values for `engine_type`, `engine_version`, and `auto_minor_version_upgrade` to the `normalizeEngineVersion` function instead, allowing explicitly configured engine version updates to once again function properly.
    
    ```console
    % TF_ACC_TERRAFORM_VERSION=1.7.5 make testacc PKG=mq TESTS="TestAccMQBroker_"
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.6 test ./internal/service/mq/... -v -count 1 -parallel 20 -run='TestAccMQBroker_'  -timeout 360m
    
    --- PASS: TestAccMQBroker_RabbitMQ_validationAuditLog (631.07s)
    === CONT  TestAccMQBroker_normalizedEngineVersion
    --- PASS: TestAccMQBroker_RabbitMQ_normalizedEngineVersion (647.54s)
    === CONT  TestAccMQBroker_RabbitMQ_basic
    --- PASS: TestAccMQBroker_RabbitMQ_autoMinorVersionUpgrade (659.43s)
    === CONT  TestAccMQBroker_Update_hostInstanceType
    --- PASS: TestAccMQBroker_RabbitMQ_config (662.56s)
    --- PASS: TestAccMQBroker_RabbitMQ_cluster (669.10s)
    --- PASS: TestAccMQBroker_RabbitMQ_logs (672.09s)
    --- PASS: TestAccMQBroker_throughputOptimized (939.31s)
    --- PASS: TestAccMQBroker_ldap (953.94s)
    --- PASS: TestAccMQBroker_EncryptionOptions_kmsKeyID (989.45s)
    --- PASS: TestAccMQBroker_EncryptionOptions_managedKeyEnabled (1038.29s)
    --- PASS: TestAccMQBroker_EncryptionOptions_managedKeyDisabled (1043.15s)
    --- PASS: TestAccMQBroker_disappears (1060.67s)
    --- PASS: TestAccMQBroker_basic (1064.66s)
    --- PASS: TestAccMQBroker_tags (1078.43s)
    --- PASS: TestAccMQBroker_Update_engineVersion (1240.34s)
    --- PASS: TestAccMQBroker_Update_securityGroup (1262.55s)
    --- PASS: TestAccMQBroker_RabbitMQ_basic (660.77s)
    --- PASS: TestAccMQBroker_Update_users (1429.44s)
    --- PASS: TestAccMQBroker_normalizedEngineVersion (843.55s)
    --- PASS: TestAccMQBroker_AllFields_defaultVPC (1593.85s)
    --- PASS: TestAccMQBroker_AllFields_customVPC (1740.74s)
    --- PASS: TestAccMQBroker_Update_hostInstanceType (1353.62s)
    --- PASS: TestAccMQBroker_dataReplicationMode (2095.33s)
    PASS
    ok      github.com/hashicorp/terraform-provider-aws/internal/service/mq 2101.590s
    ```
    jar-b committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7ce1385 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. chore: make fix-constants

    jar-b committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cda3a9f View commit details
    Browse the repository at this point in the history